hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Add peak indicators (#7295)

Browse Source 
Add peak indicators to the mixer strips. They show the maximum peak value
that was observed and can be reset by clicking on them.

## Implementation details
The implementation works via a signal/slot mechanism. The `Fader` class
has a new signal `peakChanged` which reports peak values as
amplifications. A new class `PeakIndicator` is added which has a slot
`updatePeak` which is connected to the new signal in `Fader`.

The `PeakIndicator` inherits from `QLabel` and mainly deals with updating
the label text from the current peak value.

Add a `PeakIndicator` instance to `MixerChannelView`. Add a `reset`
method to `MixerChannelView` so that the mixer channel can be reset on
the loading of new projects, etc. The current implementation resets the
peak indicator back to -inf dbFS. The `reset` method is called in
`MixerView::clear`.

Remove the clamping in `Fader::setPeak` so that all peaks are reported.
Emit the new signal if the peak changes.
This commit is contained in:
Michael Gregorius
2024-06-01 12:09:47 +02:00
committed by GitHub
parent 4e93f51b75
commit 042f8ac325
10 changed files with 177 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
data/themes/classic/style.css
View File

@@ -661,6 +661,11 @@ lmms--gui--MixerChannelView QGraphicsView {
border-style: none;
}
lmms--gui--PeakIndicator {
background-color: #111811;
font-size: 7pt;
}
/* persistent peak markers for fx peak meters */
lmms--gui--Fader {
qproperty-peakOk: rgb( 74, 253, 133);

5
data/themes/default/style.css
View File

@@ -710,6 +710,11 @@ lmms--gui--MixerChannelView QGraphicsView {
border-style: none;
}
lmms--gui--PeakIndicator {
background-color: #111811;
font-size: 7pt;
}
/* persistent peak markers for fx peak meters */
lmms--gui--Fader {
qproperty-peakOk: #0ad45c;