From 07267abca0aa7c3d5aa3bd03e7a80e9aa82736b4 Mon Sep 17 00:00:00 2001 From: Tobias Doerffel Date: Mon, 1 Jun 2009 11:12:26 +0200 Subject: [PATCH] MidiControlListener: use QString::isEmpty() for testing string Instead of doing a whole string comparison against "", use QString::isEmpty() which is both faster and better style. Signed-off-by: Tobias Doerffel --- src/gui/setup_dialog_mcl.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gui/setup_dialog_mcl.cpp b/src/gui/setup_dialog_mcl.cpp index 474981689..70b092695 100644 --- a/src/gui/setup_dialog_mcl.cpp +++ b/src/gui/setup_dialog_mcl.cpp @@ -117,7 +117,7 @@ setupDialogMCL::setupDialogMCL( setupDialog * _parent ) : MidiControlListener::ActionNameMap action = MidiControlListener::action2ActionNameMap( (MidiControlListener::EventAction) i ); - if( action.name != "" ) + if( !action.name.isEmpty() ) { m_actionsKeyBox->addItem( action.name ); } @@ -140,7 +140,7 @@ setupDialogMCL::setupDialogMCL( setupDialog * _parent ) : MidiControlListener::ActionNameMap action = MidiControlListener::action2ActionNameMap( (MidiControlListener::EventAction) i ); - if( action.name != "" && + if( !action.name.isEmpty() && action.action != MidiControlListener::ActionControl ) { m_actionsControllerBox->addItem( action.name );