From 0e2c6762f0f9a90ffda54464aa42da36f0562e99 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Wed, 15 Jul 2009 11:42:26 -0700 Subject: [PATCH] AudioFileMp3 - fixed clipping issue AudioFileMp3::rescale was missing a clip boundary on -1 and thus could have caused artifacts in exported MP3s. Fixed. --- src/core/audio/audio_file_mp3.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/audio/audio_file_mp3.cpp b/src/core/audio/audio_file_mp3.cpp index 0ba4cbe89..270740fcf 100644 --- a/src/core/audio/audio_file_mp3.cpp +++ b/src/core/audio/audio_file_mp3.cpp @@ -149,7 +149,7 @@ bool AudioFileMp3::startEncoding( void ) short int AudioFileMp3::rescale(float sample) { - return (qMin(sample, 1) / 1) * std::numeric_limits::max(); + return (qMax(qMin(sample, 1), -1) / 1) * std::numeric_limits::max(); } // encode data and write to file