hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Allow PianoRoll to open empty again, but with a help icon (#8148)

Browse Source 
Fixes #8152

Revert PianoRoll closing when empty (caused issues with detached windows)
Remove TextFloat warning when there are no instruments/multiple clips (showed up when reloading project)
(Keep clip creation for empty projects)
Add an icon and updated message in empty PianoRoll.
Mark PianoRollWindow invalid when there is no clip, making buttons impossible to click

---------

Co-authored-by: Fawn <rubiefawn@gmail.com>
This commit is contained in:
Alex
2025-12-14 14:40:35 +01:00
committed by GitHub
parent 8627616175
commit 0ffcfe3bff
5 changed files with 77 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
include/PianoRoll.h
View File

@@ -146,7 +146,6 @@ public:
return m_midiClip;
}
// TODO remove this since PianoRoll should no longer be visible without a valid midi clip
bool hasValidMidiClip() const
{
return m_midiClip != nullptr;