From 18d34431b352f49d0312d6509aef0a4bc2dd12be Mon Sep 17 00:00:00 2001
From: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com>
Date: Mon, 8 Jan 2024 06:50:55 +0530
Subject: [PATCH] Run without terminal for non-debug Windows builds (#7022)

* set win32 flag

* added mingw too to win32 flag + dom's suggestions

* revert unnecessary changes i made.

* simplify msys linker flag condition

* removed extra whitespace

* whitespace change 2
---
 src/CMakeLists.txt | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index c074ea2ef..d55a725dd 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -210,22 +210,16 @@ ENDFOREACH()
 
 set_target_properties(lmms PROPERTIES
 	ENABLE_EXPORTS ON
+	WIN32_EXECUTABLE $<NOT:$<CONFIG:DEBUG>>
 )
 
-IF(LMMS_BUILD_WIN32)
-	IF(NOT MSVC)
-		SET_PROPERTY(TARGET lmms
-			APPEND_STRING PROPERTY LINK_FLAGS " -mwindows"
-		)
-	ENDIF()
-	IF(LMMS_BUILD_MSYS)
-		# ENABLE_EXPORTS property has no effect in some MSYS2 configurations.
-		# Add the linker flag manually to create liblmms.dll.a import library
-		SET_PROPERTY(TARGET lmms
-			APPEND_STRING PROPERTY LINK_FLAGS " -Wl,--out-implib,liblmms.dll.a"
-		)
-	ENDIF()
-ELSE()
+IF(LMMS_BUILD_MSYS)
+	# ENABLE_EXPORTS property has no effect in some MSYS2 configurations.
+	# Add the linker flag manually to create liblmms.dll.a import library
+	SET_PROPERTY(TARGET lmms
+		APPEND_STRING PROPERTY LINK_FLAGS " -Wl,--out-implib,liblmms.dll.a"
+	)
+ELSEIF(NOT WIN32)
 	if(CMAKE_INSTALL_MANDIR)
 		SET(INSTALL_MANDIR ${CMAKE_INSTALL_MANDIR})
 	ELSE(CMAKE_INSTALL_MANDIR)