hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Adjust the wheel behavior for faders with dB models

Browse Source 
Make the faders of the Crossover Equalizer, Equalizer, Compressor and
Delay behave like the mixer faders, i.e. step in sizes of 3 dB, 1dB and
0.1 dB depending on whether a modifier key is pressed or not.

Extract some common code to do so and add some `const` keywords.
This commit is contained in:
Michael Gregorius
2024-12-24 20:38:32 +01:00
parent 3510dea4ae
commit 1f9f96deeb
1 changed files with 23 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/gui/widgets/Fader.cpp
View File

@@ -214,9 +214,26 @@ void Fader::wheelEvent (QWheelEvent* ev)
{
const int direction = (ev->angleDelta().y() > 0 ? 1 : -1) * (ev->inverted() ? -1 : 1);
float incrementValue = 1.;
auto const modKeys = ev->modifiers();
if (modKeys == Qt::ShiftModifier)
{
// The shift is intended to go through the values in very coarse steps as in:
// "Shift into overdrive"
incrementValue = 3.;
}
else if (modKeys == Qt::ControlModifier)
{
// The control key gives more control, i.e. it enables more fine-grained adjustments
incrementValue = 0.1;
}
const float increment = incrementValue * direction;
if (modelIsLinear())
{
auto value = model()->value();
const auto value = model()->value();
if (value <= 0.)
{
@@ -230,33 +247,18 @@ void Fader::wheelEvent (QWheelEvent* ev)
else
{
// We can safely compute the dB value as the value is greater than 0
auto valueInDB = ampToDbfs(value);
const auto valueInDB = ampToDbfs(value);
auto incrementValue = 1.;
auto const modKeys = ev->modifiers();
if (modKeys == Qt::ShiftModifier)
{
// The shift is intended to go through the values in very coarse steps as in:
// "Shift into overdrive"
incrementValue = 3.;
}
else if (modKeys == Qt::ControlModifier)
{
// The control key gives more control, i.e. it enables more fine-grained adjustments
incrementValue = 0.1;
}
auto increment = incrementValue * direction;
auto adjustedValue = valueInDB + increment;
const auto adjustedValue = valueInDB + increment;
model()->setValue(adjustedValue < m_faderMinDb ? 0. : dbfsToAmp(adjustedValue));
}
}
else
{
model()->incValue(direction);
const auto adjustedValue = std::clamp(model()->value() + increment, model()->minValue(), model()->maxValue());
model()->setValue(adjustedValue);
}
updateTextFloat();