From 20f50350e6a1954e9bd821ea2b3f4d007fc83b82 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Sun, 14 Dec 2008 09:55:06 +0000 Subject: [PATCH] note volume bars are painted blue if selected git-svn-id: https://lmms.svn.sf.net/svnroot/lmms/trunk/lmms@1920 0778d3d1-df1d-0410-868b-ea421aaaa00d --- ChangeLog | 1 + TODO | 3 +-- src/gui/piano_roll.cpp | 6 +++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 731361c0a..5905412db 100644 --- a/ChangeLog +++ b/ChangeLog @@ -7,6 +7,7 @@ and panning - switching between note edit modes is more clear with label text and a right click menu + - note volume bars are painted blue if selected 2008-12-14 Tobias Doerffel diff --git a/TODO b/TODO index 999e0ba4d..6c4a625d7 100644 --- a/TODO +++ b/TODO @@ -52,8 +52,6 @@ - add FLAC as export-format? Andrew Kelley's todo: -- paint note volume blue if selected -- make the tip of a panning bar blue too so the user knows it's selected - when you click on a note in the piano roll, it plays the note, but not the correct panning - fix ctrl+mousewheel zooming in - if you press both controls at the same time, the piano roll gets stuck in selection mode @@ -83,3 +81,4 @@ Andrew Kelley's todo: - make it so that 3xosc notes don't max out - implement note detuning (used to be ctrl+click to access note detuning) (need some other intuitive way to access note detuning as ctrl, shift, and alt are all being used) - copy-pasted automation patterns have to be manually linked back to their knob for some reason +- fix memory leaks diff --git a/src/gui/piano_roll.cpp b/src/gui/piano_roll.cpp index 9524332b5..a393dd548 100644 --- a/src/gui/piano_roll.cpp +++ b/src/gui/piano_roll.cpp @@ -2542,6 +2542,10 @@ void pianoRoll::paintEvent( QPaintEvent * _pe ) { QColor color = QColor::fromHsv( 120, 221, qMin(255, 60 + ( *it )->getVolume() ) ); + if( ( *it )->selected() ) + { + color.setRgb( 0x00, 0x40, 0xC0 ); + } p.setPen( QPen( color, NE_LINE_WIDTH ) ); @@ -2583,7 +2587,7 @@ void pianoRoll::paintEvent( QPaintEvent * _pe ) y_base - key * KEY_LINE_HEIGHT ); } } - + p.setPen( QPen( QColor( 0xEA, 0xA1, 0x00 ), NE_LINE_WIDTH*2 ) ); p.drawPoints( editHandles );