From 26415cd53ed16a87c54623c606c13a2e74b93849 Mon Sep 17 00:00:00 2001 From: Lukas W Date: Mon, 17 Nov 2014 11:03:13 +0100 Subject: [PATCH] Fix segfault in FxMixerView, fix a memory leak in EffectSelectDialog Segfault occured when moving a channel --- src/gui/EffectSelectDialog.cpp | 1 + src/gui/FxMixerView.cpp | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gui/EffectSelectDialog.cpp b/src/gui/EffectSelectDialog.cpp index c3bbe9901..d191ef522 100644 --- a/src/gui/EffectSelectDialog.cpp +++ b/src/gui/EffectSelectDialog.cpp @@ -128,6 +128,7 @@ EffectSelectDialog::EffectSelectDialog( QWidget * _parent ) : EffectSelectDialog::~EffectSelectDialog() { + delete ui; } diff --git a/src/gui/FxMixerView.cpp b/src/gui/FxMixerView.cpp index a18ccd7ae..bd7df6e2f 100644 --- a/src/gui/FxMixerView.cpp +++ b/src/gui/FxMixerView.cpp @@ -391,11 +391,10 @@ void FxMixerView::moveChannelLeft(int index) int replaceIndex = chLayout->indexOf(m_fxChannelViews[i]->m_fxLine); chLayout->removeWidget(m_fxChannelViews[i]->m_fxLine); + m_racksLayout->removeWidget( m_fxChannelViews[i]->m_rackView ); delete m_fxChannelViews[i]->m_fader; delete m_fxChannelViews[i]->m_muteBtn; - delete m_fxChannelViews[i]->m_fxLine; delete m_fxChannelViews[i]; - m_racksLayout->removeWidget( m_fxChannelViews[i]->m_rackView ); // add it again m_fxChannelViews[i] = new FxChannelView( m_channelAreaWidget, this, i );