From 22ca36f764c57b7e0555e65ea9599ed84badcaaf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stian=20J=C3=B8rgensrud?= Date: Mon, 24 Nov 2014 22:38:13 +0100 Subject: [PATCH 1/4] Two new presets The clap is nothing more than a dry clap. As of now there is a clap with decay or something. I used two evenings to make the clap I wanted so I figured other people maybe wanted a dry clap too. Of course it is probably I who suck at adjusting knobs correctly, but I reckon there are more of us. :worried: I probably didn't spend too much time on the kick, but as of now there is only a trapkick in LMMS (kick with long delay), and though we agree on that it is easy to make kicks in Kicker, it is even easier to use existing presets and adjust a preexisting preset. So I missed a short kick in LMMS, and so I made one. --- data/presets/Kicker/Clap dry.xpf | 44 ++++++++++++++++++++++++++++++ data/presets/Kicker/Kick power.xpf | 21 ++++++++++++++ 2 files changed, 65 insertions(+) create mode 100644 data/presets/Kicker/Clap dry.xpf create mode 100644 data/presets/Kicker/Kick power.xpf diff --git a/data/presets/Kicker/Clap dry.xpf b/data/presets/Kicker/Clap dry.xpf new file mode 100644 index 000000000..f6c938959 --- /dev/null +++ b/data/presets/Kicker/Clap dry.xpf @@ -0,0 +1,44 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/data/presets/Kicker/Kick power.xpf b/data/presets/Kicker/Kick power.xpf new file mode 100644 index 000000000..b4e1daba3 --- /dev/null +++ b/data/presets/Kicker/Kick power.xpf @@ -0,0 +1,21 @@ + + + + + + + + + + + + + + + + + + + + + From e84c2465ee534f16c17564460777f221e3f841ea Mon Sep 17 00:00:00 2001 From: dave Date: Fri, 28 Nov 2014 22:26:45 +0000 Subject: [PATCH 2/4] Added checks to if( m_dfControls.m_filter1Model.isValueChanged() || m_filter1changed ) if( m_dfControls.m_filter2Model.isValueChanged() || m_filter2changed ) so the filter types get initilized --- plugins/DualFilter/DualFilter.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/DualFilter/DualFilter.cpp b/plugins/DualFilter/DualFilter.cpp index 22036930c..d20f3374b 100644 --- a/plugins/DualFilter/DualFilter.cpp +++ b/plugins/DualFilter/DualFilter.cpp @@ -84,12 +84,12 @@ bool DualFilterEffect::processAudioBuffer( sampleFrame* buf, const fpp_t frames const float d = dryLevel(); const float w = wetLevel(); - if( m_dfControls.m_filter1Model.isValueChanged() ) + if( m_dfControls.m_filter1Model.isValueChanged() || m_filter1changed ) { m_filter1->setFilterType( m_dfControls.m_filter1Model.value() ); m_filter1changed = true; } - if( m_dfControls.m_filter2Model.isValueChanged() ) + if( m_dfControls.m_filter2Model.isValueChanged() || m_filter2changed ) { m_filter2->setFilterType( m_dfControls.m_filter2Model.value() ); m_filter2changed = true; From 05fd71190b908654d03a24745f815cb056916693 Mon Sep 17 00:00:00 2001 From: dave Date: Sat, 29 Nov 2014 11:41:27 +0000 Subject: [PATCH 3/4] fix for underlying bug 1293 loop markers initilized m_moveXoff when moving loop markers --- src/core/timeline.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/timeline.cpp b/src/core/timeline.cpp index fd5022be4..8f83f2822 100644 --- a/src/core/timeline.cpp +++ b/src/core/timeline.cpp @@ -294,6 +294,7 @@ void timeLine::mousePressEvent( QMouseEvent* event ) } else if( event->button() == Qt::RightButton || event->button() == Qt::MiddleButton ) { + m_moveXOff = s_posMarkerPixmap->width() / 2; const MidiTime t = m_begin + static_cast( event->x() * MidiTime::ticksPerTact() / m_ppt ); if( m_loopPos[0] > m_loopPos[1] ) { From 4cbb2b721ff562b198cc306bd165c5ac18d698cc Mon Sep 17 00:00:00 2001 From: Vesa V Date: Sat, 29 Nov 2014 21:52:21 +0200 Subject: [PATCH 4/4] Update timeline.cpp tab added --- src/core/timeline.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/timeline.cpp b/src/core/timeline.cpp index 8f83f2822..a67ddc3b8 100644 --- a/src/core/timeline.cpp +++ b/src/core/timeline.cpp @@ -294,7 +294,7 @@ void timeLine::mousePressEvent( QMouseEvent* event ) } else if( event->button() == Qt::RightButton || event->button() == Qt::MiddleButton ) { - m_moveXOff = s_posMarkerPixmap->width() / 2; + m_moveXOff = s_posMarkerPixmap->width() / 2; const MidiTime t = m_begin + static_cast( event->x() * MidiTime::ticksPerTact() / m_ppt ); if( m_loopPos[0] > m_loopPos[1] ) {