From 3f6f266a4622fe879c2ae250db2d4f9b1c5c7d7a Mon Sep 17 00:00:00 2001 From: Cyrille Bollu Date: Wed, 9 Mar 2016 11:53:54 +0100 Subject: [PATCH] Rewrote ProjectVersionTest.cpp to use QVERIFY and indeed fail when it's supposed to fail, and added 2 tests in this test suite. --- tests/src/core/ProjectVersionTest.cpp | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/tests/src/core/ProjectVersionTest.cpp b/tests/src/core/ProjectVersionTest.cpp index 7e6d981ea..f0198ff5e 100644 --- a/tests/src/core/ProjectVersionTest.cpp +++ b/tests/src/core/ProjectVersionTest.cpp @@ -30,14 +30,16 @@ class ProjectVersionTest : QTestSuite { Q_OBJECT private slots: - void test() - { - Q_ASSERT(ProjectVersion("1.1.0", CompareType::Minor) > "1.0.3"); - Q_ASSERT(ProjectVersion("1.1.0", CompareType::Major) < "2.1.0"); - Q_ASSERT(ProjectVersion("1.1.0", CompareType::Release) > "0.2.1"); - Q_ASSERT(ProjectVersion("1.1.4", CompareType::Release) < "1.1.10"); - Q_ASSERT(ProjectVersion("1.1.0", CompareType::Minor) == "1.1.5"); - } -} instance; + void ProjectVersionComparaisonTests() + { + QVERIFY(ProjectVersion("1.1.0", CompareType::Minor) > "1.0.3"); + QVERIFY(ProjectVersion("1.1.0", CompareType::Major) < "2.1.0"); + QVERIFY(ProjectVersion("1.1.0", CompareType::Release) > "0.2.1"); + QVERIFY(ProjectVersion("1.1.4", CompareType::Release) < "1.1.10"); + QVERIFY(ProjectVersion("1.1.0", CompareType::Minor) == "1.1.5"); + QVERIFY( ! ( ProjectVersion("3.1.0", CompareType::Minor) < "2.2.5" ) ); + QVERIFY( ! ( ProjectVersion("2.5.0", CompareType::Release) < "2.2.5" ) ); + } +} ProjectVersionTests; #include "ProjectVersionTest.moc"