From 3fa4b98a9ec73a9ced691e08f71d46fd18c99760 Mon Sep 17 00:00:00 2001
From: Johannes Lorenz <j.git@lorenz-ho.me>
Date: Sun, 4 Oct 2020 21:47:47 +0200
Subject: [PATCH] Remove redundant LV2Ports::Audio::m_optional

The same info is already stored in the `Lv2Ports::Meta` base class.
---
 include/Lv2Ports.h        | 2 +-
 src/core/lv2/Lv2Ports.cpp | 4 ++--
 src/core/lv2/Lv2Proc.cpp  | 6 ++----
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/include/Lv2Ports.h b/include/Lv2Ports.h
index c9e6c16c8..567e1ddb5 100644
--- a/include/Lv2Ports.h
+++ b/include/Lv2Ports.h
@@ -162,7 +162,7 @@ struct Cv : public VisitablePort<Cv, ControlPortBase>
 
 struct Audio : public VisitablePort<Audio, PortBase>
 {
-	Audio(std::size_t bufferSize, bool isSidechain, bool isOptional);
+	Audio(std::size_t bufferSize, bool isSidechain);
 
 	//! Copy buffer passed by LMMS into our ports
 	//! @param channel channel index into each sample frame
diff --git a/src/core/lv2/Lv2Ports.cpp b/src/core/lv2/Lv2Ports.cpp
index 48fe47f60..f2fac5744 100644
--- a/src/core/lv2/Lv2Ports.cpp
+++ b/src/core/lv2/Lv2Ports.cpp
@@ -201,8 +201,8 @@ QString PortBase::uri() const
 
 
 
-Audio::Audio(std::size_t bufferSize, bool isSidechain, bool isOptional)
-	: m_buffer(bufferSize), m_sidechain(isSidechain), m_optional(isOptional)
+Audio::Audio(std::size_t bufferSize, bool isSidechain)
+	: m_buffer(bufferSize), m_sidechain(isSidechain)
 {
 }
 
diff --git a/src/core/lv2/Lv2Proc.cpp b/src/core/lv2/Lv2Proc.cpp
index 9046001ab..26593428b 100644
--- a/src/core/lv2/Lv2Proc.cpp
+++ b/src/core/lv2/Lv2Proc.cpp
@@ -56,8 +56,7 @@ Plugin::PluginTypes Lv2Proc::check(const LilvPlugin *plugin,
 		bool portMustBeUsed =
 			!portIsSideChain(plugin,
 							lilv_plugin_get_port_by_index(plugin, portNum)) &&
-			!portIsOptional(plugin,
-							lilv_plugin_get_port_by_index(plugin, portNum));
+			!meta.m_optional;
 		if (meta.m_type == Lv2Ports::Type::Audio && portMustBeUsed)
 			++audioChannels[meta.m_flow == Lv2Ports::Flow::Output
 				? outCount : inCount];
@@ -381,8 +380,7 @@ void Lv2Proc::createPort(std::size_t portNum)
 				new Lv2Ports::Audio(
 						static_cast<std::size_t>(
 							Engine::mixer()->framesPerPeriod()),
-						portIsSideChain(m_plugin, lilvPort),
-						portIsOptional(m_plugin, lilvPort)
+						portIsSideChain(m_plugin, lilvPort)
 					);
 			port = audio;
 			break;