hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Improve performance when moving channels in the Mixer (#8235)

Browse Source 
Improves performance when moving mixer channels to the left or right using simple Qt layout operations and swapping of values. This commit also addresses a deadlock in Mixer::mixToChannel by ensuring we lock and unlock the same channel regardless of any move operations occurring simultaneously on another thread.
This commit is contained in:
Sotonye Atemie
2026-02-09 11:57:28 -05:00
committed by GitHub
parent 84f691cafc
commit 441fd905be
5 changed files with 22 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
include/MixerChannelView.h
View File

@@ -64,6 +64,7 @@ public:
void keyPressEvent(QKeyEvent* ke) override;
void reset();
int channelIndex() const { return m_channelIndex; }
void setChannelIndex(int index);

1
include/MixerView.h
View File

@@ -83,7 +83,6 @@ public:
// move the channel to the left or right
void moveChannelLeft(int index);
void moveChannelLeft(int index, int focusIndex);
void moveChannelRight(int index);
void renameChannel(int index);