hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Remove Knob::setHtmlLabel (#7993)

Browse Source 
* Remove Knob::setHtmlLabel

Remove the unused method `Knob::setHtmlLabel` and its associated members.
This removes some unnecessary complexity from the code.

* Public label methods

Make `Knob::setLabel` public. Add `Knob::getLabel` for completeness.

* Delegate in KnobControl::setText

Make `KnobControl::setText` delegate to the `Knob` instance now that `Knob::setLabel` is public again.
This commit is contained in:
Michael Gregorius
2025-07-08 02:16:24 +02:00
committed by GitHub
parent a1da660741
commit 4c3f8191af
3 changed files with 16 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
include/Knob.h
View File

@@ -136,7 +136,8 @@ public:
Knob( const Knob& other ) = delete;
void setHtmlLabel( const QString &htmltxt );
const QString& getLabel() const;
void setLabel(const QString& txt);
void setTotalAngle( float angle );
@@ -167,8 +168,6 @@ public:
protected:
void setLabel(const QString& txt);
void paintEvent(QPaintEvent*) override;
void changeEvent(QEvent * ev) override;
@@ -216,8 +215,6 @@ private:
QString m_label;
bool m_fixedFontSizeLabelRendering = false;
bool m_isHtmlLabel;
QTextDocument* m_tdRenderer;
std::unique_ptr<QPixmap> m_knobPixmap;