From 54cc4cf1e9e65dba06d22f004bb33b43c09d029e Mon Sep 17 00:00:00 2001 From: Johannes Lorenz Date: Sun, 1 Oct 2023 16:51:27 +0200 Subject: [PATCH] AudioJack: Fix segfault for some bufsizes The segfault happens when you use buffersize 224: Then, in AudioJack.cpp, L424, `done` can be greater than `_nframes`. --- src/core/audio/AudioJack.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/audio/AudioJack.cpp b/src/core/audio/AudioJack.cpp index 83fa3c177..dc6bc2861 100644 --- a/src/core/audio/AudioJack.cpp +++ b/src/core/audio/AudioJack.cpp @@ -390,7 +390,7 @@ int AudioJack::processCallback( jack_nframes_t _nframes, void * _udata ) while( done < _nframes && m_stopped == false ) { jack_nframes_t todo = std::min( - _nframes, + _nframes-done, m_framesToDoInCurBuf - m_framesDoneInCurBuf); const float gain = audioEngine()->masterGain();