From 5566f85240051e7fc1b70ea0adf0c24b960464ac Mon Sep 17 00:00:00 2001 From: Hyunjin Song Date: Fri, 11 Nov 2022 11:49:29 +0900 Subject: [PATCH] Use range-based loops --- plugins/LadspaEffect/LadspaMatrixControlDialog.cpp | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/plugins/LadspaEffect/LadspaMatrixControlDialog.cpp b/plugins/LadspaEffect/LadspaMatrixControlDialog.cpp index 902eefb10..d34463e3b 100644 --- a/plugins/LadspaEffect/LadspaMatrixControlDialog.cpp +++ b/plugins/LadspaEffect/LadspaMatrixControlDialog.cpp @@ -78,10 +78,9 @@ LadspaMatrixControlDialog::LadspaMatrixControlDialog(LadspaControls * ladspaCont void LadspaMatrixControlDialog::updateEffectView(LadspaControls * ladspaControls) { - QList list = findChildren(); - for (QList::iterator it = list.begin(); it != list.end(); ++it) + for (auto child : findChildren()) { - delete *it; + delete child; } m_effectControls = ladspaControls; @@ -104,14 +103,9 @@ void LadspaMatrixControlDialog::updateEffectView(LadspaControls * ladspaControls gridLayout->addWidget(new QLabel("" + channelString.arg(QString::number(i + 1)) + "", widget), 0, currentChannelColumn, Qt::AlignHCenter); - control_list_t & controls = ladspaControls->m_controls[i]; - int currentRow = 1; - control_list_t::iterator end = controls.end(); - for (control_list_t::iterator it = controls.begin(); it != end; ++it) + for (auto ladspaControl : ladspaControls->m_controls[i]) { - LadspaControl * ladspaControl = *it; - if (i == 0) { // TODO Assumes that all processors are equal! Change to more general approach, e.g. map from name to row