From 62a8c68736008e83e1be99c32e9c0748c74ec582 Mon Sep 17 00:00:00 2001
From: Tres Finocchiaro <tres.finocchiaro@gmail.com>
Date: Sun, 30 Jul 2023 23:42:53 -0400
Subject: [PATCH] Fix apple install script for zyn interface (#6782)

* Fix apple install script for zyn interface
* Add codesigning support to prevent crash
---
 cmake/apple/install_apple.sh.in | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/cmake/apple/install_apple.sh.in b/cmake/apple/install_apple.sh.in
index df9300712..fc27d78b3 100644
--- a/cmake/apple/install_apple.sh.in
+++ b/cmake/apple/install_apple.sh.in
@@ -35,8 +35,6 @@ cd "$APP"
 find . -type f -print0 | xargs -0 chmod u+w
 
 lmmsbin="MacOS/@CMAKE_PROJECT_NAME@"
-zynlib="lib/lmms/libzynaddsubfx.so"
-zynfmk="Frameworks/libZynAddSubFxCore.dylib"
 zynbin="MacOS/RemoteZynAddSubFx"
 
 # Move lmms binary
@@ -44,15 +42,6 @@ mv "$APP/Contents/bin/@CMAKE_PROJECT_NAME@" "$APP/Contents/$lmmsbin"
 
 # Fix zyn linking
 mv "$APP/Contents/lib/lmms/RemoteZynAddSubFx" "$APP/Contents/$zynbin"
-mv "$APP/Contents/lib/lmms/libZynAddSubFxCore.dylib" "$APP/Contents/$zynfmk"
-
-install_name_tool -change @rpath/libZynAddSubFxCore.dylib \
-   @loader_path/../$zynfmk \
-  "$APP/Contents/$zynbin"
-
-install_name_tool -change @rpath/libZynAddSubFxCore.dylib \
-   @loader_path/../../$zynfmk \
-  "$APP/Contents/$zynlib"
   
 # Replace @rpath with @loader_path for Carla
 # See also plugins/CarlaBase/CMakeLists.txt
@@ -67,7 +56,6 @@ install_name_tool -change @rpath/libcarlabase.dylib \
 
 # Link lmms binary
 _executables="${_executables} -executable=$APP/Contents/$zynbin"
-_executables="${_executables} -executable=$APP/Contents/$zynfmk"
 
 # Build a list of shared objects in target/lib/lmms
 for file in "$APP/Contents/lib/lmms/"*.so; do
@@ -109,4 +97,8 @@ done
 
 # Cleanup
 rm -rf "$APP/Contents/bin"
+
+# Codesign
+codesign --force --deep --sign - "$APP"
+
 echo -e "\nFinished.\n\n"