From 63d03fa3a70ce538ecb8417a9c55d95ee17c5648 Mon Sep 17 00:00:00 2001 From: Johannes Lorenz Date: Sat, 21 Oct 2023 17:39:20 +0200 Subject: [PATCH] Fix Uninitialized Value Conditional Jump Introduced in #5970 , `CPULoadWidget::m_stepSize` is uninitialized, leading to valgrind warnings: ``` ==9429== Conditional jump or move depends on uninitialised value(s) ==9429== at 0x3715A9: int const& std::max(int const&, int const&) (stl_algobase.h:262) ==9429== by 0x59E3BB: lmms::gui::CPULoadWidget::stepSize() const (CPULoadWidget.h:59) ==9429== by 0x59DA2E: lmms::gui::CPULoadWidget::paintEvent(QPaintEvent*) (CPULoadWidget.cpp:78) ``` Even though `grep` shows: ``` data/themes/classic/style.css: qproperty-stepSize: 4; data/themes/default/style.css: qproperty-stepSize: 1; ``` It seems like the issue is caused by paint events occurring even before the style sheet has been applied. In order to fix this, and to be future proof with style sheets which do not set it, we initialize `CPULoadWidget::m_stepSize` to `1`. --- include/CPULoadWidget.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/CPULoadWidget.h b/include/CPULoadWidget.h index dfa5bac73..bed10b05e 100644 --- a/include/CPULoadWidget.h +++ b/include/CPULoadWidget.h @@ -68,7 +68,7 @@ private: QTimer m_updateTimer; - int m_stepSize; + int m_stepSize = 1; } ;