From 66c050d803d286dae5ce7a7cdbcca09001cdcf8a Mon Sep 17 00:00:00 2001
From: Paul Giblock <drfaygo@gmail.com>
Date: Mon, 2 Jun 2008 22:50:52 +0000
Subject: [PATCH] use default context menu for Fader.  Connection dialog
 improvements

git-svn-id: https://lmms.svn.sf.net/svnroot/lmms/trunk/lmms@1059 0778d3d1-df1d-0410-868b-ea421aaaa00d
---
 ChangeLog                                |  4 ++++
 src/gui/controller_connection_dialog.cpp | 10 +++++++---
 src/gui/widgets/fader.cpp                |  5 +----
 3 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1ac6ada49..bc62fe263 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -19,7 +19,11 @@
 	* src/core/midi/midi_controller.cpp:
 	name midiControllers after their channel/controller
 
+	* src/gui/widgets/fader.cpp:
+	Use default context menu
 
+	* src/gui/controller_connection_dialog.cpp:
+	don't choose the controller if the user didn't actually choose anything
 
 2008-06-02	Tobias Doerffel	<tobydox/at/users/dot/sourceforge/dot/net>
 
diff --git a/src/gui/controller_connection_dialog.cpp b/src/gui/controller_connection_dialog.cpp
index 0a7932ae2..d0ed828f4 100644
--- a/src/gui/controller_connection_dialog.cpp
+++ b/src/gui/controller_connection_dialog.cpp
@@ -260,12 +260,16 @@ void controllerConnectionDialog::selectController( void )
 {
 	if( m_midiGroupBox->model()->value() > 0 )
 	{
-		m_controller = m_midiController->copyToMidiController(
-				engine::getSong() );
+		if( m_midiControllerSpinBox->model()->value() > 0 )
+		{
+			m_controller = m_midiController->copyToMidiController(
+					engine::getSong() );
+		}
 	}
 	else 
 	{
-		if( m_userGroupBox->model()->value() > 0 )
+		if( m_userGroupBox->model()->value() > 0 && 
+				engine::getSong()->controllers().size() )
 		{
 			m_controller = engine::getSong()->controllers().at( 
 					m_userController->model()->value() );
diff --git a/src/gui/widgets/fader.cpp b/src/gui/widgets/fader.cpp
index c0b21ee71..38b944b86 100644
--- a/src/gui/widgets/fader.cpp
+++ b/src/gui/widgets/fader.cpp
@@ -89,10 +89,7 @@ void fader::contextMenuEvent( QContextMenuEvent * _ev )
 	if( !model()->nullTrack() )
 	{
 		captionMenu contextMenu( accessibleName() );
-		contextMenu.addAction( embed::getIconPixmap( "automation" ),
-					tr( "&Open in automation editor" ),
-					model()->getAutomationPattern(),
-					SLOT( openInAutomationEditor() ) );
+		addDefaultActions( &contextMenu );
 		contextMenu.exec( QCursor::pos() );
 		_ev->accept();
 	}