From 6be07b170de3b5d2456c7f9552b229b2d33df943 Mon Sep 17 00:00:00 2001
From: Michael Gregorius <michael.gregorius.git@arcor.de>
Date: Sun, 16 Jul 2023 16:03:24 +0200
Subject: [PATCH] Fixes for CodeFactor

Remove virtual keyword from methods that are marked as override.

Remove whitespaces that make CodeFactor unhappy. One of these fixes
includes moving the implementation of
LadspaMatrixControlDialog::isResizable into the cpp file.
---
 include/BarModelEditor.h                           | 6 +++---
 include/FloatModelEditorBase.h                     | 1 -
 plugins/LadspaEffect/LadspaMatrixControlDialog.cpp | 5 +++++
 plugins/LadspaEffect/LadspaMatrixControlDialog.h   | 2 +-
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/include/BarModelEditor.h b/include/BarModelEditor.h
index 6779f7c76..79a320a7d 100644
--- a/include/BarModelEditor.h
+++ b/include/BarModelEditor.h
@@ -47,9 +47,9 @@ public:
 	// Define how the widget will behave in a layout
 	QSizePolicy sizePolicy() const;
 
-	virtual QSize minimumSizeHint() const override;
+	QSize minimumSizeHint() const override;
 
-	virtual QSize sizeHint() const override;
+	QSize sizeHint() const override;
 
 	QBrush const & getBackgroundBrush() const;
 	void setBackgroundBrush(QBrush const & backgroundBrush);
@@ -61,7 +61,7 @@ public:
 	void setTextColor(QColor const & textColor);
 
 protected:
-	virtual void paintEvent(QPaintEvent *event) override;
+	void paintEvent(QPaintEvent *event) override;
 
 private:
 	QString const m_text;
diff --git a/include/FloatModelEditorBase.h b/include/FloatModelEditorBase.h
index 043885d52..840179b3d 100644
--- a/include/FloatModelEditorBase.h
+++ b/include/FloatModelEditorBase.h
@@ -52,7 +52,6 @@ class LMMS_EXPORT FloatModelEditorBase : public QWidget, public FloatModelView
 	void initUi( const QString & _name ); //!< to be called by ctors
 
 public:
-
 	enum class DirectionOfManipulation
 	{
 		Vertical,
diff --git a/plugins/LadspaEffect/LadspaMatrixControlDialog.cpp b/plugins/LadspaEffect/LadspaMatrixControlDialog.cpp
index 38a25fd45..eb86df941 100644
--- a/plugins/LadspaEffect/LadspaMatrixControlDialog.cpp
+++ b/plugins/LadspaEffect/LadspaMatrixControlDialog.cpp
@@ -79,6 +79,11 @@ LadspaMatrixControlDialog::LadspaMatrixControlDialog(LadspaControls * ladspaCont
 	}
 }
 
+bool LadspaMatrixControlDialog::isResizable() const
+{
+	return true;
+}
+
 bool LadspaMatrixControlDialog::needsLinkColumn() const
 {
 	LadspaControls * ladspaControls = getLadspaControls();
diff --git a/plugins/LadspaEffect/LadspaMatrixControlDialog.h b/plugins/LadspaEffect/LadspaMatrixControlDialog.h
index 8ef9428b8..4437e27fc 100644
--- a/plugins/LadspaEffect/LadspaMatrixControlDialog.h
+++ b/plugins/LadspaEffect/LadspaMatrixControlDialog.h
@@ -51,7 +51,7 @@ class LadspaMatrixControlDialog : public EffectControlDialog
 public:
 	LadspaMatrixControlDialog(LadspaControls* ctl);
 
-	bool isResizable() const override { return true; }
+	bool isResizable() const override;
 
 private slots:
 	void updateEffectView(LadspaControls* ctl);