Remove lots of useless/misplaced includes (#7999)

Follow-Up of 7db3fa94a1 .

This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):

```
include-what-you-use;
    -Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
    -Xiwyu;--keep=*/xmmintrin.h;
    -Xiwyu;--keep=*/lmmsconfig.h;
    -Xiwyu;--keep=*/weak_libjack.h;
    -Xiwyu;--keep=*/sys/*;
    -Xiwyu;--keep=*/debug.h;
    -Xiwyu;--keep=*/SDL/*;
    -Xiwyu;--keep=*/alsa/*;
    -Xiwyu;--keep=*/FL/x.h;
    -Xiwyu;--keep=*/MidiApple.h;
    -Xiwyu;--keep=*/MidiWinMM.h;
    -Xiwyu;--keep=*/AudioSoundIo.h;
    -Xiwyu;--keep=*/OpulenZ/adplug/*;
    -Xiwyu;--keep=QPainterPath;
    -Xiwyu;--keep=QtTest
```

FAQ:

* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.

* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
     that your compiler needs to recompile, or your IDE has to re-scan.

* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
     reduce output for those who want to use IWYU for new PRs.

Background:

This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.

However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.

src/common/RemotePluginBase.cpp

@@ -26,6 +26,7 @@
 
 #ifndef BUILD_REMOTE_PLUGIN_CLIENT
 #include <QCoreApplication>
+#include <QThread>
 #endif
 
 

src/common/SystemSemaphore.cpp

@@ -23,7 +23,7 @@
 
 #include "SystemSemaphore.h"
 
-#include <limits>
+#include <limits>  // IWYU pragma: keep
 #include <system_error>
 #include <type_traits>
 #include <utility>

src/core/AutomatableModel.cpp

@@ -24,6 +24,8 @@
 
 #include "AutomatableModel.h"
 
+#include <QRegularExpression>
+
 #include "lmms_math.h"
 
 #include "AudioEngine.h"
@@ -816,4 +818,4 @@ QString BoolModel::displayValue( const float val ) const
 }
 
 
-} // namespace lmms
+} // namespace lmms

src/core/AutomationClip.cpp

@@ -36,7 +36,6 @@
 #include "ProjectJournal.h"
 #include "Song.h"
 
-#include <cmath>
 
 namespace lmms
 {

src/core/Effect.cpp

@@ -32,7 +32,6 @@
 
 #include "ConfigManager.h"
 #include "SampleFrame.h"
-#include "lmms_math.h"
 
 namespace lmms
 {

src/core/InstrumentFunctions.cpp

@@ -22,7 +22,6 @@
  *
  */
 
-#include <QDomElement>
 
 #include "InstrumentFunctions.h"
 #include "AudioEngine.h"

src/core/MixHelpers.cpp

@@ -29,7 +29,6 @@
 #endif
 
 #include <cmath>
-#include <QtGlobal>
 
 #include "ValueBuffer.h"
 #include "SampleFrame.h"

src/core/PeakController.cpp

@@ -25,7 +25,6 @@
 
 #include "PeakController.h"
 
-#include <cmath>
 
 #include <QDomElement>
 #include <QMessageBox>

src/core/Plugin.cpp

@@ -24,7 +24,6 @@
 
 #include "Plugin.h"
 
-#include <QtGlobal>
 #include <QDomElement>
 #include <QLibrary>
 #include <QMessageBox>

src/core/RemotePlugin.cpp

@@ -35,6 +35,7 @@
 
 #include "AudioEngine.h"
 #include "Engine.h"
+#include "MidiEvent.h"
 #include "Song.h"
 
 #include <QCoreApplication>

src/core/SampleClip.cpp

@@ -28,11 +28,10 @@
 #include <QFileInfo>
 
 #include "PathUtil.h"
-#include "SampleBuffer.h"
 #include "SampleClipView.h"
 #include "SampleLoader.h"
 #include "SampleTrack.h"
-#include "TimeLineWidget.h"
+#include "Song.h"
 
 namespace lmms
 {

src/core/SampleDecoder.cpp

@@ -25,7 +25,6 @@
 #include "SampleDecoder.h"
 
 #include <QFile>
-#include <QFileInfo>
 #include <QString>
 #include <memory>
 #include <sndfile.h>

src/core/Song.cpp

@@ -54,7 +54,6 @@
 #include "ProjectNotes.h"
 #include "Scale.h"
 #include "SongEditor.h"
-#include "TimeLineWidget.h"
 #include "PeakController.h"
 
 

src/core/ThreadPool.cpp

@@ -24,8 +24,6 @@
 #include "ThreadPool.h"
 
 #include <cassert>
-#include <cstddef>
-#include <memory>
 
 namespace lmms {
 ThreadPool::ThreadPool(size_t numWorkers)

src/core/TimePos.cpp

@@ -25,7 +25,6 @@
 
 #include "TimePos.h"
 
-#include <cassert>
 #include "MeterModel.h"
 
 namespace lmms

src/core/Timeline.cpp

@@ -26,7 +26,6 @@
 #include <algorithm>
 #include <tuple>
 
-#include <QDomDocument>
 #include <QDomElement>
 
 namespace lmms {

src/core/VstSyncController.cpp

@@ -30,9 +30,7 @@
 #include <QDebug>
 
 #include "AudioEngine.h"
-#include "ConfigManager.h"
 #include "Engine.h"
-#include "RemotePlugin.h"
 
 
 namespace lmms

src/core/audio/AudioAlsa.cpp

@@ -30,7 +30,6 @@
 #include "endian_handling.h"
 #include "AudioEngine.h"
 #include "ConfigManager.h"
-#include "Engine.h"
 
 namespace lmms
 {

src/core/audio/AudioDevice.cpp

@@ -26,7 +26,6 @@
 
 #include "AudioDevice.h"
 #include "AudioEngine.h"
-#include "ConfigManager.h"
 
 namespace lmms
 {

src/core/audio/AudioFileFlac.cpp

@@ -22,10 +22,8 @@
  *
  */
 
-#include <QtGlobal>
 
 #include <cmath>
-#include <memory>
 
 #include "AudioFileFlac.h"
 #include "endian_handling.h"

src/core/audio/AudioFileOgg.cpp

@@ -32,7 +32,8 @@
 
 #include <vorbis/vorbisenc.h>
 
-#include "AudioEngine.h"
+#include "SampleFrame.h"
+#include "lmms_constants.h"
 
 namespace lmms
 {

src/core/audio/AudioJack.cpp

@@ -36,7 +36,6 @@
 
 #include "AudioEngine.h"
 #include "ConfigManager.h"
-#include "Engine.h"
 #include "GuiApplication.h"
 #include "MainWindow.h"
 #include "MidiJack.h"

src/core/audio/AudioOss.cpp

@@ -33,7 +33,6 @@
 #include "endian_handling.h"
 #include "LcdSpinBox.h"
 #include "AudioEngine.h"
-#include "Engine.h"
 
 #ifdef LMMS_HAVE_UNISTD_H
 #include <unistd.h>

src/core/audio/AudioPortAudio.cpp

@@ -51,7 +51,6 @@ void AudioPortAudioSetupUtil::updateChannels()
 
 #include <QFormLayout>
 
-#include "Engine.h"
 #include "ConfigManager.h"
 #include "ComboBox.h"
 #include "AudioEngine.h"

src/core/audio/AudioSdl.cpp

@@ -28,7 +28,6 @@
 #ifdef LMMS_HAVE_SDL
 
 #include <QFormLayout>
-#include <QLineEdit>
 #include <QComboBox>
 #include <SDL.h>
 

src/core/audio/AudioSndio.cpp

@@ -34,7 +34,6 @@
 #include "endian_handling.h"
 #include "LcdSpinBox.h"
 #include "AudioEngine.h"
-#include "Engine.h"
 
 #include "ConfigManager.h"
 

src/core/lv2/Lv2Proc.cpp

@@ -32,7 +32,6 @@
 #include <lv2/resize-port/resize-port.h>
 #include <lv2/worker/worker.h>
 #include <QDebug>
-#include <QDomDocument>
 #include <QtGlobal>
 
 #include "AudioEngine.h"

src/core/lv2/Lv2SubPluginFeatures.cpp

@@ -28,10 +28,8 @@
 
 #ifdef LMMS_HAVE_LV2
 
-#include <QDesktopServices>
 #include <QHBoxLayout>
 #include <QLabel>
-#include <QUrl>
 
 #include "Engine.h"
 #include "Lv2Basics.h"

src/core/lv2/Lv2Worker.cpp

@@ -25,11 +25,9 @@
 #include "Lv2Worker.h"
 
 #include <cassert>
-#include <QDebug>
 
 #ifdef LMMS_HAVE_LV2
 
-#include "Engine.h"
 
 
 namespace lmms

src/core/midi/MidiController.cpp

@@ -23,7 +23,6 @@
  *
  */
 
-#include <QDomElement>
 
 #include "AudioEngine.h"
 #include "MidiController.h"

src/gui/FileBrowser.cpp

@@ -27,19 +27,18 @@
 
 #include <PathUtil.h>
 #include <QApplication>
-#include <QDirIterator>
+#include <QCheckBox>
 #include <QHBoxLayout>
 #include <QLineEdit>
 #include <QMdiArea>
 #include <QMdiSubWindow>
 #include <QMenu>
 #include <QMessageBox>
-#include <QProcess>
+#include <QProgressBar>
 #include <QPushButton>
 #include <QShortcut>
 #include <QStringList>
 #include <cassert>
-#include <queue>
 
 #include "AudioEngine.h"
 #include "ConfigManager.h"

src/gui/GuiApplication.cpp

@@ -44,11 +44,11 @@
 #include <QDebug>
 #include <QDir>
 #include <QtGlobal>
+#include <QHBoxLayout>
 #include <QLabel>
 #include <QMessageBox>
 #include <QSplashScreen>
 #include <QSocketNotifier>
-#include <csignal>
 
 #ifdef LMMS_BUILD_WIN32
 #include <io.h>

src/gui/LfoControllerDialog.cpp

@@ -154,7 +154,7 @@ LfoControllerDialog::LfoControllerDialog( Controller * _model, QWidget * _parent
 	m_userWaveBtn->setToolTip(
 				tr( "User-defined shape.\nDouble click to pick a file." ) );
 	
-	m_waveBtnGrp = new automatableButtonGroup( this );
+	m_waveBtnGrp = new AutomatableButtonGroup( this );
 	m_waveBtnGrp->addButton( sin_wave_btn );
 	m_waveBtnGrp->addButton( triangle_wave_btn );
 	m_waveBtnGrp->addButton( saw_wave_btn );
@@ -182,7 +182,7 @@ LfoControllerDialog::LfoControllerDialog( Controller * _model, QWidget * _parent
 	d100->setInactiveGraphic(embed::getIconPixmap("lfo_d100_inactive"));
 	d100->setToolTip(tr("Divide modulation frequency by 100"));
 
-	m_multiplierBtnGrp = new automatableButtonGroup( this );
+	m_multiplierBtnGrp = new AutomatableButtonGroup( this );
 	m_multiplierBtnGrp->addButton( x1 );
 	m_multiplierBtnGrp->addButton( x100 );
 	m_multiplierBtnGrp->addButton( d100 );

src/gui/LmmsStyle.cpp

@@ -29,7 +29,7 @@
 #include <QFile>
 #include <QFileInfo>
 #include <QPainter>
-#include <QPainterPath>
+#include <QPainterPath>  // IWYU pragma: keep
 #include <QStyleFactory>
 #include <QStyleOption>
 

src/gui/MainWindow.cpp

@@ -61,14 +61,13 @@
 #include "ProjectNotes.h"
 #include "ProjectRenderer.h"
 #include "RecentProjectsMenu.h"
-#include "RemotePlugin.h"
+#include "RemotePluginBase.h"
 #include "SetupDialog.h"
 #include "SideBar.h"
 #include "SongEditor.h"
 #include "SubWindow.h"
 #include "TemplatesMenu.h"
 #include "TextFloat.h"
-#include "TimeLineWidget.h"
 #include "ToolButton.h"
 #include "ToolPlugin.h"
 #include "VersionedSaveDialog.h"

src/gui/MixerChannelView.cpp

@@ -28,19 +28,28 @@
 #include <QFont>
 #include <QGraphicsProxyWidget>
 #include <QGraphicsScene>
+#include <QGraphicsView>
+#include <QLineEdit>
 #include <QMenu>
 #include <QMessageBox>
 #include <QPainter>
-#include <cassert>
+#include <QStackedWidget>
+#include <QVBoxLayout>
 
+#include "AutomatableButton.h"
 #include "CaptionMenu.h"
 #include "ColorChooser.h"
 #include "ConfigManager.h"
+#include "EffectRackView.h"
+#include "Fader.h"
 #include "FontHelper.h"
 #include "GuiApplication.h"
+#include "Knob.h"
+#include "LcdWidget.h"
 #include "Mixer.h"
 #include "MixerView.h"
 #include "PeakIndicator.h"
+#include "SendButtonIndicator.h"
 #include "Song.h"
 
 namespace lmms::gui {

src/gui/MixerView.cpp

@@ -24,25 +24,32 @@
 
 #include "MixerView.h"
 
+#include <QHBoxLayout>
 #include <QLayout>
+#include <QLineEdit>
 #include <QPushButton>
 #include <QScrollArea>
 #include <QStyle>
 #include <QKeyEvent>
+#include <QStackedLayout>
+#include <QStackedWidget>
 
-#include "MixerChannelView.h"
-#include "Knob.h"
-#include "Mixer.h"
+#include "EffectRackView.h"
+#include "Engine.h"
+#include "Fader.h"
 #include "GuiApplication.h"
-#include "MainWindow.h"
-#include "AudioEngine.h"
+#include "Knob.h"
 #include "InstrumentTrack.h"
+#include "MainWindow.h"
+#include "Mixer.h"
+#include "MixerChannelView.h"
 #include "PatternStore.h"
 #include "SampleTrack.h"
 #include "SendButtonIndicator.h"
 #include "Song.h"
 #include "SubWindow.h"
 #include "TrackContainer.h" // For TrackContainer::TrackList typedef
+#include "embed.h"
 
 namespace lmms::gui
 {

src/gui/SampleLoader.cpp

@@ -33,7 +33,6 @@
 #include "GuiApplication.h"
 #include "PathUtil.h"
 #include "SampleDecoder.h"
-#include "Song.h"
 
 namespace lmms::gui {
 QString SampleLoader::openAudioFile(const QString& previousFile)

src/gui/SampleThumbnail.cpp

@@ -25,8 +25,10 @@
 
 #include "SampleThumbnail.h"
 
-#include <QDebug>
 #include <QFileInfo>
+#include <QPainter>
+
+#include "Sample.h"
 
 namespace {
 	constexpr auto MaxSampleThumbnailCacheSize = 32;

src/gui/SampleTrackWindow.cpp

@@ -31,6 +31,7 @@
 #include <QMenu>
 #include <QVBoxLayout>
 
+#include "AutomatableButton.h"
 #include "EffectRackView.h"
 #include "embed.h"
 #include "GuiApplication.h"

src/gui/SendButtonIndicator.cpp

@@ -1,6 +1,6 @@
 #include "SendButtonIndicator.h"
 
-#include "embed.h"
+#include "Engine.h"
 #include "Mixer.h"
 #include "MixerChannelView.h"
 #include "MixerView.h"

src/gui/SubWindow.cpp

@@ -34,7 +34,7 @@
 #include <QMoveEvent>
 #include <QPainter>
 #include <QPushButton>
-#include <QStyleOption>
+#include <QStyleOptionTitleBar>
 
 #include "embed.h"
 

src/gui/clips/AutomationClipView.cpp

@@ -23,12 +23,10 @@
  */
 #include "AutomationClipView.h"
 
-#include <set>
-
 #include <QApplication>
 #include <QMouseEvent>
 #include <QPainter>
-#include <QPainterPath>
+#include <QPainterPath>  // IWYU pragma: keep
 #include <QMenu>
 
 #include "AutomationEditor.h"

src/gui/clips/ClipView.cpp

@@ -34,20 +34,14 @@
 #include "AutomationClip.h"
 #include "Clipboard.h"
 #include "ColorChooser.h"
-#include "ComboBoxModel.h"
 #include "DataFile.h"
 #include "Engine.h"
 #include "embed.h"
 #include "GuiApplication.h"
-#include "InstrumentTrack.h"
-#include "InstrumentTrackView.h"
 #include "KeyboardShortcuts.h"
-#include "MidiClip.h"
 #include "MidiClipView.h"
-#include "Note.h"
 #include "PatternClip.h"
 #include "PatternStore.h"
-#include "SampleClip.h"
 #include "Song.h"
 #include "SongEditor.h"
 #include "StringPairDrag.h"

src/gui/clips/MidiClipView.cpp

@@ -27,12 +27,10 @@
 
 
 #include <algorithm>
-#include <cmath>
 #include <QApplication>
 #include <QInputDialog>
 #include <QMenu>
 #include <QPainter>
-#include <cmath>
 #include <set>
 
 #include "AutomationEditor.h"

src/gui/editors/AutomationEditor.cpp

@@ -32,7 +32,8 @@
 #include <QKeyEvent>
 #include <QLabel>
 #include <QPainter>
-#include <QPainterPath>
+#include <QPainterPath>  // IWYU pragma: keep
+#include <QPushButton>
 #include <QScrollBar>
 #include <QStyleOption>
 #include <QToolTip>
@@ -54,7 +55,6 @@
 #include "PatternStore.h"
 #include "PianoRoll.h"
 #include "ProjectJournal.h"
-#include "SampleBuffer.h"
 #include "StringPairDrag.h"
 #include "TextFloat.h"
 #include "TimeLineWidget.h"

src/gui/editors/PianoRoll.cpp

@@ -26,7 +26,7 @@
 
 #include "PianoRoll.h"
 
-#include <QtMath>
+#include <QtMath>  // IWYU pragma: keep
 #include <QApplication>
 #include <QCheckBox>
 #include <QGridLayout>

src/gui/editors/TimeLineWidget.cpp

@@ -24,9 +24,7 @@
 
 #include "TimeLineWidget.h"
 
-#include <cmath>
 
-#include <QDomElement>
 #include <QGuiApplication>
 #include <QMenu>
 #include <QMouseEvent>
@@ -36,7 +34,6 @@
 
 #include "ConfigManager.h"
 #include "embed.h"
-#include "GuiApplication.h"
 #include "KeyboardShortcuts.h"
 #include "NStateButton.h"
 #include "TextFloat.h"

src/gui/instrument/EnvelopeAndLfoView.cpp

@@ -27,8 +27,8 @@
 
 #include <string_view>
 
-#include <QBoxLayout>
 #include <QSizePolicy>
+#include <QVBoxLayout>
 
 #include "EnvelopeGraph.h"
 #include "LfoGraph.h"
@@ -149,7 +149,7 @@ EnvelopeAndLfoView::EnvelopeAndLfoView(QWidget * parent) :
 	typesLayout->addWidget(random_lfo_btn);
 	typesLayout->addWidget(m_userLfoBtn);
 
-	m_lfoWaveBtnGrp = new automatableButtonGroup(this);
+	m_lfoWaveBtnGrp = new AutomatableButtonGroup(this);
 	m_lfoWaveBtnGrp->addButton(sin_lfo_btn);
 	m_lfoWaveBtnGrp->addButton(triangle_lfo_btn);
 	m_lfoWaveBtnGrp->addButton(saw_lfo_btn);

src/gui/instrument/InstrumentMidiIOView.cpp

@@ -24,7 +24,6 @@
 
 #include <QToolButton>
 #include <QHBoxLayout>
-#include <QLabel>
 #include <QVBoxLayout>
 
 #include "InstrumentMidiIOView.h"

src/gui/instrument/InstrumentSoundShapingView.cpp

@@ -24,14 +24,16 @@
 
 #include "InstrumentSoundShapingView.h"
 
+#include <QHBoxLayout>
 #include <QLabel>
-#include <QBoxLayout>
+#include <QVBoxLayout>
 
 #include "EnvelopeAndLfoParameters.h"
 #include "EnvelopeAndLfoView.h"
 #include "ComboBox.h"
 #include "GroupBox.h"
 #include "FontHelper.h"
+#include "InstrumentSoundShaping.h"
 #include "Knob.h"
 #include "TabWidget.h"
 

src/gui/instrument/InstrumentTrackWindow.cpp

@@ -33,6 +33,7 @@
 #include <QPushButton>
 #include <QVBoxLayout>
 
+#include "AutomatableButton.h"
 #include "ComboBox.h"
 #include "ConfigManager.h"
 #include "DataFile.h"
@@ -59,6 +60,7 @@
 #include "MainWindow.h"
 #include "PianoView.h"
 #include "PluginFactory.h"
+#include "PluginView.h"
 #include "Song.h"
 #include "StringPairDrag.h"
 #include "SubWindow.h"

src/gui/instrument/InstrumentView.cpp

@@ -26,7 +26,6 @@
 
 #include "InstrumentView.h"
 #include "embed.h"
-#include "InstrumentTrack.h"
 #include "InstrumentTrackWindow.h"
 
 namespace lmms::gui

src/gui/instrument/PianoView.cpp

@@ -41,14 +41,13 @@
 #include <QCursor>
 #include <QKeyEvent>
 #include <QPainter>
-#include <QPainterPath>
+#include <QPainterPath>  // IWYU pragma: keep
 #include <QVBoxLayout>
 
 #include "AutomatableModelView.h"
 #include "PianoView.h"
 #include "Piano.h"
 #include "CaptionMenu.h"
-#include "embed.h"
 #include "Engine.h"
 #include "FontHelper.h"
 #include "InstrumentTrack.h"

src/gui/modals/EffectSelectDialog.cpp

@@ -32,10 +32,15 @@
 #include <QApplication>
 #include <QDialogButtonBox>
 #include <QHBoxLayout>
+#include <QHeaderView>
+#include <QItemSelectionModel>
+#include <QKeyEvent>
 #include <QLabel>
 #include <QLineEdit>
+#include <QPushButton>
 #include <QRegularExpression>
 #include <QScrollArea>
+#include <QTableView>
 #include <QVBoxLayout>
 
 

src/gui/modals/VersionedSaveDialog.cpp

@@ -23,11 +23,12 @@
  */
 
 
+#include <QGroupBox>
 #include <QLayout>
 #include <QLineEdit>
 #include <QMessageBox>
 #include <QPushButton>
-#include <QGroupBox>
+#include <QRegularExpression>
 
 #include "DeprecationHelper.h"
 #include "VersionedSaveDialog.h"

src/gui/tracks/InstrumentTrackView.cpp

@@ -27,25 +27,28 @@
 #include <QAction>
 #include <QApplication>
 #include <QDragEnterEvent>
+#include <QHBoxLayout>
 #include <QMdiArea>
 #include <QMdiSubWindow>
 #include <QMenu>
+#include <QSpacerItem>
+#include <QVBoxLayout>
 
 #include "AudioEngine.h"
 #include "ConfigManager.h"
 #include "Engine.h"
 #include "FadeButton.h"
-#include "FontHelper.h"
-#include "Knob.h"
-#include "MidiCCRackView.h"
-#include "Mixer.h"
-#include "MixerView.h"
 #include "GuiApplication.h"
 #include "Instrument.h"
 #include "InstrumentTrackWindow.h"
+#include "Knob.h"
 #include "MainWindow.h"
 #include "MidiClient.h"
+#include "MidiCCRackView.h"
 #include "MidiPortMenu.h"
+#include "Mixer.h"
+#include "MixerChannelLcdSpinBox.h"
+#include "MixerView.h"
 #include "TrackLabelButton.h"
 
 

src/gui/tracks/SampleTrackView.cpp

@@ -25,14 +25,17 @@
 #include "SampleTrackView.h"
 
 #include <QApplication>
+#include <QHBoxLayout>
 #include <QMenu>
+#include <QSpacerItem>
+#include <QVBoxLayout>
 
 #include "ConfigManager.h"
 #include "embed.h"
 #include "Engine.h"
 #include "FadeButton.h"
-#include "FontHelper.h"
 #include "Mixer.h"
+#include "MixerChannelLcdSpinBox.h"
 #include "MixerView.h"
 #include "GuiApplication.h"
 #include "Knob.h"

src/gui/tracks/TrackLabelButton.cpp

@@ -30,7 +30,6 @@
 
 #include "ConfigManager.h"
 #include "embed.h"
-#include "InstrumentTrackView.h"
 #include "Instrument.h"
 #include "InstrumentTrack.h"
 #include "RenameDialog.h"

src/gui/tracks/TrackOperationsWidget.cpp

@@ -24,14 +24,15 @@
 
 #include "TrackOperationsWidget.h"
 
-#include <QBoxLayout>
+#include <QCheckBox>
+#include <QHBoxLayout>
 #include <QMenu>
 #include <QMessageBox>
 #include <QMouseEvent>
 #include <QPainter>
 #include <QPushButton>
-#include <QCheckBox>
 
+#include "AutomatableButton.h"
 #include "AutomationClip.h"
 #include "AutomationTrackView.h"
 #include "ColorChooser.h"
@@ -41,7 +42,6 @@
 #include "Engine.h"
 #include "InstrumentTrackView.h"
 #include "KeyboardShortcuts.h"
-#include "PixmapButton.h"
 #include "Song.h"
 #include "StringPairDrag.h"
 #include "Track.h"

src/gui/tracks/TrackView.cpp

@@ -30,15 +30,14 @@
 #include <QMouseEvent>
 #include <QPainter>
 #include <QStyleOption>
-#include <QtGlobal>
 
 
 #include "AudioEngine.h"
+#include "AutomatableButton.h"
 #include "ConfigManager.h"
 #include "DataFile.h"
 #include "Engine.h"
 #include "FadeButton.h"
-#include "PixmapButton.h"
 #include "StringPairDrag.h"
 #include "Track.h"
 #include "TrackGrip.h"

src/gui/widgets/AutomatableButton.cpp

@@ -1,6 +1,6 @@
 /*
- * AutomatableButton.cpp - implementation of class automatableButton and
- *                          automatableButtonGroup
+ * AutomatableButton.cpp - implementation of class AutomatableButton and
+ *                         AutomatableButtonGroup
  *
  * Copyright (c) 2006-2011 Tobias Doerffel <tobydox/at/users.sourceforge.net>
  *
@@ -179,7 +179,7 @@ void AutomatableButton::toggle()
 
 
 
-automatableButtonGroup::automatableButtonGroup( QWidget * _parent,
+AutomatableButtonGroup::AutomatableButtonGroup( QWidget * _parent,
 						const QString & _name ) :
 	QWidget( _parent ),
 	IntModelView( new IntModel( 0, 0, 0, nullptr, _name, true ), this )
@@ -191,7 +191,7 @@ automatableButtonGroup::automatableButtonGroup( QWidget * _parent,
 
 
 
-automatableButtonGroup::~automatableButtonGroup()
+AutomatableButtonGroup::~AutomatableButtonGroup()
 {
 	for (const auto& button : m_buttons)
 	{
@@ -202,7 +202,7 @@ automatableButtonGroup::~automatableButtonGroup()
 
 
 
-void automatableButtonGroup::addButton( AutomatableButton * _btn )
+void AutomatableButtonGroup::addButton( AutomatableButton * _btn )
 {
 	_btn->m_group = this;
 	_btn->setCheckable( true );
@@ -219,7 +219,7 @@ void automatableButtonGroup::addButton( AutomatableButton * _btn )
 
 
 
-void automatableButtonGroup::removeButton( AutomatableButton * _btn )
+void AutomatableButtonGroup::removeButton( AutomatableButton * _btn )
 {
 	m_buttons.erase( std::find( m_buttons.begin(), m_buttons.end(), _btn ) );
 	_btn->m_group = nullptr;
@@ -228,7 +228,7 @@ void automatableButtonGroup::removeButton( AutomatableButton * _btn )
 
 
 
-void automatableButtonGroup::activateButton( AutomatableButton * _btn )
+void AutomatableButtonGroup::activateButton( AutomatableButton * _btn )
 {
 	if( _btn != m_buttons[model()->value()] &&
 					m_buttons.indexOf( _btn ) != -1 )
@@ -244,7 +244,7 @@ void automatableButtonGroup::activateButton( AutomatableButton * _btn )
 
 
 
-void automatableButtonGroup::modelChanged()
+void AutomatableButtonGroup::modelChanged()
 {
 	connect( model(), SIGNAL(dataChanged()),
 			this, SLOT(updateButtons()));
@@ -255,7 +255,7 @@ void automatableButtonGroup::modelChanged()
 
 
 
-void automatableButtonGroup::updateButtons()
+void AutomatableButtonGroup::updateButtons()
 {
 	model()->setRange( 0, m_buttons.size() - 1 );
 	int i = 0;

src/gui/widgets/BarModelEditor.cpp

@@ -1,7 +1,6 @@
 #include <BarModelEditor.h>
 
 #include <QPainter>
-#include <QStyle>
 
 
 namespace lmms::gui

src/gui/widgets/Fader.cpp

@@ -49,10 +49,9 @@
 #include <QInputDialog>
 #include <QMouseEvent>
 #include <QPainter>
-#include <QPainterPath>
+#include <QPainterPath>  // IWYU pragma: keep
 
 #include "lmms_math.h"
-#include "embed.h"
 #include "CaptionMenu.h"
 #include "ConfigManager.h"
 #include "KeyboardShortcuts.h"

src/gui/widgets/Graph.cpp

@@ -28,7 +28,6 @@
 #include "Graph.h"
 #include "SampleLoader.h"
 #include "StringPairDrag.h"
-#include "SampleBuffer.h"
 #include "Oscillator.h"
 
 namespace lmms

src/gui/widgets/Knob.cpp

@@ -27,7 +27,6 @@
 #include <QPainter>
 #include <numbers>
 
-#include "lmms_math.h"
 #include "DeprecationHelper.h"
 #include "embed.h"
 #include "FontHelper.h"

src/gui/widgets/PeakIndicator.cpp

@@ -26,7 +26,6 @@
 
 #include "lmms_math.h"
 
-#include <QBoxLayout>
 #include <QMouseEvent>
 
 

src/gui/widgets/SimpleTextFloat.cpp

@@ -25,7 +25,6 @@
 #include "SimpleTextFloat.h"
 
 #include <QTimer>
-#include <QStyleOption>
 #include <QHBoxLayout>
 #include <QLabel>
 

src/gui/widgets/TextFloat.cpp

@@ -25,8 +25,6 @@
 #include "TextFloat.h"
 
 #include <QTimer>
-#include <QPainter>
-#include <QStyleOption>
 #include <QHBoxLayout>
 #include <QVBoxLayout>
 #include <QLabel>