[Code Cleanup] Cleaned up some header files and move a bit of debugging logic to cmake (#7677)

* Renamed lmms_basics.h to LmmsTypes.h and scoped it down for that purpose.

* Shifted the LMMS_STRINGIFY macro to it's own header.

* Removed the debug.h header file and use cmake to handle the macro logic.

* Remove some unused headers and include directives

plugins/AudioFileProcessor/AudioFileProcessor.cpp

@@ -30,7 +30,7 @@
 #include "SampleLoader.h"
 #include "Song.h"
 
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 #include "plugin_export.h"
 
 #include <QDomElement>

plugins/AudioFileProcessor/AudioFileProcessor.h

@@ -32,7 +32,7 @@
 
 #include "Instrument.h"
 #include "Sample.h"
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 
 namespace lmms

plugins/Delay/StereoDelay.cpp

@@ -24,7 +24,7 @@
 
 #include "StereoDelay.h"
 
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 #include "SampleFrame.h"
 
 namespace lmms

plugins/Delay/StereoDelay.h

@@ -25,7 +25,7 @@
 #ifndef STEREODELAY_H
 #define STEREODELAY_H
 
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 
 namespace lmms

plugins/Eq/EqSpectrumView.h

@@ -27,7 +27,7 @@
 #include <QWidget>
 
 #include "fft_helpers.h"
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 namespace lmms
 {

plugins/Flanger/MonoDelay.h

@@ -25,7 +25,7 @@
 #ifndef MONODELAY_H
 #define MONODELAY_H
 
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 namespace lmms
 {

plugins/LadspaEffect/LadspaMatrixControlDialog.h

@@ -28,7 +28,7 @@
 
 #include "EffectControlDialog.h"
 
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 
 class QGridLayout;

plugins/MidiImport/MidiImport.cpp

@@ -43,7 +43,6 @@
 #include "GuiApplication.h"
 #include "MainWindow.h"
 #include "TimePos.h"
-#include "debug.h"
 #include "Song.h"
 
 #include "plugin_export.h"

plugins/MultitapEcho/MultitapEcho.cpp

@@ -25,7 +25,7 @@
 
 #include "MultitapEcho.h"
 #include "embed.h"
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 #include "lmms_math.h"
 #include "plugin_export.h"
 

plugins/OpulenZ/OpulenZ.cpp

@@ -51,7 +51,6 @@
 #include <mididata.h>
 
 #include "embed.h"
-#include "debug.h"
 
 #include "Knob.h"
 #include "PixmapButton.h"

plugins/SlicerT/SlicerT.h

@@ -36,7 +36,7 @@
 #include "Sample.h"
 #include "SampleBuffer.h"
 #include "SlicerTView.h"
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 namespace lmms {
 

plugins/SpectrumAnalyzer/Analyzer.cpp

@@ -33,7 +33,7 @@
 #endif
 
 #include "embed.h"
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 #include "plugin_export.h"
 
 namespace lmms

plugins/SpectrumAnalyzer/SaProcessor.cpp

@@ -27,11 +27,9 @@
 
 #include <algorithm>
 #include "lmms_math.h"
-#ifdef SA_DEBUG
-	#include <chrono>
-#endif
 #include <cmath>
 #ifdef SA_DEBUG
+	#include <chrono>
 	#include <iomanip>
 	#include <iostream>
 #endif

plugins/SpectrumAnalyzer/SaProcessor.h

@@ -33,7 +33,7 @@
 #include <QRgb>
 #include <vector>
 
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 
 namespace lmms

plugins/TripleOscillator/TripleOscillator.cpp

@@ -29,7 +29,6 @@
 #include "TripleOscillator.h"
 #include "AudioEngine.h"
 #include "AutomatableButton.h"
-#include "debug.h"
 #include "Engine.h"
 #include "InstrumentTrack.h"
 #include "Knob.h"

plugins/Vibed/VibratingString.cpp

@@ -26,7 +26,7 @@
 #include "interpolation.h"
 #include "AudioEngine.h"
 #include "Engine.h"
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 #include <algorithm>
 #include <cstdlib>

plugins/Vibed/VibratingString.h

@@ -28,7 +28,7 @@
 #include <memory>
 #include <cstdlib>
 
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 namespace lmms
 {

plugins/VstBase/RemoteVstPlugin.cpp

@@ -41,10 +41,6 @@
 
 #ifdef LMMS_BUILD_LINUX
 
-#ifndef NOMINMAX
-#define NOMINMAX
-#endif
-
 #ifndef O_BINARY
 #define O_BINARY 0
 #endif
@@ -114,7 +110,7 @@ struct ERect
 #endif
 
 
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 #include "Midi.h"
 #include "communication.h"
 #include "IoHelper.h"

plugins/VstBase/vst_base.cpp

@@ -24,6 +24,7 @@
  */
 
 
+#include "LmmsCommonMacros.h"
 #include "Plugin.h"
 #include "vstbase_export.h"