[Code Cleanup] Cleaned up some header files and move a bit of debugging logic to cmake (#7677)

* Renamed lmms_basics.h to LmmsTypes.h and scoped it down for that purpose.

* Shifted the LMMS_STRINGIFY macro to it's own header.

* Removed the debug.h header file and use cmake to handle the macro logic.

* Remove some unused headers and include directives

src/core/AudioEngine.cpp

@@ -36,7 +36,6 @@
 #include "EnvelopeAndLfoParameters.h"
 #include "NotePlayHandle.h"
 #include "ConfigManager.h"
-#include "SamplePlayHandle.h"
 
 // platform-specific audio-interface-classes
 #include "AudioAlsa.h"

src/core/BufferManager.cpp

@@ -28,8 +28,6 @@
 
 #include "SampleFrame.h"
 
-#include <cstring>
-
 
 namespace lmms
 {

src/core/FileSearch.cpp

@@ -26,8 +26,6 @@
 
 #include <atomic>
 #include <chrono>
-#include <lmmsconfig.h>
-
 #include <thread>
 
 namespace lmms {

src/core/Instrument.cpp

@@ -29,7 +29,7 @@
 
 #include "DummyInstrument.h"
 #include "InstrumentTrack.h"
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 namespace lmms
 {

src/core/LadspaManager.cpp

@@ -36,6 +36,7 @@
 #include "ConfigManager.h"
 #include "LadspaManager.h"
 #include "PluginFactory.h"
+#include "lmms_constants.h"
 
 
 namespace lmms

src/core/LfoController.cpp

@@ -29,6 +29,7 @@
 #include <QFileInfo>
 
 #include "AudioEngine.h"
+#include "Oscillator.h"
 #include "PathUtil.h"
 #include "SampleLoader.h"
 #include "Song.h"

src/core/Mixer.cpp

@@ -26,7 +26,6 @@
 
 #include "AudioEngine.h"
 #include "AudioEngineWorkerThread.h"
-#include "BufferManager.h"
 #include "Mixer.h"
 #include "MixHelpers.h"
 #include "Song.h"

src/core/Oscillator.cpp

@@ -31,7 +31,6 @@
 #endif
 #include <numbers>
 
-#include "BufferManager.h"
 #include "Engine.h"
 #include "AudioEngine.h"
 #include "AutomatableModel.h"

src/core/RemotePlugin.cpp

@@ -33,7 +33,6 @@
 #include <windows.h>
 #endif
 
-#include "BufferManager.h"
 #include "AudioEngine.h"
 #include "Engine.h"
 #include "Song.h"

src/core/SampleBuffer.cpp

@@ -27,7 +27,6 @@
 
 #include "PathUtil.h"
 #include "SampleDecoder.h"
-#include "lmms_basics.h"
 
 namespace lmms {
 

src/core/SampleDecoder.cpp

@@ -37,7 +37,7 @@
 #include "AudioEngine.h"
 #include "DrumSynth.h"
 #include "Engine.h"
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 namespace lmms {
 

src/core/SampleRecordHandle.cpp

@@ -29,7 +29,6 @@
 #include "PatternTrack.h"
 #include "SampleBuffer.h"
 #include "SampleClip.h"
-#include "debug.h"
 
 
 namespace lmms

src/core/audio/AudioDevice.cpp

@@ -27,7 +27,6 @@
 #include "AudioDevice.h"
 #include "AudioEngine.h"
 #include "ConfigManager.h"
-#include "debug.h"
 
 namespace lmms
 {

src/core/audio/AudioSampleRecorder.cpp

@@ -26,7 +26,6 @@
 
 #include "AudioSampleRecorder.h"
 #include "SampleBuffer.h"
-#include "debug.h"
 
 
 namespace lmms

src/core/audio/AudioSdl.cpp

@@ -23,7 +23,7 @@
  */
 
 #include "AudioSdl.h"
-#include "lmms_basics.h"
+#include "LmmsTypes.h"
 
 #ifdef LMMS_HAVE_SDL
 

src/core/audio/AudioSoundIo.cpp

@@ -30,7 +30,6 @@
 #include <QLineEdit>
 
 #include "Engine.h"
-#include "debug.h"
 #include "ConfigManager.h"
 #include "ComboBox.h"
 #include "AudioEngine.h"

src/core/lv2/Lv2ControlBase.cpp

@@ -31,6 +31,7 @@
 #include <QtGlobal>
 
 #include "Engine.h"
+#include "lmms_constants.h"
 #include "Lv2Manager.h"
 #include "Lv2Proc.h"
 

src/gui/AudioAlsaSetupWidget.cpp

@@ -31,6 +31,7 @@
 
 #include "ConfigManager.h"
 #include "LcdSpinBox.h"
+#include "lmms_constants.h"
 
 namespace lmms::gui
 {

src/gui/MixerView.cpp

@@ -22,6 +22,7 @@
  *
  */
 
+#include "MixerView.h"
 
 #include <QLayout>
 #include <QPushButton>
@@ -29,10 +30,7 @@
 #include <QStyle>
 #include <QKeyEvent>
 
-#include "lmms_math.h"
-
 #include "MixerChannelView.h"
-#include "MixerView.h"
 #include "Knob.h"
 #include "Mixer.h"
 #include "GuiApplication.h"

src/gui/editors/AutomationEditor.cpp

@@ -58,7 +58,6 @@
 #include "StringPairDrag.h"
 #include "TextFloat.h"
 #include "TimeLineWidget.h"
-#include "debug.h"
 #include "embed.h"
 #include "FontHelper.h"
 

src/gui/editors/PianoRoll.cpp

@@ -50,7 +50,6 @@
 #include "ComboBox.h"
 #include "ConfigManager.h"
 #include "DataFile.h"
-#include "debug.h"
 #include "DeprecationHelper.h"
 #include "DetuningHelper.h"
 #include "embed.h"

src/gui/instrument/EnvelopeGraph.cpp

@@ -30,7 +30,6 @@
 #include <QMenu>
 
 #include "EnvelopeAndLfoParameters.h"
-#include "lmms_math.h"
 #include "ColorHelper.h"
 
 #include <cmath>

src/gui/modals/SetupDialog.cpp

@@ -33,7 +33,6 @@
 #include <QScrollArea>
 
 #include "AudioEngine.h"
-#include "debug.h"
 #include "embed.h"
 #include "Engine.h"
 #include "FileDialog.h"

src/gui/widgets/Oscilloscope.cpp

@@ -34,7 +34,6 @@
 #include "Engine.h"
 #include "Song.h"
 #include "embed.h"
-#include "BufferManager.h"
 
 namespace lmms::gui
 {