From 737fcd3e55827f19fb7bda1813a80a9c0ff55920 Mon Sep 17 00:00:00 2001
From: Johannes Lorenz <j.git@lorenz-ho.me>
Date: Sat, 18 Apr 2020 10:08:21 +0200
Subject: [PATCH] JackMidi: Remove confusing warning at shutdown

Warning is:

```
jack_port_unregister called with an incorrect port 0
Failed to unregister jack midi output
```
---
 src/core/midi/MidiJack.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/core/midi/MidiJack.cpp b/src/core/midi/MidiJack.cpp
index f71ef4a4c..bd1e65111 100644
--- a/src/core/midi/MidiJack.cpp
+++ b/src/core/midi/MidiJack.cpp
@@ -95,6 +95,8 @@ MidiJack::MidiJack() :
 		/* jack midi out not implemented
 		   JackMidiWrite and sendByte needs to be functional
 		   before enabling this
+		   If you enable this, also enable the
+		   corresponding jack_port_unregister line below
 		m_output_port = jack_port_register(
 				jackClient(), "MIDI out", JACK_DEFAULT_MIDI_TYPE,
 				JackPortIsOutput, 0);
@@ -123,9 +125,11 @@ MidiJack::~MidiJack()
 			printf("Failed to unregister jack midi input\n");
 		}
 
+		/* Unused yet, see the corresponding jack_port_register call
 		if( jack_port_unregister( jackClient(), m_output_port) != 0){
 			printf("Failed to unregister jack midi output\n");
 		}
+		*/
 
 		if(m_jackClient)
 		{