clang-tidy: Apply modernize-redundant-void-arg everywhere (#6446)

plugins/AudioFileProcessor/AudioFileProcessor.cpp

@@ -289,7 +289,7 @@ void AudioFileProcessor::loadFile( const QString & _file )
 
 
 
-QString AudioFileProcessor::nodeName( void ) const
+QString AudioFileProcessor::nodeName() const
 {
 	return audiofileprocessor_plugin_descriptor.name;
 }
@@ -339,7 +339,7 @@ void AudioFileProcessor::setAudioFile( const QString & _audio_file,
 
 
 
-void AudioFileProcessor::reverseModelChanged( void )
+void AudioFileProcessor::reverseModelChanged()
 {
 	m_sampleBuffer.setReversed( m_reverseModel.value() );
 	m_nextPlayStartPoint = m_sampleBuffer.startFrame();
@@ -349,7 +349,7 @@ void AudioFileProcessor::reverseModelChanged( void )
 
 
 
-void AudioFileProcessor::ampModelChanged( void )
+void AudioFileProcessor::ampModelChanged()
 {
 	m_sampleBuffer.setAmplification( m_ampModel.value() / 100.0f );
 }
@@ -362,7 +362,7 @@ void AudioFileProcessor::stutterModelChanged()
 }
 
 
-void AudioFileProcessor::startPointChanged( void )
+void AudioFileProcessor::startPointChanged()
 {
 	// check if start is over end and swap values if so
 	if( m_startPointModel.value() > m_endPointModel.value() )
@@ -394,14 +394,14 @@ void AudioFileProcessor::startPointChanged( void )
 
 }
 
-void AudioFileProcessor::endPointChanged( void )
+void AudioFileProcessor::endPointChanged()
 {
 	// same as start, for now
 	startPointChanged();
 
 }
 
-void AudioFileProcessor::loopPointChanged( void )
+void AudioFileProcessor::loopPointChanged()
 {
 
 	// check that loop point is between start-end points and not overlapping with endpoint
@@ -424,7 +424,7 @@ void AudioFileProcessor::loopPointChanged( void )
 	pointChanged();
 }
 
-void AudioFileProcessor::pointChanged( void )
+void AudioFileProcessor::pointChanged()
 {
 	const f_cnt_t f_start = static_cast<f_cnt_t>( m_startPointModel.value() *	( m_sampleBuffer.frames()-1 ) );
 	const f_cnt_t f_end = static_cast<f_cnt_t>( m_endPointModel.value() * ( m_sampleBuffer.frames()-1 ) );
@@ -677,7 +677,7 @@ void AudioFileProcessorView::paintEvent( QPaintEvent * )
 
 
 
-void AudioFileProcessorView::sampleUpdated( void )
+void AudioFileProcessorView::sampleUpdated()
 {
 	m_waveView->updateSampleRange();
 	m_waveView->update();
@@ -688,7 +688,7 @@ void AudioFileProcessorView::sampleUpdated( void )
 
 
 
-void AudioFileProcessorView::openAudioFile( void )
+void AudioFileProcessorView::openAudioFile()
 {
 	QString af = castModel<AudioFileProcessor>()->m_sampleBuffer.
 							openAudioFile();
@@ -703,7 +703,7 @@ void AudioFileProcessorView::openAudioFile( void )
 
 
 
-void AudioFileProcessorView::modelChanged( void )
+void AudioFileProcessorView::modelChanged()
 {
 	AudioFileProcessor * a = castModel<AudioFileProcessor>();
 	connect( &a->m_sampleBuffer, SIGNAL( sampleUpdated() ),

plugins/BitInvader/BitInvader.cpp

@@ -161,8 +161,8 @@ BitInvader::BitInvader( InstrumentTrack * _instrument_track ) :
 	m_graph.setWaveToSine();
 	lengthChanged();
 
-	connect( &m_sampleLength, SIGNAL( dataChanged( ) ),
-			this, SLOT( lengthChanged( ) ), Qt::DirectConnection );
+	connect( &m_sampleLength, SIGNAL( dataChanged() ),
+			this, SLOT( lengthChanged() ), Qt::DirectConnection );
 
 	connect( &m_graph, SIGNAL( samplesChanged( int, int ) ),
 			this, SLOT( samplesChanged( int, int ) ) );

plugins/BitInvader/BitInvader.h

@@ -139,7 +139,7 @@ protected slots:
 	void noiseWaveClicked();
 	void usrWaveClicked();
 	
-	void smoothClicked( void  );
+	void smoothClicked(  );
 
 private:
 	void modelChanged() override;

plugins/Eq/EqSpectrumView.cpp

@@ -193,7 +193,7 @@ EqSpectrumView::EqSpectrumView(EqAnalyser *b, QWidget *_parent) :
 	setAttribute( Qt::WA_TranslucentBackground, true );
 	m_skipBands = MAX_BANDS * 0.5;
 	float totalLength = log10( 20000 );
-	m_pixelsPerUnitWidth = width( ) / totalLength ;
+	m_pixelsPerUnitWidth = width() / totalLength ;
 	m_scale = 1.5;
 	m_color = QColor( 255, 255, 255, 255 );
 	for ( int i = 0 ; i < MAX_BANDS ; i++ )

plugins/Lb302/Lb302.cpp

@@ -293,26 +293,26 @@ Lb302Synth::Lb302Synth( InstrumentTrack * _instrumentTrack ) :
 	vca_mode(never_played)
 {
 
-	connect( Engine::audioEngine(), SIGNAL( sampleRateChanged( ) ),
-	         this, SLOT ( filterChanged( ) ) );
+	connect( Engine::audioEngine(), SIGNAL( sampleRateChanged() ),
+	         this, SLOT ( filterChanged() ) );
 
-	connect( &vcf_cut_knob, SIGNAL( dataChanged( ) ),
-	         this, SLOT ( filterChanged( ) ) );
+	connect( &vcf_cut_knob, SIGNAL( dataChanged() ),
+	         this, SLOT ( filterChanged() ) );
 
-	connect( &vcf_res_knob, SIGNAL( dataChanged( ) ),
-	         this, SLOT ( filterChanged( ) ) );
+	connect( &vcf_res_knob, SIGNAL( dataChanged() ),
+	         this, SLOT ( filterChanged() ) );
 
-	connect( &vcf_mod_knob, SIGNAL( dataChanged( ) ),
-	         this, SLOT ( filterChanged( ) ) );
+	connect( &vcf_mod_knob, SIGNAL( dataChanged() ),
+	         this, SLOT ( filterChanged() ) );
 
-	connect( &vcf_dec_knob, SIGNAL( dataChanged( ) ),
-	         this, SLOT ( filterChanged( ) ) );
+	connect( &vcf_dec_knob, SIGNAL( dataChanged() ),
+	         this, SLOT ( filterChanged() ) );
 
-	connect( &db24Toggle, SIGNAL( dataChanged( ) ),
-	         this, SLOT ( db24Toggled( ) ) );
+	connect( &db24Toggle, SIGNAL( dataChanged() ),
+	         this, SLOT ( db24Toggled() ) );
 
-	connect( &dist_knob, SIGNAL( dataChanged( ) ),
-	         this, SLOT ( filterChanged( )));
+	connect( &dist_knob, SIGNAL( dataChanged() ),
+	         this, SLOT ( filterChanged()));
 
 
 	// SYNTH

plugins/Lv2Instrument/Lv2Instrument.cpp

@@ -251,7 +251,7 @@ void Lv2InsView::dragEnterEvent(QDragEnterEvent *_dee)
 	// For mimeType() and MimeType enum class
 	using namespace Clipboard;
 
-	void (QDragEnterEvent::*reaction)(void) = &QDragEnterEvent::ignore;
+	void (QDragEnterEvent::*reaction)() = &QDragEnterEvent::ignore;
 
 	if (_dee->mimeData()->hasFormat( mimeType( MimeType::StringPair )))
 	{

plugins/MidiImport/MidiImport.h

@@ -56,7 +56,7 @@ private:
 	bool readRIFF( TrackContainer* tc );
 	bool readTrack( int _track_end, QString & _track_name );
 
-	void error( void );
+	void error();
 
 
 	inline int readInt( int _bytes )

plugins/Patman/Patman.cpp

@@ -125,7 +125,7 @@ void PatmanInstrument::loadFile( const QString & _file )
 
 
 
-QString PatmanInstrument::nodeName( void ) const
+QString PatmanInstrument::nodeName() const
 {
 	return( patman_plugin_descriptor.name );
 }
@@ -380,7 +380,7 @@ PatmanInstrument::LoadErrors PatmanInstrument::loadPatch(
 
 
 
-void PatmanInstrument::unloadCurrentPatch( void )
+void PatmanInstrument::unloadCurrentPatch()
 {
 	while( !m_patchSamples.empty() )
 	{
@@ -502,7 +502,7 @@ PatmanView::~PatmanView()
 
 
 
-void PatmanView::openFile( void )
+void PatmanView::openFile()
 {
 	FileDialog ofd( nullptr, tr( "Open patch file" ) );
 	ofd.setFileMode( FileDialog::ExistingFiles );
@@ -554,7 +554,7 @@ void PatmanView::openFile( void )
 
 
 
-void PatmanView::updateFilename( void )
+void PatmanView::updateFilename()
 {
  	m_displayFilename = "";
 	int idx = m_pi->m_patchFile.length();
@@ -638,7 +638,7 @@ void PatmanView::paintEvent( QPaintEvent * )
 
 
 
-void PatmanView::modelChanged( void )
+void PatmanView::modelChanged()
 {
 	m_pi = castModel<PatmanInstrument>();
 	m_loopButton->setModel( &m_pi->m_loopedModel );

plugins/Patman/Patman.h

@@ -69,9 +69,9 @@ public:
 
 	void loadFile( const QString & _file ) override;
 
-	QString nodeName( void ) const override;
+	QString nodeName() const override;
 
-	f_cnt_t desiredReleaseFrames( void ) const override
+	f_cnt_t desiredReleaseFrames() const override
 	{
 		return( 128 );
 	}
@@ -109,7 +109,7 @@ private:
 	} ;
 
 	LoadErrors loadPatch( const QString & _filename );
-	void unloadCurrentPatch( void );
+	void unloadCurrentPatch();
 
 	void selectSample( NotePlayHandle * _n );
 
@@ -117,7 +117,7 @@ private:
 	friend class gui::PatmanView;
 
 signals:
-	void fileChanged( void );
+	void fileChanged();
 
 } ;
 
@@ -135,8 +135,8 @@ public:
 
 
 public slots:
-	void openFile( void );
-	void updateFilename( void );
+	void openFile();
+	void updateFilename();
 
 
 protected:
@@ -146,7 +146,7 @@ protected:
 
 
 private:
-	void modelChanged( void ) override;
+	void modelChanged() override;
 
 	PatmanInstrument * m_pi;
 	QString m_displayFilename;

plugins/Sf2Player/PatchesDialog.cpp

@@ -264,7 +264,7 @@ void PatchesDialog::accept()
 
 
 // Reject settings (Cancel button slot).
-void PatchesDialog::reject (void)
+void PatchesDialog::reject ()
 {
 	// Reset selection to initial selection, if applicable...
 	if (m_dirty > 0)
@@ -306,7 +306,7 @@ QTreeWidgetItem *PatchesDialog::findProgItem ( int iProg )
 
 
 // Bank change slot.
-void PatchesDialog::bankChanged (void)
+void PatchesDialog::bankChanged ()
 {
 	if (m_pSynth == nullptr)
 		return;

plugins/Vestige/Vestige.cpp

@@ -741,7 +741,7 @@ void VestigeInstrumentView::openPreset()
 {
 
 	if ( m_vi->m_plugin != nullptr ) {
-		m_vi->m_plugin->openPreset( );
+		m_vi->m_plugin->openPreset();
     		bool converted;
     		QString str = m_vi->m_plugin->currentProgramName().section("/", 0, 0);
      		if (str != "")
@@ -759,7 +759,7 @@ void VestigeInstrumentView::savePreset()
 
 	if ( m_vi->m_plugin != nullptr )
 	{
-		m_vi->m_plugin->savePreset( );
+		m_vi->m_plugin->savePreset();
 /*    		bool converted;
     		QString str = m_vi->m_plugin->presetString().section("/", 0, 0);
      		if (str != "")

plugins/Vestige/Vestige.h

@@ -66,7 +66,7 @@ public:
 	virtual void saveSettings( QDomDocument & _doc, QDomElement & _parent );
 	virtual void loadSettings( const QDomElement & _this );
 
-	virtual QString nodeName( void ) const;
+	virtual QString nodeName() const;
 
 	virtual void loadFile( const QString & _file );
 
@@ -85,7 +85,7 @@ protected slots:
 	void reloadPlugin();
 
 private:
-	void closePlugin( void );
+	void closePlugin();
 
 
 	VstPlugin * m_plugin;
@@ -117,8 +117,8 @@ public:
 
 
 protected slots:
-	void syncPlugin( void );
-	void displayAutomatedOnly( void );
+	void syncPlugin();
+	void displayAutomatedOnly();
 	void setParameter( lmms::Model * action );
 	void syncParameterText();
 	void closeWindow();
@@ -154,16 +154,16 @@ public:
 
 
 protected slots:
-	void updateMenu( void );
-	void openPlugin( void );
-	void managePlugin( void );
-	void openPreset( void );
-	void savePreset( void );
+	void updateMenu();
+	void openPlugin();
+	void managePlugin();
+	void openPreset();
+	void savePreset();
 	void nextProgram();
 	void previousProgram();
-	void selPreset( void );
-	void toggleGUI( void );
-	void noteOffAll( void );
+	void selPreset();
+	void toggleGUI();
+	void noteOffAll();
 
 
 protected:
@@ -173,7 +173,7 @@ protected:
 
 
 private:
-	virtual void modelChanged( void );
+	virtual void modelChanged();
 
 	static QPixmap * s_artwork;
 

plugins/Vibed/Vibed.cpp

@@ -492,7 +492,7 @@ VibedView::VibedView( Instrument * _instrument,
 	m_triangleWaveBtn->setToolTip(
 			tr( "Triangle wave" ) );
 	connect( m_triangleWaveBtn, SIGNAL ( clicked () ),
-			this, SLOT ( triangleWaveClicked( ) ) );
+			this, SLOT ( triangleWaveClicked() ) );
 
 	
 	m_sawWaveBtn = new PixmapButton( this, tr( "Saw wave" ) );

plugins/VstBase/VstPlugin.cpp

@@ -505,7 +505,7 @@ QWidget *VstPlugin::editor()
 }
 
 
-void VstPlugin::openPreset( )
+void VstPlugin::openPreset()
 {
 
 	gui::FileDialog ofd( nullptr, tr( "Open Preset" ), "",
@@ -583,7 +583,7 @@ void VstPlugin::loadParameterDisplays()
 
 
 
-void VstPlugin::savePreset( )
+void VstPlugin::savePreset()
 {
 	QString presName = currentProgramName().isEmpty() ? tr(": default") : currentProgramName();
 	presName.replace("\"", "'"); // QFileDialog unable to handle double quotes properly

plugins/VstBase/VstPlugin.h

@@ -126,13 +126,13 @@ public:
 public slots:
 	void setTempo( lmms::bpm_t _bpm );
 	void updateSampleRate();
-	void openPreset( void );
+	void openPreset();
 	void setProgram( int index );
 	void rotateProgram( int offset );
 	void loadProgramNames();
 	void loadParameterLabels();
 	void loadParameterDisplays();
-	void savePreset( void );
+	void savePreset();
 	void setParam( int i, float f );
 	void idleUpdate();
 

plugins/VstEffect/VstEffectControls.cpp

@@ -167,7 +167,7 @@ gui::EffectControlDialog* VstEffectControls::createView()
 
 
 
-void VstEffectControls::managePlugin( void )
+void VstEffectControls::managePlugin()
 {
 	if ( m_effect->m_plugin != nullptr && m_subWindow == nullptr ) {
 		gui::ManageVSTEffectView * tt = new gui::ManageVSTEffectView( m_effect, this);
@@ -187,11 +187,11 @@ void VstEffectControls::managePlugin( void )
 
 
 
-void VstEffectControls::savePreset( void )
+void VstEffectControls::savePreset()
 {
 
 	if ( m_effect->m_plugin != nullptr ) {
-		m_effect->m_plugin->savePreset( );
+		m_effect->m_plugin->savePreset();
 /*    		bool converted;
     		QString str = m_vi->m_plugin->currentProgramName().section("/", 0, 0);
      		if (str != "")
@@ -204,7 +204,7 @@ void VstEffectControls::savePreset( void )
 
 
 
-void VstEffectControls::updateMenu( void )
+void VstEffectControls::updateMenu()
 {
 
 	// get all presets -
@@ -239,11 +239,11 @@ void VstEffectControls::updateMenu( void )
 
 
 
-void VstEffectControls::openPreset( void )
+void VstEffectControls::openPreset()
 {
 
 	if ( m_effect->m_plugin != nullptr ) {
-		m_effect->m_plugin->openPreset( );
+		m_effect->m_plugin->openPreset();
     		bool converted;
     		QString str = m_effect->m_plugin->currentProgramName().section("/", 0, 0);
      		if (str != "")
@@ -256,7 +256,7 @@ void VstEffectControls::openPreset( void )
 
 
 
-void VstEffectControls::rollPreset( void )
+void VstEffectControls::rollPreset()
 {
 
 	if ( m_effect->m_plugin != nullptr ) {
@@ -272,7 +272,7 @@ void VstEffectControls::rollPreset( void )
 
 
 
-void VstEffectControls::rolrPreset( void )
+void VstEffectControls::rolrPreset()
 {
 
 	if ( m_effect->m_plugin != nullptr ) {
@@ -288,7 +288,7 @@ void VstEffectControls::rolrPreset( void )
 
 
 
-void VstEffectControls::selPreset( void )
+void VstEffectControls::selPreset()
 {
 
      QAction *action = qobject_cast<QAction *>(sender());
@@ -438,7 +438,7 @@ void ManageVSTEffectView::closeWindow()
 
 
 
-void ManageVSTEffectView::syncPlugin( void )
+void ManageVSTEffectView::syncPlugin()
 {
 	char paramStr[35];
 	QStringList s_dumpValues;
@@ -464,7 +464,7 @@ void ManageVSTEffectView::syncPlugin( void )
 
 
 
-void ManageVSTEffectView::displayAutomatedOnly( void )
+void ManageVSTEffectView::displayAutomatedOnly()
 {
 	bool isAuto = QString::compare( m_displayAutomatedOnly->text(), tr( "Automated" ) ) == 0;
 

plugins/VstEffect/VstEffectControls.h

@@ -70,13 +70,13 @@ public:
 
 
 protected slots:
-	void updateMenu( void );
-	void managePlugin( void );
-	void openPreset( void );
-	void savePreset( void );
-	void rollPreset( void );
-	void rolrPreset( void );
-	void selPreset( void );
+	void updateMenu();
+	void managePlugin();
+	void openPreset();
+	void savePreset();
+	void rollPreset();
+	void rolrPreset();
+	void selPreset();
 	void setParameter( lmms::Model * action );
 
 protected:
@@ -117,8 +117,8 @@ public:
 
 
 protected slots:
-	void syncPlugin( void );
-	void displayAutomatedOnly( void );
+	void syncPlugin();
+	void displayAutomatedOnly();
 	void setParameter( lmms::Model * action );
 	void syncParameterText();
 	void closeWindow();

plugins/Xpressive/Xpressive.h

@@ -171,9 +171,9 @@ protected slots:
 	void expWaveClicked();
 	void usrWaveClicked();
 	void helpClicked();
-	void expressionChanged( );
-	void smoothChanged( );
-	void graphDrawn( );
+	void expressionChanged();
+	void smoothChanged();
+	void graphDrawn();
 
 private:
 	void modelChanged() override;