hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Fix std::vector refactor mistake (#6836)

Browse Source 
* Use std::vector const reference instead of copying

* Add assertions

* Simplification
This commit is contained in:
Dalton Messmer
2023-08-31 12:55:02 -04:00
committed by GitHub
parent 005ee47d43
commit 8a94fb3681
13 changed files with 41 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/MidiClip.h
View File

@@ -79,7 +79,7 @@ public:
void setStep( int step, bool enabled );
// Split the list of notes on the given position
void splitNotes(NoteVector notes, TimePos pos);
void splitNotes(const NoteVector& notes, TimePos pos);
// clip-type stuff
inline Type type() const

4
include/PianoRoll.h
View File

@@ -308,9 +308,9 @@ private:
TimePos newNoteLen() const;
void shiftPos(int amount);
void shiftPos(NoteVector notes, int amount);
void shiftPos(const NoteVector& notes, int amount);
void shiftSemiTone(int amount);
void shiftSemiTone(NoteVector notes, int amount);
void shiftSemiTone(const NoteVector& notes, int amount);
bool isSelection() const;
int selectionCount() const;
void testPlayNote( Note * n );