From 8d005e7565b80f161a51bebb26cf62c700b39dd6 Mon Sep 17 00:00:00 2001
From: Johannes Lorenz <j.git@lorenz-ho.me>
Date: Sat, 27 Apr 2019 10:48:37 +0200
Subject: [PATCH] AutomatableModelTest: Improve tests

Check whether returned pointers from the cast are equal to the original
pointers, rather than just checking wether they are not `nullptr`.
---
 tests/src/core/AutomatableModelTest.cpp | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/tests/src/core/AutomatableModelTest.cpp b/tests/src/core/AutomatableModelTest.cpp
index 9bc19d7e8..6717da12d 100644
--- a/tests/src/core/AutomatableModelTest.cpp
+++ b/tests/src/core/AutomatableModelTest.cpp
@@ -32,21 +32,23 @@ class AutomatableModelTest : QTestSuite
 	Q_OBJECT
 
 private slots:
+	//! Test that upcast and exact casts work,
+	//! but no downcast or any other casts
 	void CastTests()
 	{
 		ComboBoxModel comboModel;
 		AutomatableModel* amPtr = &comboModel;
-		QCOMPARE(nullptr, amPtr->dynamicCast<FloatModel>());
-		QVERIFY(nullptr != amPtr->dynamicCast<AutomatableModel>());
-		QVERIFY(nullptr != amPtr->dynamicCast<IntModel>());
-		QVERIFY(nullptr != amPtr->dynamicCast<ComboBoxModel>());
+		QCOMPARE(nullptr, amPtr->dynamicCast<FloatModel>()); // not a parent class
+		QCOMPARE(&comboModel, amPtr->dynamicCast<AutomatableModel>()); // parent class
+		QCOMPARE(&comboModel, amPtr->dynamicCast<IntModel>()); // parent class
+		QCOMPARE(&comboModel, amPtr->dynamicCast<ComboBoxModel>()); // same class
 
 		IntModel intModel;
 		IntModel* imPtr = &intModel;
-		QCOMPARE(nullptr, imPtr->dynamicCast<FloatModel>());
-		QVERIFY(nullptr != imPtr->dynamicCast<AutomatableModel>());
-		QVERIFY(nullptr != imPtr->dynamicCast<IntModel>());
-		QCOMPARE(nullptr, imPtr->dynamicCast<ComboBoxModel>());
+		QCOMPARE(nullptr, imPtr->dynamicCast<FloatModel>()); // not a parent class
+		QCOMPARE(&intModel, imPtr->dynamicCast<AutomatableModel>()); // parent class
+		QCOMPARE(&intModel, imPtr->dynamicCast<IntModel>()); // same class
+		QCOMPARE(nullptr, imPtr->dynamicCast<ComboBoxModel>()); // child class
 	}
 } AutomatableModelTests;