hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Add Beat Preview to PatternClipView (#7559)

Browse Source 
This PR changes the way PatternClips are drawn in include a simple "beat preivew," where each note in any non-empty instrument tracks within the pattern are drawn as short little rectangles on the ClipView. SampleClips and AutomationClips within patterns are not currently supported.

The height of the note boxes changes depending on how many tracks there are in the pattern, and how many of them actually have notes (empty tracks are only drawn half as tall).

There is also some padding at the top and bottom along with a little bit of spacing between each note, both vertically and horizontally. This can be edited in the css, along with the note color.

---------

Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-authored-by: Fawn <rubiefawn@gmail.com>
This commit is contained in:
regulus79
2025-12-02 17:34:50 -05:00
committed by GitHub
parent 58a4a8a909
commit 94f3b9704a
8 changed files with 102 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
data/themes/classic/style.css
View File

@@ -792,7 +792,7 @@ lmms--gui--ClipView {
qproperty-selectedColor: rgb( 0, 125, 255 );
qproperty-patternClipBackground: rgb( 80, 80, 80 );
qproperty-textColor: rgb( 255, 255, 255 );
qproperty-textBackgroundColor: rgba(0, 0, 0, 75);
qproperty-textBackgroundColor: rgba(0, 0, 0, 100);
qproperty-textShadowColor: rgb( 0, 0, 0 );
qproperty-gradient: true; /* boolean property, set true to have a gradient */
qproperty-markerColor: rgb(0, 0, 0);
@@ -825,6 +825,11 @@ lmms--gui--AutomationClipView {
/* pattern clip */
lmms--gui--PatternClipView {
background-color: rgb( 128, 182, 175 ); /* default colour for pattern tracks */
qproperty-emptyTrackHeightRatio: 0.5; /* height of empty tracks versus non-empty tracks */
qproperty-verticalPadding: 0.15; /* padding above and below the beat preview on the clip, fraction of the total clip height */
qproperty-noteVerticalSpacing: 0.2; /* spacing above and below each note, fraction of the note height */
qproperty-noteHorizontalSpacing: 0.2; /* spacing left/right of each note, fraction of the note width */
qproperty-noteColor: #ffffff; /* colour of the beat/note rectangles on the clip */
}
/* Subwindows in MDI-Area */

7
data/themes/default/style.css
View File

@@ -852,7 +852,7 @@ lmms--gui--ClipView {
qproperty-selectedColor: #006B65;
qproperty-patternClipBackground: #373d48;
qproperty-textColor: #fff;
qproperty-textBackgroundColor: rgba(0, 0, 0, 75);
qproperty-textBackgroundColor: rgba(0, 0, 0, 100);
qproperty-textShadowColor: rgba(0,0,0,200);
qproperty-gradient: false; /* boolean property, set true to have a gradient */
qproperty-markerColor: rgb(0, 0, 0);
@@ -885,6 +885,11 @@ lmms--gui--AutomationClipView {
/* pattern clip */
lmms--gui--PatternClipView {
background-color: #20BDB2; /* default colour for pattern tracks */
qproperty-emptyTrackHeightRatio: 0.5; /* height of empty tracks versus non-empty tracks */
qproperty-verticalPadding: 0.15; /* padding above and below the beat preview on the clip, fraction of the total clip height */
qproperty-noteVerticalSpacing: 0.2; /* spacing above and below each note, fraction of the note height */
qproperty-noteHorizontalSpacing: 0.2; /* spacing left/right of each note, fraction of the note width */
qproperty-noteColor: #ffffff; /* colour of the beat/note rectangles on the clip */
}
/* Subwindows in MDI-Area */