hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Make PluginView::isResizable a virtual (#7541)

Browse Source 
Remove the member `PluginView::m_isResizable` and it's associated method `setResizable`. Turn `isResizable` into a virtual method.

The reasoning is that whether or not an effect can be resized depends on its implementation. Therefore does not make sense to have a method like `setResizable`. If the underlying implementation does not support resizing then it would not make sense to call `setResizable(true)`. So `isResizable` now describes the underlying ability of a plugin to resize. It's then up to the clients of that method to decide how to treat the result of `isResizable`, i.e. if they want to make use of the ability to resize or not.
This commit is contained in:
Johannes Lorenz
2024-10-12 10:39:42 +02:00
committed by GitHub
parent fb5516cfdc
commit 97b61bbd9a
3 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
include/PluginView.h
View File

@@ -41,11 +41,7 @@ public:
{
}
void setResizable(bool resizable) { m_isResizable = resizable; }
bool isResizable() { return m_isResizable; }
private:
bool m_isResizable = false;
virtual bool isResizable() const { return false; }
};
} // namespace lmms::gui