From 9acb47a7a88ac56c607c0705f7567ec923159768 Mon Sep 17 00:00:00 2001 From: Tobias Doerffel Date: Sun, 15 Aug 2010 14:19:43 +0200 Subject: [PATCH] InstrumentTrackWindow: correctly disconnect from track's signals We used QObject::disconnect() the wrong way leading to multiple connections from InstrumentTrack::instrumentChanged() to InstrumentTrackWindow::updateInstrumentView(). This resulted in loading times being doubled each time you loaded a preset on the same InstrumentTrack. Closes #2934099. --- src/tracks/InstrumentTrack.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tracks/InstrumentTrack.cpp b/src/tracks/InstrumentTrack.cpp index 05ec5b72e..9d3c69b95 100644 --- a/src/tracks/InstrumentTrack.cpp +++ b/src/tracks/InstrumentTrack.cpp @@ -1368,8 +1368,8 @@ void InstrumentTrackWindow::modelChanged() m_nameLineEdit->setText( m_track->name() ); - disconnect( m_track, SIGNAL( nameChanged() ) ); - disconnect( m_track, SIGNAL( instrumentChanged() ) ); + m_track->disconnect( SIGNAL( nameChanged() ), this ); + m_track->disconnect( SIGNAL( instrumentChanged() ), this ); connect( m_track, SIGNAL( nameChanged() ), this, SLOT( updateName() ) );