From b68dc572a3a58ad2187efe3ef5b4848ef7254abd Mon Sep 17 00:00:00 2001 From: Oskar Wallgren Date: Sat, 18 Nov 2017 15:03:37 +0100 Subject: [PATCH] Automtion Editor - left click response When you left click an existing value the automation point will only snap to the new value if it is higher. If it is lower the mouse click event will 'break'. Cleanup. Remove statement that will always evaluate as 'true'. --- src/3rdparty/rpmalloc/rpmalloc | 2 +- src/gui/editors/AutomationEditor.cpp | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/3rdparty/rpmalloc/rpmalloc b/src/3rdparty/rpmalloc/rpmalloc index 2e0479192..f3b2e6308 160000 --- a/src/3rdparty/rpmalloc/rpmalloc +++ b/src/3rdparty/rpmalloc/rpmalloc @@ -1 +1 @@ -Subproject commit 2e0479192b8dfb15e0084969fdf06208cffbfd09 +Subproject commit f3b2e630871c32288e7b501877c6d99d20171c20 diff --git a/src/gui/editors/AutomationEditor.cpp b/src/gui/editors/AutomationEditor.cpp index be3fb5248..f9124aaa8 100644 --- a/src/gui/editors/AutomationEditor.cpp +++ b/src/gui/editors/AutomationEditor.cpp @@ -517,16 +517,13 @@ void AutomationEditor::mousePressEvent( QMouseEvent* mouseEvent ) // loop through whole time-map... while( it != time_map.end() ) { - MidiTime len = 4; - // and check whether the user clicked on an // existing value if( pos_ticks >= it.key() && - len > 0 && ( it+1==time_map.end() || pos_ticks <= (it+1).key() ) && ( pos_ticks<= it.key() + MidiTime::ticksPerTact() *4 / m_ppt ) && - level <= it.value() ) + level == it.value() ) { break; }