From b75c3239f46a5b48e9421075535d2df18fff0efb Mon Sep 17 00:00:00 2001 From: Tobias Doerffel Date: Wed, 24 Sep 2008 09:08:53 +0000 Subject: [PATCH] do not crash when opening controller connection dialog and using a non-sequenced (raw) MIDI-client git-svn-id: https://lmms.svn.sf.net/svnroot/lmms/trunk/lmms@1705 0778d3d1-df1d-0410-868b-ea421aaaa00d --- ChangeLog | 15 +++++++++++++++ src/gui/controller_connection_dialog.cpp | 5 ++++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index dcfc582b2..406c87cfa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,18 @@ +2008-09-24 Tobias Doerffel + + * src/core/sample_buffer.cpp: + * src/core/sample_record_handle.cpp: + * src/tracks/sample_track.cpp: + * plugins/bit_invader/bit_invader.cpp: + fixed compiler warnings + + * src/gui/controller_connection_dialog.cpp: + do not crash when opening controller connection dialog and using a + non-sequenced (raw) MIDI-client + + * data/presets/TripleOscillator/SawLead.xpf: + fixed preset name + 2008-09-23 Tobias Doerffel * CMakeLists.txt: diff --git a/src/gui/controller_connection_dialog.cpp b/src/gui/controller_connection_dialog.cpp index 53d212b30..7912d948e 100644 --- a/src/gui/controller_connection_dialog.cpp +++ b/src/gui/controller_connection_dialog.cpp @@ -361,7 +361,10 @@ void controllerConnectionDialog::midiToggled( void ) &m_midiController->m_midiPort.m_inputChannelModel ); m_midiControllerSpinBox->setModel( &m_midiController->m_midiPort.m_inputControllerModel ); - m_readablePorts->setModel( &m_midiController->m_midiPort ); + if( m_readablePorts ) + { + m_readablePorts->setModel( &m_midiController->m_midiPort ); + } connect( m_midiController, SIGNAL( valueChanged() ),