From bd72070aa0a72f86da6414e3f00ab2a7ae3303f0 Mon Sep 17 00:00:00 2001
From: Tobias Doerffel <tobias.doerffel@gmail.com>
Date: Mon, 25 Feb 2008 14:12:25 +0000
Subject: [PATCH] fixed tag-renaming-loops

git-svn-id: https://lmms.svn.sf.net/svnroot/lmms/branches/lmms-mv@709 0778d3d1-df1d-0410-868b-ea421aaaa00d
---
 src/lib/mmp.cpp | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/lib/mmp.cpp b/src/lib/mmp.cpp
index 44ef7f3df..5eace5c53 100644
--- a/src/lib/mmp.cpp
+++ b/src/lib/mmp.cpp
@@ -556,18 +556,18 @@ void multimediaProject::upgrade( void )
 
 	if( version < "0.3.0" )
 	{
-		QDomNodeList list = elementsByTagName( "pluckedstringsynth" );
-		for( int i = 0; !list.item( i ).isNull(); ++i )
+		QDomNodeList list;
+		while( !( list = elementsByTagName(
+					"pluckedstringsynth" ) ).isEmpty() )
 		{
-			QDomElement el = list.item( i ).toElement();
+			QDomElement el = list.item( 0 ).toElement();
 			el.setTagName( "vibedstrings" );
 			el.setAttribute( "active0", 1 );
 		}
 
-		list = elementsByTagName( "lb303" );
-		for( int i = 0; !list.item( i ).isNull(); ++i )
+		while( !( list = elementsByTagName( "lb303" ) ).isEmpty() )
 		{
-			QDomElement el = list.item( i ).toElement();
+			QDomElement el = list.item( 0 ).toElement();
 			el.setTagName( "lb302" );
 		}
 	}
@@ -585,15 +585,14 @@ void multimediaProject::upgrade( void )
 			}
 		}
 	}
-
 	if( version < "0.4.0-svn20080118" )
 	{
-		QDomNodeList list = elementsByTagName( "fx" );
-		for( int i = 0; !list.item( i ).isNull(); ++i )
+		QDomNodeList list;
+		while( !( list = elementsByTagName( "fx" ) ).isEmpty() )
 		{
-			QDomElement fxchain = list.item( i ).toElement();
+			QDomElement fxchain = list.item( 0 ).toElement();
 			fxchain.setTagName( "fxchain" );
-			QDomNode rack = list.item( i ).firstChild();
+			QDomNode rack = list.item( 0 ).firstChild();
 			QDomNodeList effects = rack.childNodes();
 			// move items one level up
 			while( effects.count() )
@@ -624,6 +623,7 @@ void multimediaProject::upgrade( void )
 	{
 		m_head.setAttribute( "mastervol", 100 );
 	}
+//printf("%s\n", toString( 2 ).toAscii().constData());
 }