From d41d02ad046458e59c6bf0a33838bfb343caff3e Mon Sep 17 00:00:00 2001 From: sakertooth Date: Wed, 27 Sep 2023 07:19:37 -0400 Subject: [PATCH] Set user wave, even when value is empty If the value or file is empty, I think showing a error popup here is ideal. --- src/gui/instrument/EnvelopeAndLfoView.cpp | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/gui/instrument/EnvelopeAndLfoView.cpp b/src/gui/instrument/EnvelopeAndLfoView.cpp index 9182b9d03..c9374e4ec 100644 --- a/src/gui/instrument/EnvelopeAndLfoView.cpp +++ b/src/gui/instrument/EnvelopeAndLfoView.cpp @@ -323,11 +323,7 @@ void EnvelopeAndLfoView::dropEvent( QDropEvent * _de ) QString value = StringPairDrag::decodeValue( _de ); if( type == "samplefile" ) { - if (!value.isEmpty()) - { - m_params->m_userWave = SampleLoader::createBufferFromFile(value); - } - + m_params->m_userWave = SampleLoader::createBufferFromFile(value); m_userLfoBtn->model()->setValue( true ); m_params->m_lfoWaveModel.setValue(static_cast(EnvelopeAndLfoParameters::LfoShape::UserDefinedWave)); _de->accept(); @@ -339,13 +335,8 @@ void EnvelopeAndLfoView::dropEvent( QDropEvent * _de ) auto file = dataFile.content(). firstChildElement().firstChildElement(). firstChildElement().attribute("src"); - - if (!file.isEmpty()) - { - auto buffer = SampleLoader::createBufferFromFile(file); - m_params->m_userWave = std::shared_ptr(std::move(buffer)); - } - + auto buffer = SampleLoader::createBufferFromFile(file); + m_params->m_userWave = std::shared_ptr(std::move(buffer)); m_userLfoBtn->model()->setValue( true ); m_params->m_lfoWaveModel.setValue(static_cast(EnvelopeAndLfoParameters::LfoShape::UserDefinedWave)); _de->accept();