From d4cabd5650f38dd1a79be8f2fad28b2e59e37590 Mon Sep 17 00:00:00 2001
From: regulus79 <117475203+regulus79@users.noreply.github.com>
Date: Tue, 6 Jan 2026 06:34:38 -0500
Subject: [PATCH] Fix Sample Clip Loop Exporting (#8192)

Fixes #8190

When #7454 was merged, I added a check before emitting playbackPositionJumped to only emit when the song was playing, to prevent LFOs from being reset when the user dragged the timeline while the song was paused. However, I used Song::isPlaying(), which only returns true when the song is not exporting. This caused sample clips to not be updated when the playback position jumped back every loop, which means they just kept playing, ignoring the loop. To fix this, I have changed it to use m_playing, which is true for both exporting and normal playing.
---
 src/core/Song.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/Song.cpp b/src/core/Song.cpp
index 0b42c219b..457899156 100644
--- a/src/core/Song.cpp
+++ b/src/core/Song.cpp
@@ -124,7 +124,7 @@ Song::Song() :
 		connect(&timeline, &Timeline::positionJumped, this, [this](){
 			// Only emit the signal when the song is actually playing
 			// This prevents LFOs from changing phase when the user drags the timeline while paused
-			if (isPlaying()) { emit playbackPositionJumped(); }
+			if (m_playing) { emit playbackPositionJumped(); }
 		}, Qt::DirectConnection);
 	}