From e7484c89fd8749d53e7ac916a091935bb5e6e694 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Tue, 16 Dec 2008 03:27:40 +0000 Subject: [PATCH] shift+drag didn't update beat+bassline (FIXED) git-svn-id: https://lmms.svn.sf.net/svnroot/lmms/trunk/lmms@1937 0778d3d1-df1d-0410-868b-ea421aaaa00d --- ChangeLog | 1 + TODO | 3 ++- src/gui/piano_roll.cpp | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9d7929c24..fdd532006 100644 --- a/ChangeLog +++ b/ChangeLog @@ -15,6 +15,7 @@ - shift drag on an unselected note didn't work (FIXED) - added a note detuning tool - fixed mouse cursor glitch when mousing over notes + - shift+drag didn't update beat+bassline (FIXED) * src/tracks/instrument_track.cpp: fixed crash in processAudioBuffer when notePlayHandle was NULL diff --git a/TODO b/TODO index 6f00bc78f..e96209be0 100644 --- a/TODO +++ b/TODO @@ -52,6 +52,7 @@ - add FLAC as export-format? Andrew Kelley's todo: +- if a different window is selected and you hold control and then click in the piano roll, it doesn't do selection like it should - when looking at a piano roll, if the song is playing that pattern, move the position ticker to where it should be - multiview button - show notes from every instrument in the current beat+bassline with different colors - undo/redo for piano roll @@ -61,6 +62,7 @@ Andrew Kelley's todo: * quick slice * look through FL Studio's tools and implement some of them - slice tool for piano roll +- when a note is played, show the note as being depressed in the piano roll - recording automation - make knobs easier to tune (less sensitive) @@ -75,6 +77,5 @@ Andrew Kelley's todo: - adding/removing steps to the beat+bassline editor is awkward - the 'add beat+bassline' button in the beat+bassline editor is misleading - I say we remove it and rely on the song editor to add beat+basslines - make it so that 3xosc notes don't max out -- implement note detuning (used to be ctrl+click to access note detuning) (need some other intuitive way to access note detuning as ctrl, shift, and alt are all being used) - copy-pasted automation patterns have to be manually linked back to their knob for some reason - fix memory leaks diff --git a/src/gui/piano_roll.cpp b/src/gui/piano_roll.cpp index be566bcec..fab8d59df 100644 --- a/src/gui/piano_roll.cpp +++ b/src/gui/piano_roll.cpp @@ -2384,12 +2384,12 @@ void pianoRoll::dragNotes( int x, int y, bool alt ) ( *it )->setLength( midiTime( ticks_new ) ); m_lenOfNewNotes = ( *it )->length(); - m_pattern->dataChanged(); } } ++it; } + m_pattern->dataChanged(); engine::getSong()->setModified(); }