From f4f85e1f3324a2367551787620b98e321b559e4a Mon Sep 17 00:00:00 2001 From: Itreza2 <87203566+Itreza2@users.noreply.github.com> Date: Mon, 19 Jan 2026 16:53:10 +0100 Subject: [PATCH] Avoid adding journal checkpoints when initially creating volume knobs (#8214) * reimplement getter and setter of FloatModelEditorBase::m_volumeKnob to avoid undo checkpoint creation * convert FloatModelEditorBase::m_volumeKnob from BoolModel to bool * clean up * remove unnecessary inline keywords and fix formatting --------- Co-authored-by: Sotonye Atemie --- include/FloatModelEditorBase.h | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/include/FloatModelEditorBase.h b/include/FloatModelEditorBase.h index ef32bcc0d..39a3fa030 100644 --- a/include/FloatModelEditorBase.h +++ b/include/FloatModelEditorBase.h @@ -41,7 +41,6 @@ class LMMS_EXPORT FloatModelEditorBase : public QWidget, public FloatModelView { Q_OBJECT - mapPropertyFromModel(bool, isVolumeKnob, setVolumeKnob, m_volumeKnob); mapPropertyFromModel(float, volumeRatio, setVolumeRatio, m_volumeRatio); void initUi(const QString & name); //!< to be called by ctors @@ -63,6 +62,16 @@ public: setUnit(txt_after); } + bool isVolumeKnob() const + { + return m_volumeKnob; + } + + void setVolumeKnob(const bool val) + { + m_volumeKnob = val; + } + signals: void sliderPressed(); void sliderReleased(); @@ -103,7 +112,7 @@ protected: static SimpleTextFloat * s_textFloat; - BoolModel m_volumeKnob; + bool m_volumeKnob; FloatModel m_volumeRatio; QPoint m_lastMousePos; //!< mouse position in last mouseMoveEvent