From f6b696fa0fd4f144e54c3eb2839293a74708be7f Mon Sep 17 00:00:00 2001 From: Colin Wallace Date: Tue, 25 Aug 2015 18:59:11 -0700 Subject: [PATCH] Don't use underscore parameter names in value, setValue functions --- include/ConfigManager.h | 8 ++++---- src/core/ConfigManager.cpp | 30 +++++++++++++++--------------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/include/ConfigManager.h b/include/ConfigManager.h index 8d213b3d7..0e73ebc2e 100644 --- a/include/ConfigManager.h +++ b/include/ConfigManager.h @@ -224,10 +224,10 @@ public: void addRecentlyOpenedProject( const QString & _file ); - const QString & value( const QString & _class, - const QString & _attribute ) const; - void setValue( const QString & _class, const QString & _attribute, - const QString & _value ); + const QString & value( const QString & cls, + const QString & attribute ) const; + void setValue( const QString & cls, const QString & attribute, + const QString & value ); void deleteValue( const QString & cls, const QString & attribute); void loadConfigFile(); diff --git a/src/core/ConfigManager.cpp b/src/core/ConfigManager.cpp index 0dc5a25e4..523e0748c 100644 --- a/src/core/ConfigManager.cpp +++ b/src/core/ConfigManager.cpp @@ -277,16 +277,16 @@ void ConfigManager::addRecentlyOpenedProject( const QString & _file ) -const QString & ConfigManager::value( const QString & _class, - const QString & _attribute ) const +const QString & ConfigManager::value( const QString & cls, + const QString & attribute ) const { - if( m_settings.contains( _class ) ) + if( m_settings.contains( cls ) ) { for( stringPairVector::const_iterator it = - m_settings[_class].begin(); - it != m_settings[_class].end(); ++it ) + m_settings[cls].begin(); + it != m_settings[cls].end(); ++it ) { - if( ( *it ).first == _attribute ) + if( ( *it ).first == attribute ) { return ( *it ).second ; } @@ -299,24 +299,24 @@ const QString & ConfigManager::value( const QString & _class, -void ConfigManager::setValue( const QString & _class, - const QString & _attribute, - const QString & _value ) +void ConfigManager::setValue( const QString & cls, + const QString & attribute, + const QString & value ) { - if( m_settings.contains( _class ) ) + if( m_settings.contains( cls ) ) { - for( stringPairVector::iterator it = m_settings[_class].begin(); - it != m_settings[_class].end(); ++it ) + for( stringPairVector::iterator it = m_settings[cls].begin(); + it != m_settings[cls].end(); ++it ) { - if( ( *it ).first == _attribute ) + if( ( *it ).first == attribute ) { - ( *it ).second = _value; + ( *it ).second = value; return; } } } // not in map yet, so we have to add it... - m_settings[_class].push_back( qMakePair( _attribute, _value ) ); + m_settings[cls].push_back( qMakePair( attribute, value ) ); }