From fb935ecface7de5b5ada560b6148491f5add2794 Mon Sep 17 00:00:00 2001 From: Achim Settelmeier Date: Sat, 30 May 2009 00:56:01 +0200 Subject: [PATCH] Code refactoring to use iterator instead of Qt's elementsByTagName(). Signed-off-by: Tobias Doerffel --- src/core/midi/midi_control_listener.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/midi/midi_control_listener.cpp b/src/core/midi/midi_control_listener.cpp index da674be7c..a7a4ae569 100644 --- a/src/core/midi/midi_control_listener.cpp +++ b/src/core/midi/midi_control_listener.cpp @@ -306,10 +306,10 @@ void MidiControlListener::readConfiguration() m_useControlKey = false; } - QDomNodeList deviceNodes = s_configTree.elementsByTagName( "device" ); - for( uint i = 0; i < deviceNodes.length(); ++i ) + for( QDomElement deviceNode = s_configTree.firstChildElement( "device" ); + !deviceNode.isNull(); + deviceNode = deviceNode.nextSiblingElement( "device" ) ) { - QDomElement deviceNode = deviceNodes.at( i ).toElement(); if( deviceNode.text() != "" ) { m_port.subscribeReadablePort( deviceNode.text(), true ); @@ -321,7 +321,7 @@ void MidiControlListener::readConfiguration() // use iterator instead of elementsByTagName(), which under unsetteled circumstances returns an empty list for( QDomElement actionNode = s_configTree.firstChildElement( "action" ); !actionNode.isNull(); - actionNode = actionNode.nextSiblingElement("action") ) + actionNode = actionNode.nextSiblingElement( "action" ) ) { EventAction action = actionName2ActionNameMap( actionNode.attribute( "actionName" ) ).action;