rghvdberg
ea295c4ee8
Pianoroll: nudge/snap while dragging notes ( #5848 )
...
* pianoroll: nudge/snap while dragging notes
combobox for switching behavior
old behavior (nudge) is default
* snap note start or note end to nearest grid line
* fix member variable name
* change default width of pianoroll
* remove trailing white space
* use mouse position instead of m_draggednote
* Uses enum instead of text for GridMode selection
To avoid problems with translations breaking the conditional,
PianoRoll::changeSnapMode now uses the value of the ComboBox model,
casted to the GridMode enum instead of the text.
* Fixes last code style issues
A few code style issues were left, those are fixed in this
commit.
* Removes forgotten comma on enum
Since the last enum value was commented out, there's an
unnecessary comma left that was removed.
* Rewrites some of the grid logic
Separates Nudge logic and Snap logic more explicitly.
Avoids recalculation of mouse conversion to time line ticks.
Disables shift resizing for Snap mode.
Removes unnecessary range checks.
Fixes bug with note key boundary checks (which is present in master).
* Make noteOffset an int instead of TimePos
Co-authored-by: Ian Caio <iancaio_dev@hotmail.com >
2021-03-05 09:38:33 -03:00
..
2017-02-06 02:41:15 +02:00
2017-02-06 02:41:15 +02:00
2020-05-17 11:15:39 +09:00
2020-08-30 19:27:17 +01:00
2019-10-31 20:05:33 +01:00
2020-07-10 10:58:52 +09:00
2017-02-06 02:41:15 +02:00
2020-08-30 19:27:17 +01:00
2018-07-05 20:16:01 +09:00
2017-08-04 07:19:39 +09:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-08-30 19:27:17 +01:00
2020-08-30 19:27:17 +01:00
2019-10-31 20:05:33 +01:00
2020-08-30 19:27:17 +01:00
2020-08-30 19:27:17 +01:00
2019-10-31 20:05:33 +01:00
2020-08-30 19:27:17 +01:00
2020-08-30 19:27:17 +01:00
2020-10-30 13:16:27 +09:00
2019-10-31 20:05:33 +01:00
2020-11-29 19:46:13 +01:00
2020-12-01 22:27:37 -03:00
2019-10-31 20:05:33 +01:00
2021-02-28 06:48:15 -03:00
2021-02-28 06:48:15 -03:00
2021-02-28 06:48:15 -03:00
2020-12-04 02:47:16 +01:00
2020-12-04 02:47:16 +01:00
2018-07-07 11:20:54 +02:00
2017-02-06 02:41:15 +02:00
2019-06-15 23:33:29 +03:00
2020-12-04 02:47:16 +01:00
2020-12-04 02:47:16 +01:00
2020-12-08 00:25:00 +01:00
2018-07-07 11:20:54 +02:00
2018-07-07 11:20:54 +02:00
2020-10-10 15:17:25 +09:00
2020-08-11 11:01:58 +02:00
2020-08-17 10:12:49 -04:00
2019-03-16 20:19:27 +01:00
2020-09-18 00:45:46 +02:00
2020-05-17 09:22:36 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-04-24 11:25:49 +03:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-02-21 19:26:29 +01:00
2019-10-31 20:05:33 +01:00
2020-05-17 11:15:39 +09:00
2021-02-28 06:48:15 -03:00
2017-12-11 10:46:19 -05:00
2017-02-06 02:41:15 +02:00
2015-04-27 13:04:26 +03:00
2020-09-13 11:09:46 +09:00
2019-10-31 20:05:33 +01:00
2018-07-05 20:16:01 +09:00
2019-06-15 23:33:29 +03:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-07-24 10:33:15 +09:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2020-11-07 15:52:32 +01:00
2017-02-06 02:41:15 +02:00
2020-11-07 15:52:32 +01:00
2018-10-11 19:32:11 +02:00
2017-02-06 02:41:15 +02:00
2020-11-20 15:49:15 +00:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-09-13 11:09:46 +09:00
2020-09-21 09:55:46 +09:00
2018-03-09 11:41:17 -05:00
2020-03-11 15:07:02 -04:00
2021-01-23 13:52:36 +01:00
2020-11-26 22:25:32 +00:00
2020-09-13 11:09:46 +09:00
2020-08-11 11:01:58 +02:00
2019-10-31 20:05:33 +01:00
2020-11-16 23:02:57 +05:30
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2020-11-14 16:45:49 +01:00
2019-10-31 20:05:33 +01:00
2021-02-28 06:48:15 -03:00
2020-11-29 19:46:13 +01:00
2021-01-01 14:43:46 +01:00
2021-01-01 14:43:46 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-08-30 19:27:17 +01:00
2019-10-31 20:05:33 +01:00
2020-12-04 02:47:16 +01:00
2019-07-17 22:20:25 +02:00
2017-02-06 02:41:15 +02:00
2018-07-05 20:16:01 +09:00
2019-10-31 20:05:33 +01:00
2021-01-28 15:27:13 +09:00
2018-12-27 21:24:19 +01:00
2008-07-22 11:36:50 +00:00
2018-04-15 21:38:37 -04:00
2019-10-31 20:05:33 +01:00
2018-07-07 11:20:54 +02:00
2018-07-07 11:20:54 +02:00
2020-06-01 15:19:20 +02:00
2020-04-04 12:08:55 +09:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2020-09-12 09:36:38 +02:00
2020-09-12 09:36:38 +02:00
2020-09-21 09:04:44 +02:00
2019-11-21 14:44:18 +01:00
2020-09-10 22:47:06 +02:00
2019-09-09 00:22:43 -04:00
2019-10-31 20:05:33 +01:00
2018-09-12 11:02:40 +09:00
2018-04-28 12:54:46 -07:00
2018-04-28 12:54:46 -07:00
2020-09-21 09:04:44 +02:00
2020-05-24 12:50:50 +02:00
2020-11-29 19:46:13 +01:00
2020-10-20 10:36:22 +02:00
2020-08-09 22:59:37 +02:00
2020-12-08 00:12:04 +01:00
2020-12-08 00:12:04 +01:00
2020-12-03 06:10:30 +01:00
2020-12-08 00:12:04 +01:00
2020-10-31 13:28:18 +00:00
2020-12-08 00:12:04 +01:00
2020-09-24 17:59:07 +02:00
2020-10-31 13:28:18 +00:00
2019-10-31 20:05:33 +01:00
2020-09-13 11:09:46 +09:00
2017-09-26 20:33:09 +02:00
2018-07-07 11:20:54 +02:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2017-11-22 20:38:10 +01:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2020-11-29 19:46:13 +01:00
2020-11-29 19:46:13 +01:00
2020-12-01 22:27:37 -03:00
2020-11-29 19:46:13 +01:00
2020-11-29 19:46:13 +01:00
2019-10-31 20:05:33 +01:00
2020-12-07 17:11:41 -03:00
2020-11-29 19:46:13 +01:00
2020-10-17 20:56:05 +02:00
2017-11-17 09:51:56 -05:00
2019-10-31 20:05:33 +01:00
2020-11-29 19:46:13 +01:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2020-11-29 19:46:13 +01:00
2021-01-23 13:52:36 +01:00
2017-11-22 20:38:10 +01:00
2019-10-31 20:05:33 +01:00
2019-01-31 23:12:45 +01:00
2019-03-27 07:05:38 +09:00
2020-12-01 22:27:37 -03:00
2019-04-27 15:26:17 +02:00
2020-11-29 19:46:13 +01:00
2020-11-29 19:46:13 +01:00
2019-10-31 20:05:33 +01:00
2020-09-10 22:47:06 +02:00
2020-07-11 18:40:12 -04:00
2017-08-04 07:19:39 +09:00
2017-02-06 02:41:15 +02:00
2019-11-15 17:09:57 -05:00
2020-07-28 17:07:35 +02:00
2021-02-26 17:17:16 +05:30
2019-10-31 20:05:33 +01:00
2018-04-03 13:37:25 +02:00
2018-05-06 16:34:08 -07:00
2021-03-05 09:38:33 -03:00
2020-06-21 11:17:05 +09:00
2019-11-15 17:09:57 -05:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-11-24 23:55:10 +00:00
2018-12-27 21:24:19 +01:00
2020-11-29 11:26:08 +01:00
2018-07-07 11:20:54 +02:00
2020-08-09 18:01:35 -05:00
2020-12-04 02:47:16 +01:00
2019-05-13 20:23:01 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-09-21 16:50:55 +02:00
2019-08-24 18:55:30 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-04-25 18:49:39 +02:00
2019-11-21 14:44:18 +01:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-12-29 23:01:41 +01:00
2019-10-31 20:05:33 +01:00
2020-11-29 19:46:13 +01:00
2020-12-29 23:01:41 +01:00
2019-10-31 20:05:33 +01:00
2018-07-07 11:20:54 +02:00
2020-11-24 21:49:54 +01:00
2018-04-25 12:50:44 +02:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2021-01-23 13:52:36 +01:00
2020-11-29 19:46:13 +01:00
2020-10-04 15:25:41 +02:00
2020-11-29 19:46:13 +01:00
2020-11-29 19:46:13 +01:00
2020-10-10 15:17:25 +09:00
2020-09-13 11:09:46 +09:00
2017-02-06 02:41:15 +02:00
2018-07-07 11:20:54 +02:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2019-08-28 22:51:54 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-04-28 12:54:46 -07:00
2019-10-31 20:05:33 +01:00
2020-11-29 19:46:13 +01:00
2020-11-29 19:46:13 +01:00
2018-05-06 16:34:08 -07:00
2018-07-07 11:20:54 +02:00
2018-07-07 11:20:54 +02:00
2018-07-07 11:20:54 +02:00
2020-12-04 02:47:16 +01:00
2020-11-29 19:46:13 +01:00
2020-12-04 02:47:16 +01:00
2020-12-04 02:47:16 +01:00
2020-12-12 11:33:45 -03:00
2020-12-04 02:47:16 +01:00
2019-10-31 20:05:33 +01:00
2020-12-04 02:47:16 +01:00
2019-10-31 20:05:33 +01:00
2020-12-04 02:47:16 +01:00
2018-07-07 11:20:54 +02:00
2019-06-09 15:44:32 +03:00
2019-10-21 11:18:39 +09:00
2019-11-06 22:06:15 -05:00
2019-03-14 09:44:48 +09:00
2019-03-14 09:44:48 +09:00