Files
lmms/include
regulus79 84f691cafc Fix PianoRoll Timeline Constantly Emitting positionJumped During Record-Play (#8252)
When #7454 was merged, Timelines were refactored to emit a positionJumped signal whenever their internal tick position was changed via Timeline::setTicks. This was meant as an easy way to account for all situations where the user might drag or click or somehow forcefully set the position of a timeline mid-playback.
However, the current way timeline syncing is implemented between the song editor and piano roll (when doing record-play in the piano roll) is by constantly calling setTicks on the piano roll's timeline whenever the song editor's timeline moves. This inadvertantly means that positionJumped is being emitted, even when the timeline is tracking smoothly.

This PR attempts to address this issue by adding an optional parameter to Timeline::setTicks which allows the caller to opt out of emitting positionJumped. Ideally, we would have a better system for syncing timelines together, one which does not rely on forcefully calling setTicks. But for now, this should work.

---------

Co-authored-by: Sotonye Atemie <satemiej@gmail.com>
2026-02-08 15:22:20 -05:00
..
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2025-10-20 22:20:01 -04:00
2023-01-05 17:58:49 -05:00
2024-08-11 12:20:02 +02:00
2025-11-03 11:58:15 -06:00
2025-10-20 22:20:01 -04:00
2023-01-05 17:58:49 -05:00
2023-11-11 18:09:38 -05:00
2025-11-03 11:58:15 -06:00
2025-11-03 11:58:15 -06:00
2023-11-19 00:44:15 -05:00
2025-06-15 14:41:23 -04:00
2025-11-03 11:58:15 -06:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2025-08-14 10:08:04 -04:00
2023-01-05 17:58:49 -05:00
2025-11-03 11:58:15 -06:00
2025-10-20 22:20:01 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2025-03-20 01:30:29 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2026-01-04 21:18:37 -05:00
2025-11-03 11:58:15 -06:00
2025-11-03 11:58:15 -06:00
2023-09-28 20:23:35 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2008-07-22 11:36:50 +00:00
2023-01-05 17:58:49 -05:00
2023-11-19 00:44:15 -05:00
2025-10-20 22:20:01 -04:00
2025-10-20 22:20:01 -04:00
2023-01-05 17:58:49 -05:00
2025-10-20 22:20:01 -04:00
2025-06-08 20:15:16 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-07-08 23:02:49 +02:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2025-11-03 11:58:15 -06:00
2023-01-05 17:58:49 -05:00
2025-10-20 22:20:01 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-07-22 23:03:31 +02:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-06-02 22:17:03 +02:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-06-01 12:09:47 +02:00
2023-01-05 17:58:49 -05:00
2023-11-19 00:44:15 -05:00
2023-01-05 17:58:49 -05:00
2024-02-25 13:49:56 -05:00
2025-11-03 11:58:15 -06:00
2024-07-08 23:02:49 +02:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2025-10-20 22:20:01 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2026-01-04 21:18:37 -05:00
2026-01-04 21:18:37 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2025-10-20 22:20:01 -04:00
2023-07-16 14:11:24 +02:00
2023-01-05 17:58:49 -05:00
2025-11-03 11:58:15 -06:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-02-25 13:49:56 -05:00