clang-tidy: Apply modernize-use-equals-default everywhere (#6450)

include/AudioAlsa.h

@@ -54,7 +54,7 @@ public:
 			m_deviceName(deviceName),
 			m_deviceDescription(deviceDescription)
 		{}
-		~DeviceInfo() {}
+		~DeviceInfo() = default;
 
 		QString const & getDeviceName() const { return m_deviceName; }
 		QString const & getDeviceDescription() const { return m_deviceDescription; }

include/AudioDeviceSetupWidget.h

@@ -36,7 +36,7 @@ class AudioDeviceSetupWidget : public TabWidget
 public:
 	AudioDeviceSetupWidget( const QString & _caption, QWidget * _parent );
 
-	~AudioDeviceSetupWidget() override;
+	~AudioDeviceSetupWidget() override = default;
 
 	virtual void saveSettings() = 0;
 

include/AudioDummy.h

@@ -62,9 +62,7 @@ public:
 		{
 		}
 
-		~setupWidget() override
-		{
-		}
+		~setupWidget() override = default;
 
 		void saveSettings() override
 		{

include/AudioEngineProfiler.h

@@ -37,7 +37,7 @@ class AudioEngineProfiler
 {
 public:
 	AudioEngineProfiler();
-	~AudioEngineProfiler();
+	~AudioEngineProfiler() = default;
 
 	void startPeriod()
 	{

include/AudioSdl.h

@@ -61,7 +61,7 @@ public:
 	{
 	public:
 		setupWidget( QWidget * _parent );
-		~setupWidget() override;
+		~setupWidget() override = default;
 
 		void saveSettings() override;
 

include/AudioSndio.h

@@ -63,7 +63,7 @@ public:
 	{
 	public:
 		setupWidget( QWidget * _parent );
-		~setupWidget() override;
+		~setupWidget() override = default;
 
 		void saveSettings() override;
 

include/AudioSoundIo.h

@@ -51,7 +51,7 @@ class AudioSoundIoSetupUtil : public QObject
 {
 	Q_OBJECT
 public:
-	virtual ~AudioSoundIoSetupUtil();
+	virtual ~AudioSoundIoSetupUtil() = default;
 
 	void *m_setupWidget;
 public slots:

include/AutomatableSlider.h

@@ -39,7 +39,7 @@ class AutomatableSlider : public QSlider, public IntModelView
 	Q_OBJECT
 public:
 	AutomatableSlider( QWidget * _parent, const QString & _name = QString() );
-	~AutomatableSlider() override;
+	~AutomatableSlider() override = default;
 
 	bool showStatus()
 	{

include/AutomationClipView.h

@@ -45,7 +45,7 @@ class AutomationClipView : public ClipView
 
 public:
 	AutomationClipView( AutomationClip * _clip, TrackView * _parent );
-	~AutomationClipView() override;
+	~AutomationClipView() override = default;
 
 public slots:
 	/// Opens this view's clip in the global automation editor

include/AutomationEditor.h

@@ -255,7 +255,7 @@ class AutomationEditorWindow : public Editor
 	static const int INITIAL_HEIGHT = 480;
 public:
 	AutomationEditorWindow();
-	~AutomationEditorWindow() override;
+	~AutomationEditorWindow() override = default;
 
 	void setCurrentClip(AutomationClip* clip);
 	const AutomationClip* currentClip();

include/BandLimitedWave.h

@@ -97,8 +97,8 @@ public:
 		NumBLWaveforms
 	};
 
-	BandLimitedWave() {};
-	virtual ~BandLimitedWave() {};
+	BandLimitedWave() = default;
+	virtual ~BandLimitedWave() = default;
 
 	/*! \brief This method converts frequency to wavelength. The oscillate function takes wavelength as argument so
 	 * use this to convert your note frequency to wavelength before using it.

include/BasicFilters.h

@@ -58,7 +58,7 @@ public:
 		m_sampleRate = sampleRate;
 		clearHistory();
 	}
-	virtual ~LinkwitzRiley() {}
+	virtual ~LinkwitzRiley() = default;
 
 	inline void clearHistory()
 	{
@@ -152,7 +152,7 @@ public:
 	{
 		clearHistory();
 	}
-	virtual ~BiQuad() {}
+	virtual ~BiQuad() = default;
 	
 	inline void setCoeffs( float a1, float a2, float b0, float b1, float b2 )
 	{
@@ -200,7 +200,7 @@ public:
 			m_z1[i] = 0.0;
 		}
 	}
-	virtual ~OnePole() {}
+	virtual ~OnePole() = default;
 	
 	inline void setCoeffs( float a0, float b1 )
 	{

include/CPULoadWidget.h

@@ -43,7 +43,7 @@ class CPULoadWidget : public QWidget
 	Q_OBJECT
 public:
 	CPULoadWidget( QWidget * _parent );
-	~CPULoadWidget() override;
+	~CPULoadWidget() override = default;
 
 
 protected:

include/CaptionMenu.h

@@ -41,7 +41,7 @@ class LMMS_EXPORT CaptionMenu : public QMenu
 	Q_OBJECT
 public:
 	CaptionMenu( const QString & _title, QWidget * _parent = 0 );
-	~CaptionMenu() override;
+	~CaptionMenu() override = default;
 } ;
 
 

include/ColorChooser.h

@@ -40,7 +40,7 @@ public:
 	ColorChooser(const QColor &initial, QWidget *parent): QColorDialog(initial, parent) {};
 	ColorChooser(QWidget *parent): QColorDialog(parent) {};
 	//! For getting a color without having to initialise a color dialog
-	ColorChooser() {};
+	ColorChooser() = default;
 	enum class Palette {Default, Track, Mixer};
 	//! Set global palette via array, checking bounds
 	void setPalette (QVector<QColor>);

include/ComboBox.h

@@ -40,7 +40,7 @@ class LMMS_EXPORT ComboBox : public QWidget, public IntModelView
 	Q_OBJECT
 public:
 	ComboBox( QWidget* parent = nullptr, const QString& name = QString() );
-	~ComboBox() override;
+	~ComboBox() override = default;
 
 	ComboBoxModel* model()
 	{

include/ControllerDialog.h

@@ -44,7 +44,7 @@ class ControllerDialog : public QWidget, public ModelView
 public:
 	ControllerDialog( Controller * _controller, QWidget * _parent );
 
-	~ControllerDialog() override;
+	~ControllerDialog() override = default;
 
 
 signals:

include/ControllerRackView.h

@@ -53,7 +53,7 @@ class ControllerRackView : public QWidget, public SerializingObject
 	Q_OBJECT
 public:
 	ControllerRackView();
-	~ControllerRackView() override;
+	~ControllerRackView() override = default;
 
 	void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override;
 	void loadSettings( const QDomElement & _this ) override;

include/Controls.h

@@ -66,7 +66,7 @@ public:
 	virtual AutomatableModel* model() = 0;
 	virtual AutomatableModelView* modelView() = 0;
 
-	virtual ~Control();
+	virtual ~Control() = default;
 };
 
 
@@ -83,7 +83,7 @@ public:
 	AutomatableModelView* modelView() override;
 
 	KnobControl(QWidget* parent = nullptr);
-	~KnobControl() override;
+	~KnobControl() override = default;
 };
 
 
@@ -102,7 +102,7 @@ public:
 	AutomatableModelView* modelView() override;
 
 	ComboControl(QWidget* parent = nullptr);
-	~ComboControl() override;
+	~ComboControl() override = default;
 };
 
 
@@ -119,7 +119,7 @@ public:
 	AutomatableModelView* modelView() override;
 
 	LcdControl(int numDigits, QWidget* parent = nullptr);
-	~LcdControl() override;
+	~LcdControl() override = default;
 };
 
 
@@ -138,7 +138,7 @@ public:
 	AutomatableModelView* modelView() override;
 
 	CheckControl(QWidget* parent = nullptr);
-	~CheckControl() override;
+	~CheckControl() override = default;
 };
 
 

include/DataFile.h

@@ -67,7 +67,7 @@ public:
 	DataFile( const QByteArray& data );
 	DataFile( Type type );
 
-	virtual ~DataFile();
+	virtual ~DataFile() = default;
 
 	///
 	/// \brief validate

include/DetuningHelper.h

@@ -42,9 +42,7 @@ public:
 	{
 	}
 
-	~DetuningHelper() override
-	{
-	}
+	~DetuningHelper() override = default;
 
 	float defaultValue() const override
 	{

include/DrumSynth.h

@@ -37,7 +37,7 @@ namespace lmms
 
 class DrumSynth {
     public:
-        DrumSynth() {};
+        DrumSynth() = default;
         int GetDSFileSamples(QString dsfile, int16_t *&wave, int channels, sample_rate_t Fs);
 
     private:

include/DummyEffect.h

@@ -60,9 +60,7 @@ public:
 	{
 	}
 
-	~DummyEffectControls() override
-	{
-	}
+	~DummyEffectControls() override = default;
 
 	int controlCount() override
 	{
@@ -102,9 +100,7 @@ public:
 		setName();
 	}
 
-	~DummyEffect() override
-	{
-	}
+	~DummyEffect() override = default;
 
 	EffectControls * controls() override
 	{

include/DummyInstrument.h

@@ -47,9 +47,7 @@ public:
 	{
 	}
 
-	~DummyInstrument() override
-	{
-	}
+	~DummyInstrument() override = default;
 
 	void playNote( NotePlayHandle *, sampleFrame * buffer ) override
 	{

include/DummyPlugin.h

@@ -41,9 +41,7 @@ public:
 	{
 	}
 
-	~DummyPlugin() override
-	{
-	}
+	~DummyPlugin() override = default;
 
 	void saveSettings( QDomDocument &, QDomElement & ) override
 	{

include/Editor.h

@@ -81,7 +81,7 @@ protected:
 	/// \param	record	If set true, the editor's toolbar will contain record
 	///					buttons in addition to the play and stop buttons.
 	Editor(bool record = false, bool record_step = false);
-	~Editor() override;
+	~Editor() override = default;
 
 
 	DropToolBar* m_toolBar;

include/EffectControlDialog.h

@@ -44,7 +44,7 @@ class LMMS_EXPORT EffectControlDialog : public QWidget, public ModelView
 	Q_OBJECT
 public:
 	EffectControlDialog( EffectControls * _controls );
-	~EffectControlDialog() override;
+	~EffectControlDialog() override = default;
 
 	virtual bool isResizable() const {return false;}
 

include/EffectControls.h

@@ -51,9 +51,7 @@ public:
 	{
 	}
 
-	~EffectControls() override
-	{
-	}
+	~EffectControls() override = default;
 
 	virtual int controlCount() = 0;
 	virtual gui::EffectControlDialog * createView() = 0;

include/EnvelopeAndLfoParameters.h

@@ -50,13 +50,9 @@ public:
 	class LfoInstances
 	{
 	public:
-		LfoInstances()
-		{
-		}
+		LfoInstances() = default;
 
-		~LfoInstances()
-		{
-		}
+		~LfoInstances() = default;
 
 		inline bool isEmpty() const
 		{

include/ExportFilter.h

@@ -40,7 +40,7 @@ class LMMS_EXPORT ExportFilter : public Plugin
 {
 public:
 	ExportFilter( const Descriptor * _descriptor ) : Plugin( _descriptor, nullptr ) {}
-	~ExportFilter() override {}
+	~ExportFilter() override = default;
 
 
 	virtual bool tryExport(const TrackContainer::TrackList &tracks,

include/FadeButton.h

@@ -44,7 +44,7 @@ public:
 		const QColor & _hold_color,
 		QWidget * _parent );
 
-	~FadeButton() override;
+	~FadeButton() override = default;
 	void setActiveColor( const QColor & activated_color );
 
 

include/ImportFilter.h

@@ -42,7 +42,7 @@ class LMMS_EXPORT ImportFilter : public Plugin
 public:
 	ImportFilter( const QString & _file_name,
 					const Descriptor * _descriptor );
-	~ImportFilter() override;
+	~ImportFilter() override = default;
 
 
 	// tries to import given file to given track-container by having all

include/InstrumentFunctions.h

@@ -58,7 +58,7 @@ private:
 
 public:
 	InstrumentFunctionNoteStacking( Model * _parent );
-	~InstrumentFunctionNoteStacking() override;
+	~InstrumentFunctionNoteStacking() override = default;
 
 	void processNote( NotePlayHandle* n );
 
@@ -180,7 +180,7 @@ public:
 	} ;
 
 	InstrumentFunctionArpeggio( Model * _parent );
-	~InstrumentFunctionArpeggio() override;
+	~InstrumentFunctionArpeggio() override = default;
 
 	void processNote( NotePlayHandle* n );
 

include/InstrumentMidiIOView.h

@@ -50,7 +50,7 @@ class InstrumentMidiIOView : public QWidget, public ModelView
 	Q_OBJECT
 public:
 	InstrumentMidiIOView( QWidget* parent );
-	~InstrumentMidiIOView() override;
+	~InstrumentMidiIOView() override = default;
 
 
 private:

include/InstrumentPlayHandle.h

@@ -38,9 +38,7 @@ class LMMS_EXPORT InstrumentPlayHandle : public PlayHandle
 public:
 	InstrumentPlayHandle( Instrument * instrument, InstrumentTrack* instrumentTrack );
 
-	~InstrumentPlayHandle() override
-	{
-	}
+	~InstrumentPlayHandle() override = default;
 
 
 	void play( sampleFrame * _working_buffer ) override

include/InstrumentSoundShaping.h

@@ -46,7 +46,7 @@ class InstrumentSoundShaping : public Model, public JournallingObject
 	Q_OBJECT
 public:
 	InstrumentSoundShaping( InstrumentTrack * _instrument_track );
-	~InstrumentSoundShaping() override;
+	~InstrumentSoundShaping() override = default;
 
 	void processAudioBuffer( sampleFrame * _ab, const fpp_t _frames,
 							NotePlayHandle * _n );

include/InstrumentView.h

@@ -70,7 +70,7 @@ class LMMS_EXPORT InstrumentViewFixedSize : public InstrumentView
 
 public:
 	using InstrumentView::InstrumentView;
-	~InstrumentViewFixedSize() override;
+	~InstrumentViewFixedSize() override = default;
 } ;
 
 

include/Ladspa2LMMS.h

@@ -68,7 +68,7 @@ public:
 
 private:
 	Ladspa2LMMS();
-	~Ladspa2LMMS() override;
+	~Ladspa2LMMS() override = default;
 
 	l_sortable_plugin_t m_instruments;
 	l_sortable_plugin_t m_validEffects;

include/LadspaControl.h

@@ -52,7 +52,7 @@ class LMMS_EXPORT LadspaControl : public Model, public JournallingObject
 public:
 	LadspaControl( Model * _parent, port_desc_t * _port,
 							bool _link = false );
-	~LadspaControl() override;
+	~LadspaControl() override = default;
 
 	LADSPA_Data value();
 	ValueBuffer * valueBuffer();

include/LadspaControlView.h

@@ -43,7 +43,7 @@ class LMMS_EXPORT LadspaControlView : public QWidget, public ModelView
 	Q_OBJECT
 public:
 	LadspaControlView( QWidget * _parent, LadspaControl * _ctl );
-	~LadspaControlView() override;
+	~LadspaControlView() override = default;
 
 private:
 	LadspaControl * m_ctl;

include/LinkedModelGroupViews.h

@@ -70,7 +70,7 @@ public:
 	*/
 	LinkedModelGroupView(QWidget* parent, LinkedModelGroup* model,
 		std::size_t colNum);
-	~LinkedModelGroupView() override;
+	~LinkedModelGroupView() override = default;
 
 	//! Reconnect models if model changed
 	void modelChanged(LinkedModelGroup* linkedModelGroup);

include/LinkedModelGroups.h

@@ -155,7 +155,7 @@ private:
 class LinkedModelGroups
 {
 public:
-	virtual ~LinkedModelGroups();
+	virtual ~LinkedModelGroups() = default;
 
 	void linkAllModels();
 

include/LmmsPalette.h

@@ -50,7 +50,7 @@ class LMMS_EXPORT LmmsPalette : public QWidget
 
 public:
 	LmmsPalette( QWidget * parent, QStyle * stylearg  ); 
-	~LmmsPalette() override;
+	~LmmsPalette() override = default;
 
 #define ACCESSMET( read, write ) \
 	QColor read () const; \

include/LmmsStyle.h

@@ -66,9 +66,7 @@ public:
 	};
 
 	LmmsStyle();
-	~LmmsStyle() override
-	{
-	}
+	~LmmsStyle() override = default;
 
 	QPalette standardPalette() const override;
 

include/LocklessAllocator.h

@@ -67,9 +67,7 @@ public:
 	{
 	}
 
-	~LocklessAllocatorT() override
-	{
-	}
+	~LocklessAllocatorT() override = default;
 
 	T * alloc()
 	{

include/LocklessRingBuffer.h

@@ -46,7 +46,7 @@ public:
 	{
 		m_buffer.touch();	// reserve storage space before realtime operation starts
 	}
-	~LocklessRingBuffer() {};
+	~LocklessRingBuffer() = default;
 
 	std::size_t capacity() const {return m_buffer.maximum_eventual_write_space();}
 	std::size_t free() const {return m_buffer.write_space();}

include/Lv2Ports.h

@@ -92,7 +92,7 @@ struct ConstVisitor
 	virtual void visit(const Lv2Ports::AtomSeq& ) {}
 	virtual void visit(const Lv2Ports::Unknown& ) {}
 
-	virtual ~ConstVisitor();
+	virtual ~ConstVisitor() = default;
 };
 
 struct Visitor
@@ -104,7 +104,7 @@ struct Visitor
 	virtual void visit(Lv2Ports::AtomSeq& ) {}
 	virtual void visit(Lv2Ports::Unknown& ) {}
 
-	virtual ~Visitor();
+	virtual ~Visitor() = default;
 };
 
 struct Meta
@@ -139,7 +139,7 @@ struct PortBase : public Meta
 	QString name() const;
 	QString uri() const;
 
-	virtual ~PortBase();
+	virtual ~PortBase() = default;
 };
 
 template<typename Derived, typename Base>

include/Lv2ViewBase.h

@@ -58,7 +58,7 @@ class Lv2ViewProc : public LinkedModelGroupView
 public:
 	//! @param colNum numbers of columns for the controls
 	Lv2ViewProc(QWidget *parent, Lv2Proc *ctrlBase, int colNum);
-	~Lv2ViewProc() override;
+	~Lv2ViewProc() override = default;
 
 private:
 	static AutoLilvNode uri(const char *uriStr);

include/MeterDialog.h

@@ -41,7 +41,7 @@ class MeterDialog : public QWidget, public ModelView
 	Q_OBJECT
 public:
 	MeterDialog( QWidget * _parent, bool _simple = false );
-	~MeterDialog() override;
+	~MeterDialog() override = default;
 
 	void modelChanged() override;
 

include/MeterModel.h

@@ -31,14 +31,14 @@ namespace lmms
 {
 
 
-class MeterModel : public Model
+class LMMS_EXPORT MeterModel : public Model
 {
 	Q_OBJECT
 	mapPropertyFromModel(int,getNumerator,setNumerator,m_numeratorModel);
 	mapPropertyFromModel(int,getDenominator,setDenominator,m_denominatorModel);
 public:
 	MeterModel( Model * _parent );
-	~MeterModel() override;
+	~MeterModel() override = default;
 
 	void saveSettings( QDomDocument & _doc, QDomElement & _this,
 						const QString & _name );

include/MicroTimer.h

@@ -36,7 +36,7 @@ class MicroTimer
 
 public:
 	MicroTimer();
-	~MicroTimer();
+	~MicroTimer() = default;
 
 	void reset();
 	int elapsed() const;

include/MidiClient.h

@@ -45,7 +45,7 @@ class TimePos;
 class MidiClient
 {
 public:
-	MidiClient();
+	MidiClient() = default;
 	virtual ~MidiClient();
 
 	// to be implemented by sub-classes
@@ -124,8 +124,8 @@ const uint32_t RAW_MIDI_PARSE_BUF_SIZE = 16;
 class MidiClientRaw : public MidiClient
 {
 public:
-	MidiClientRaw();
-	~MidiClientRaw() override;
+	MidiClientRaw() = default;
+	~MidiClientRaw() override = default;
 
 	// we are raw-clients for sure!
 	bool isRaw() const override

include/MidiController.h

@@ -49,7 +49,7 @@ class MidiController : public Controller, public MidiEventProcessor
 	Q_OBJECT
 public:
 	MidiController( Model * _parent );
-	~MidiController() override;
+	~MidiController() override = default;
 
 	void processInEvent( const MidiEvent & _me,
 					const TimePos & _time, f_cnt_t offset = 0 ) override;

include/MidiDummy.h

@@ -35,12 +35,8 @@ namespace lmms
 class MidiDummy : public MidiClientRaw
 {
 public:
-	MidiDummy()
-	{
-	}
-	~MidiDummy() override
-	{
-	}
+	MidiDummy() = default;
+	~MidiDummy() override = default;
 
 	inline static QString name()
 	{

include/MidiEvent.h

@@ -66,16 +66,7 @@ public:
 		m_data.m_sysExDataLen = dataLen;
 	}
 
-	MidiEvent( const MidiEvent& other ) :
-		m_type( other.m_type ),
-		m_metaEvent( other.m_metaEvent ),
-		m_channel( other.m_channel ),
-		m_data( other.m_data ),
-		m_sysExData( other.m_sysExData ),
-		m_sourcePort(other.m_sourcePort),
-		m_source(other.m_source)
-	{
-	}
+	MidiEvent( const MidiEvent& other ) = default;
 
 	MidiEventTypes type() const
 	{

include/MidiEventProcessor.h

@@ -37,13 +37,9 @@ class MidiEventProcessor
 {
 	MM_OPERATORS
 public:
-	MidiEventProcessor()
-	{
-	}
+	MidiEventProcessor() = default;
 
-	virtual ~MidiEventProcessor()
-	{
-	}
+	virtual ~MidiEventProcessor() = default;
 
 	// to be implemented by inheriting classes
 	virtual void processInEvent( const MidiEvent& event, const TimePos& time = TimePos(), f_cnt_t offset = 0 ) = 0;

include/MidiPortMenu.h

@@ -41,7 +41,7 @@ class MidiPortMenu : public QMenu, public ModelView
 	Q_OBJECT
 public:
 	MidiPortMenu( MidiPort::Modes _mode );
-	~MidiPortMenu() override;
+	~MidiPortMenu() override = default;
 
 
 public slots:

include/Mixer.h

@@ -102,7 +102,7 @@ class MixerRoute : public QObject
 	Q_OBJECT
 	public:		
 		MixerRoute( MixerChannel * from, MixerChannel * to, float amount );
-		~MixerRoute() override;
+		~MixerRoute() override = default;
 		
 	mix_ch_t senderIndex() const
 	{

include/MixerLineLcdSpinBox.h

@@ -41,7 +41,7 @@ public:
 	MixerLineLcdSpinBox(int numDigits, QWidget * parent, const QString& name, TrackView * tv = nullptr) :
 		LcdSpinBox(numDigits, parent, name), m_tv(tv)
 	{}
-	~MixerLineLcdSpinBox() override {}
+	~MixerLineLcdSpinBox() override = default;
 
 	void setTrackView(TrackView * tv);
 

include/Model.h

@@ -45,9 +45,7 @@ public:
 	{
 	}
 
-	~Model() override
-	{
-	}
+	~Model() override = default;
 
 	bool isDefaultConstructed()
 	{

include/ModelVisitor.h

@@ -47,7 +47,7 @@ public:
 	virtual void visit(FloatModel& m);
 	virtual void visit(ComboBoxModel& m);
 	virtual void visit(TempoSyncKnobModel& m);
-	virtual ~ModelVisitor();
+	virtual ~ModelVisitor() = default;
 };
 
 class ConstModelVisitor
@@ -62,7 +62,7 @@ public:
 	virtual void visit(const FloatModel& m);
 	virtual void visit(const ComboBoxModel& m);
 	virtual void visit(const TempoSyncKnobModel& m);
-	virtual ~ConstModelVisitor();
+	virtual ~ConstModelVisitor() = default;
 };
 
 

include/PatternEditor.h

@@ -80,7 +80,7 @@ class PatternEditorWindow : public Editor
 Q_OBJECT
 public:
 	PatternEditorWindow(PatternStore* ps);
-	~PatternEditorWindow();
+	~PatternEditorWindow() = default;
 
 	QSize sizeHint() const override;
 

include/PatternStore.h

@@ -68,7 +68,7 @@ class LMMS_EXPORT PatternStore : public TrackContainer
 	mapPropertyFromModel(int, currentPattern, setCurrentPattern, m_patternComboBoxModel);
 public:
 	PatternStore();
-	~PatternStore() override;
+	~PatternStore() override = default;
 
 	virtual bool play(TimePos start, const fpp_t frames, const f_cnt_t frameBase, int clipNum = -1);
 

include/PeakController.h

@@ -92,7 +92,7 @@ class PeakControllerDialog : public ControllerDialog
 	Q_OBJECT
 public:
 	PeakControllerDialog( Controller * _controller, QWidget * _parent );
-	~PeakControllerDialog() override;
+	~PeakControllerDialog() override = default;
 
 protected:
 	void contextMenuEvent( QContextMenuEvent * _me ) override;

include/PianoRoll.h

@@ -298,7 +298,7 @@ private:
 
 	PianoRoll();
 	PianoRoll( const PianoRoll & );
-	~PianoRoll() override;
+	~PianoRoll() override = default;
 
 	void autoScroll(const TimePos & t );
 

include/PixmapButton.h

@@ -40,7 +40,7 @@ class LMMS_EXPORT PixmapButton : public AutomatableButton
 public:
 	PixmapButton( QWidget * _parent,
 					const QString & _name = QString() );
-	~PixmapButton() override;
+	~PixmapButton() override = default;
 
 	void setActiveGraphic( const QPixmap & _pm );
 	void setInactiveGraphic( const QPixmap & _pm, bool _update = true );

include/Plugin.h

@@ -187,9 +187,7 @@ public:
 			{
 			}
 
-			virtual ~SubPluginFeatures()
-			{
-			}
+			virtual ~SubPluginFeatures() = default;
 
 			virtual void fillDescriptionWidget( QWidget *, const Key * ) const
 			{
@@ -244,7 +242,7 @@ public:
 	//!   See the key() function
 	Plugin(const Descriptor * descriptor, Model * parent,
 		const Descriptor::SubPluginFeatures::Key *key = nullptr);
-	~Plugin() override;
+	~Plugin() override = default;
 
 	//! Return display-name out of sub plugin or descriptor
 	QString displayName() const override;

include/PluginFactory.h

@@ -57,7 +57,7 @@ public:
 	typedef QMultiMap<Plugin::PluginTypes, Plugin::Descriptor*> DescriptorMap;
 
 	PluginFactory();
-	~PluginFactory();
+	~PluginFactory() = default;
 
 	static void setupSearchPaths();
 

include/ProjectJournal.h

@@ -46,7 +46,7 @@ public:
 	static const int MAX_UNDO_STATES;
 
 	ProjectJournal();
-	virtual ~ProjectJournal();
+	virtual ~ProjectJournal() = default;
 
 	void undo();
 	void redo();

include/ProjectNotes.h

@@ -44,7 +44,7 @@ class LMMS_EXPORT ProjectNotes : public QMainWindow, public SerializingObject
 	Q_OBJECT
 public:
 	ProjectNotes();
-	~ProjectNotes() override;
+	~ProjectNotes() override = default;
 
 	void clear();
 	void setText( const QString & _text );

include/ProjectRenderer.h

@@ -64,7 +64,7 @@ public:
 				const OutputSettings & _os,
 				ExportFileFormats _file_format,
 				const QString & _out_file );
-	~ProjectRenderer() override;
+	~ProjectRenderer() override = default;
 
 	bool isReady() const
 	{

include/RemotePluginBase.h

@@ -390,11 +390,7 @@ public:
 		{
 		}
 
-		message( const message & _m ) :
-			id( _m.id ),
-			data( _m.data )
-		{
-		}
+		message( const message & _m ) = default;
 
 		message( int _id ) :
 			id( _id ),

include/RenameDialog.h

@@ -40,7 +40,7 @@ class RenameDialog : public QDialog
 	Q_OBJECT
 public:
 	RenameDialog( QString & _string );
-	~RenameDialog() override;
+	~RenameDialog() override = default;
 
 
 protected:

include/Rubberband.h

@@ -44,9 +44,7 @@ public:
 	{
 	}
 
-	~selectableObject() override
-	{
-	}
+	~selectableObject() override = default;
 
 	inline void setSelected(bool selected)
 	{
@@ -80,7 +78,7 @@ class RubberBand : public QRubberBand
 {
 public:
 	RubberBand( QWidget * _parent );
-	~RubberBand() override;
+	~RubberBand() override = default;
 
 	QVector<selectableObject *> selectedObjects() const;
 	QVector<selectableObject *> selectableObjects() const;

include/SampleTrackWindow.h

@@ -50,7 +50,7 @@ class SampleTrackWindow : public QWidget, public ModelView, public SerializingOb
 	Q_OBJECT
 public:
 	SampleTrackWindow(SampleTrackView * tv);
-	~SampleTrackWindow() override;
+	~SampleTrackWindow() override = default;
 
 	SampleTrack * model()
 	{

include/SideBar.h

@@ -42,7 +42,7 @@ class SideBar : public QToolBar
 	Q_OBJECT
 public:
 	SideBar( Qt::Orientation _orientation, QWidget * _parent );
-	~SideBar() override;
+	~SideBar() override = default;
 
 	void appendTab( SideBarWidget * _sbw );
 

include/SideBarWidget.h

@@ -41,7 +41,7 @@ class SideBarWidget : public QWidget
 public:
 	SideBarWidget( const QString & _title, const QPixmap & _icon,
 							QWidget * _parent );
-	~SideBarWidget() override;
+	~SideBarWidget() override = default;
 
 	inline const QPixmap & icon() const
 	{

include/SongEditor.h

@@ -66,7 +66,7 @@ public:
 	};
 
 	SongEditor( Song * song );
-	~SongEditor() override;
+	~SongEditor() override = default;
 
 	void saveSettings( QDomDocument& doc, QDomElement& element ) override;
 	void loadSettings( const QDomElement& element ) override;

include/SweepOscillator.h

@@ -41,9 +41,7 @@ public:
 	{
 	}
 
-	virtual ~SweepOscillator()
-	{
-	}
+	virtual ~SweepOscillator() = default;
 
 	void update( sampleFrame* buf, const fpp_t frames, const float freq1, const float freq2, const float sampleRate )
 	{

include/TabButton.h

@@ -45,9 +45,7 @@ public:
 						SLOT( slotClicked() ) );
 	}
 
-	~TabButton() override
-	{
-	}
+	~TabButton() override = default;
 
 
 signals:

include/TempoSyncKnobModel.h

@@ -63,7 +63,7 @@ public:
 				const float _max, const float _step,
 				const float _scale, Model * _parent,
 				const QString & _display_name = QString() );
-	~TempoSyncKnobModel() override;
+	~TempoSyncKnobModel() override = default;
 
 	void saveSettings( QDomDocument & _doc, QDomElement & _this, const QString& name ) override;
 	void loadSettings( const QDomElement & _this, const QString& name ) override;

include/TextFloat.h

@@ -39,9 +39,7 @@ class LMMS_EXPORT TextFloat : public QWidget
 	Q_OBJECT
 public:
 	TextFloat();
-	~TextFloat() override
-	{
-	}
+	~TextFloat() override = default;
 
 	void setTitle( const QString & _title );
 	void setText( const QString & _text );

include/ToolPlugin.h

@@ -38,7 +38,7 @@ class LMMS_EXPORT ToolPlugin : public Plugin
 {
 public:
 	ToolPlugin( const Descriptor * _descriptor, Model * _parent );
-	~ToolPlugin() override;
+	~ToolPlugin() override = default;
 
 	// instantiate tool-plugin with given name or return NULL
 	// on failure

include/TrackContainerView.h

@@ -184,7 +184,7 @@ private:
 	{
 	public:
 		scrollArea( TrackContainerView* parent );
-		~scrollArea() override;
+		~scrollArea() override = default;
 
 	protected:
 		void wheelEvent( QWheelEvent * _we ) override;

include/TrackContentWidget.h

@@ -56,7 +56,7 @@ class TrackContentWidget : public QWidget, public JournallingObject
 
 public:
 	TrackContentWidget( TrackView * parent );
-	~TrackContentWidget() override;
+	~TrackContentWidget() override = default;
 
 	/*! \brief Updates the background tile pixmap. */
 	void updateBackground();

include/TrackLabelButton.h

@@ -41,7 +41,7 @@ class TrackLabelButton : public QToolButton
 	Q_OBJECT
 public:
 	TrackLabelButton( TrackView * _tv, QWidget * _parent );
-	~TrackLabelButton() override;
+	~TrackLabelButton() override = default;
 
 
 public slots:

include/TrackOperationsWidget.h

@@ -40,7 +40,7 @@ class TrackOperationsWidget : public QWidget
 	Q_OBJECT
 public:
 	TrackOperationsWidget( TrackView * parent );
-	~TrackOperationsWidget() override;
+	~TrackOperationsWidget() override = default;
 
 
 protected:

include/TrackView.h

@@ -64,7 +64,7 @@ class TrackView : public QWidget, public ModelView, public JournallingObject
 	Q_OBJECT
 public:
 	TrackView( Track * _track, TrackContainerView* tcv );
-	~TrackView() override;
+	~TrackView() override = default;
 
 	inline const Track * getTrack() const
 	{

include/ValueBuffer.h

@@ -39,7 +39,7 @@ class LMMS_EXPORT ValueBuffer : public std::vector<float>
 {
 	MM_OPERATORS
 public:
-	ValueBuffer();
+	ValueBuffer() = default;
 	ValueBuffer(int length);
 
 	void fill(float value);

include/embed.h

@@ -96,9 +96,7 @@ public:
 		return( QPixmap() );
 	}
 
-	virtual ~PixmapLoader()
-	{
-	}
+	virtual ~PixmapLoader() = default;
 
 	virtual QString pixmapName() const
 	{

include/shared_object.h

@@ -39,9 +39,7 @@ public:
 	{
 	}
 
-	virtual ~sharedObject()
-	{
-	}
+	virtual ~sharedObject() = default;
 
 	template<class T>
 	static T* ref( T* object )

plugins/Amplifier/Amplifier.cpp

@@ -60,9 +60,6 @@ AmplifierEffect::AmplifierEffect( Model* parent, const Descriptor::SubPluginFeat
 
 
 
-AmplifierEffect::~AmplifierEffect()
-{
-}
 
 
 

plugins/Amplifier/Amplifier.h

@@ -37,7 +37,7 @@ class AmplifierEffect : public Effect
 {
 public:
 	AmplifierEffect( Model* parent, const Descriptor::SubPluginFeatures::Key* key );
-	~AmplifierEffect() override;
+	~AmplifierEffect() override = default;
 	bool processAudioBuffer( sampleFrame* buf, const fpp_t frames ) override;
 
 	EffectControls* controls() override

plugins/Amplifier/AmplifierControlDialog.h

@@ -42,9 +42,7 @@ class AmplifierControlDialog : public EffectControlDialog
 	Q_OBJECT
 public:
 	AmplifierControlDialog( AmplifierControls* controls );
-	~AmplifierControlDialog() override
-	{
-	}
+	~AmplifierControlDialog() override = default;
 
 } ;
 

plugins/Amplifier/AmplifierControls.h

@@ -45,9 +45,7 @@ class AmplifierControls : public EffectControls
 	Q_OBJECT
 public:
 	AmplifierControls( AmplifierEffect* effect );
-	~AmplifierControls() override
-	{
-	}
+	~AmplifierControls() override = default;
 
 	void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override;
 	void loadSettings( const QDomElement & _this ) override;

plugins/AudioFileProcessor/AudioFileProcessor.cpp

@@ -559,9 +559,6 @@ AudioFileProcessorView::AudioFileProcessorView( Instrument * _instrument,
 
 
 
-AudioFileProcessorView::~AudioFileProcessorView()
-{
-}
 
 
 

plugins/AudioFileProcessor/AudioFileProcessor.h

@@ -130,7 +130,7 @@ class AudioFileProcessorView : public gui::InstrumentViewFixedSize
 	Q_OBJECT
 public:
 	AudioFileProcessorView( Instrument * _instrument, QWidget * _parent );
-	virtual ~AudioFileProcessorView();
+	virtual ~AudioFileProcessorView() = default;
 
 	void newWaveView();
 protected slots:

plugins/BassBooster/BassBooster.cpp

@@ -65,9 +65,6 @@ BassBoosterEffect::BassBoosterEffect( Model* parent, const Descriptor::SubPlugin
 
 
 
-BassBoosterEffect::~BassBoosterEffect()
-{
-}
 
 
 

plugins/BassBooster/BassBooster.h

@@ -37,7 +37,7 @@ class BassBoosterEffect : public Effect
 {
 public:
 	BassBoosterEffect( Model* parent, const Descriptor::SubPluginFeatures::Key* key );
-	~BassBoosterEffect() override;
+	~BassBoosterEffect() override = default;
 	bool processAudioBuffer( sampleFrame* buf, const fpp_t frames ) override;
 
 	EffectControls* controls() override

plugins/BassBooster/BassBoosterControlDialog.h

@@ -40,9 +40,7 @@ class BassBoosterControlDialog : public EffectControlDialog
 	Q_OBJECT
 public:
 	BassBoosterControlDialog( BassBoosterControls* controls );
-	~BassBoosterControlDialog() override
-	{
-	}
+	~BassBoosterControlDialog() override = default;
 
 } ;