clang-tidy: Apply modernize-use-equals-default everywhere (#6450)

This commit is contained in:
Levin Oehlmann
2022-06-26 08:48:24 +02:00
committed by GitHub
parent 95843759cc
commit 28ec71f91a
275 changed files with 223 additions and 1034 deletions

View File

@@ -177,8 +177,7 @@ private:
#endif
SharedMemoryData::SharedMemoryData() noexcept
{ }
SharedMemoryData::SharedMemoryData() noexcept = default;
SharedMemoryData::SharedMemoryData(std::string&& key, bool readOnly) :
m_key{std::move(key)},
@@ -192,7 +191,7 @@ SharedMemoryData::SharedMemoryData(std::string&& key, std::size_t size, bool rea
m_ptr{m_impl->get()}
{ }
SharedMemoryData::~SharedMemoryData() { }
SharedMemoryData::~SharedMemoryData() = default;
SharedMemoryData::SharedMemoryData(SharedMemoryData&& other) noexcept :
m_key{std::move(other.m_key)},

View File

@@ -36,11 +36,6 @@ AudioEngineProfiler::AudioEngineProfiler() :
AudioEngineProfiler::~AudioEngineProfiler()
{
}
void AudioEngineProfiler::finishPeriod( sample_rate_t sampleRate, fpp_t framesPerPeriod )
{
int periodElapsed = m_periodTimer.elapsed();

View File

@@ -176,12 +176,6 @@ DataFile::DataFile( const QByteArray & _data ) :
DataFile::~DataFile()
{
}
bool DataFile::validate( QString extension )
{

View File

@@ -48,12 +48,6 @@ ImportFilter::ImportFilter( const QString & _file_name,
ImportFilter::~ImportFilter()
{
}
void ImportFilter::import( const QString & _file_to_import,
TrackContainer* tc )

View File

@@ -221,10 +221,6 @@ InstrumentFunctionNoteStacking::InstrumentFunctionNoteStacking( Model * _parent
InstrumentFunctionNoteStacking::~InstrumentFunctionNoteStacking()
{
}
@@ -334,11 +330,6 @@ InstrumentFunctionArpeggio::InstrumentFunctionArpeggio( Model * _parent ) :
InstrumentFunctionArpeggio::~InstrumentFunctionArpeggio()
{
}
void InstrumentFunctionArpeggio::processNote( NotePlayHandle * _n )

View File

@@ -107,11 +107,6 @@ InstrumentSoundShaping::InstrumentSoundShaping(
InstrumentSoundShaping::~InstrumentSoundShaping()
{
}
float InstrumentSoundShaping::volumeLevel( NotePlayHandle* n, const f_cnt_t frame )

View File

@@ -82,12 +82,6 @@ Ladspa2LMMS::Ladspa2LMMS()
Ladspa2LMMS::~Ladspa2LMMS()
{
}
QString Ladspa2LMMS::getShortName( const ladspa_key_t & _key )
{
QString name = getName( _key );

View File

@@ -112,13 +112,6 @@ LadspaControl::LadspaControl( Model * _parent, port_desc_t * _port,
LadspaControl::~LadspaControl()
{
}
LADSPA_Data LadspaControl::value()
{
switch( m_port->data_type )

View File

@@ -140,11 +140,6 @@ bool LinkedModelGroup::containsModel(const QString &name) const
LinkedModelGroups::~LinkedModelGroups() {}
void LinkedModelGroups::linkAllModels()
{
LinkedModelGroup* first = getGroup(0);

View File

@@ -42,15 +42,6 @@ MeterModel::MeterModel( Model * _parent ) :
}
MeterModel::~MeterModel()
{
}
void MeterModel::reset()
{
m_numeratorModel.setValue( 4 );

View File

@@ -14,10 +14,6 @@ MicroTimer::MicroTimer()
reset();
}
MicroTimer::~MicroTimer()
{
}
void MicroTimer::reset()
{
begin = steady_clock::now();

View File

@@ -51,11 +51,6 @@ MixerRoute::MixerRoute( MixerChannel * from, MixerChannel * to, float amount ) :
}
MixerRoute::~MixerRoute()
{
}
void MixerRoute::updateName()
{
m_amount.setDisplayName(

View File

@@ -44,8 +44,4 @@ void ConstModelVisitor::visit(const FloatModel &m) { up(m); }
void ConstModelVisitor::visit(const ComboBoxModel &m) { up<IntModel>(m); }
void ConstModelVisitor::visit(const TempoSyncKnobModel &m) { up<FloatModel>(m); }
ModelVisitor::~ModelVisitor() {}
ConstModelVisitor::~ConstModelVisitor() {}
} // namespace lmms

View File

@@ -50,13 +50,6 @@ PatternStore::PatternStore() :
PatternStore::~PatternStore()
{
}
bool PatternStore::play(TimePos start, fpp_t frames, f_cnt_t offset, int clipNum)
{
bool notePlayed = false;

View File

@@ -74,13 +74,6 @@ Plugin::Plugin(const Descriptor * descriptor, Model * parent, const
Plugin::~Plugin()
{
}
template<class T>
T use_this_or(T this_param, T or_param)
{

View File

@@ -58,10 +58,6 @@ PluginFactory::PluginFactory()
discoverPlugins();
}
PluginFactory::~PluginFactory()
{
}
void PluginFactory::setupSearchPaths()
{
// Adds a search path relative to the main executable if the path exists.

View File

@@ -53,9 +53,7 @@ public:
m_previewInstrumentTrack->setPreviewMode( true );
}
~PreviewTrackContainer() override
{
}
~PreviewTrackContainer() override = default;
QString nodeName() const override
{

View File

@@ -49,13 +49,6 @@ ProjectJournal::ProjectJournal() :
ProjectJournal::~ProjectJournal()
{
}
void ProjectJournal::undo()
{
while( !m_undoCheckPoints.isEmpty() )

View File

@@ -108,13 +108,6 @@ ProjectRenderer::ProjectRenderer( const AudioEngine::qualitySettings & qualitySe
ProjectRenderer::~ProjectRenderer()
{
}
// Little help function for getting file format from a file extension
// (only for registered file-encoders).
ProjectRenderer::ExportFileFormats ProjectRenderer::getFileFormatFromExtension(

View File

@@ -53,13 +53,6 @@ TempoSyncKnobModel::TempoSyncKnobModel( const float _val, const float _min,
TempoSyncKnobModel::~TempoSyncKnobModel()
{
}
void TempoSyncKnobModel::setTempoSync( QAction * _item )
{
setTempoSync( _item->data().toInt() );

View File

@@ -38,13 +38,6 @@ ToolPlugin::ToolPlugin( const Descriptor * _descriptor, Model * _parent ) :
ToolPlugin::~ToolPlugin()
{
}
ToolPlugin * ToolPlugin::instantiate( const QString & _plugin_name, Model * _parent )
{
Plugin * p = Plugin::instantiate( _plugin_name, _parent, nullptr );

View File

@@ -6,9 +6,6 @@ namespace lmms
{
ValueBuffer::ValueBuffer()
{}
ValueBuffer::ValueBuffer(int length)
: std::vector<float>(length)
{}

View File

@@ -340,13 +340,6 @@ AudioSdl::setupWidget::setupWidget( QWidget * _parent ) :
AudioSdl::setupWidget::~setupWidget()
{
}
void AudioSdl::setupWidget::saveSettings()
{
ConfigManager::inst()->setValue( "audiosdl", "device",

View File

@@ -204,12 +204,6 @@ AudioSndio::setupWidget::setupWidget( QWidget * _parent ) :
}
AudioSndio::setupWidget::~setupWidget()
{
}
void AudioSndio::setupWidget::saveSettings()
{
ConfigManager::inst()->setValue( "audiosndio", "device",

View File

@@ -345,10 +345,6 @@ void AudioSoundIo::writeCallback(int frameCountMin, int frameCountMax)
}
}
AudioSoundIoSetupUtil::~AudioSoundIoSetupUtil()
{
}
void AudioSoundIoSetupUtil::reconnectSoundIo()
{
((AudioSoundIo::setupWidget *)m_setupWidget)->reconnectSoundIo();

View File

@@ -89,7 +89,7 @@ Lv2ControlBase::Lv2ControlBase(Model* that, const QString &uri) :
Lv2ControlBase::~Lv2ControlBase() {}
Lv2ControlBase::~Lv2ControlBase() = default;

View File

@@ -352,15 +352,6 @@ void AtomSeq::Lv2EvbufDeleter::operator()(LV2_Evbuf *n) { lv2_evbuf_free(n); }
// make the compiler happy, give each class with virtuals
// a function (the destructor here) which is in a cpp file
PortBase::~PortBase() {}
ConstVisitor::~ConstVisitor() {}
Visitor::~Visitor() {}
} // namespace lmms::Lv2Ports
#endif // LMMS_HAVE_LV2

View File

@@ -756,11 +756,9 @@ struct ConnectPortVisitor : public Lv2Ports::Visitor
connectPort((audio.mustBeUsed()) ? audio.m_buffer.data() : nullptr);
}
void visit(Lv2Ports::Unknown&) override { connectPort(nullptr); }
~ConnectPortVisitor() override;
~ConnectPortVisitor() override = default;
};
ConnectPortVisitor::~ConnectPortVisitor() {}
// !This function must be realtime safe!
// use createPort to create any port before connecting
void Lv2Proc::connectPort(std::size_t num)

View File

@@ -30,13 +30,6 @@
namespace lmms
{
MidiClient::MidiClient()
{
}
MidiClient::~MidiClient()
{
//TODO: noteOffAll(); / clear all ports
@@ -106,20 +99,6 @@ void MidiClient::subscribeWritablePort( MidiPort* , const QString& , bool )
MidiClientRaw::MidiClientRaw()
{
}
MidiClientRaw::~MidiClientRaw()
{
}
void MidiClientRaw::parseData( const unsigned char c )
{
/*********************************************************************/

View File

@@ -47,13 +47,6 @@ MidiController::MidiController( Model * _parent ) :
MidiController::~MidiController()
{
}
void MidiController::updateValueBuffer()
{
if( m_previousValue != m_lastValue )

View File

@@ -32,10 +32,6 @@ AudioDeviceSetupWidget::AudioDeviceSetupWidget(const QString & caption, QWidget
{
}
AudioDeviceSetupWidget::~AudioDeviceSetupWidget()
{
}
void AudioDeviceSetupWidget::show()
{
parentWidget()->show();

View File

@@ -41,12 +41,6 @@ ControllerDialog::ControllerDialog( Controller * _controller,
ControllerDialog::~ControllerDialog()
{
}
void ControllerDialog::closeEvent( QCloseEvent * _ce )
{
_ce->ignore();

View File

@@ -93,13 +93,6 @@ ControllerRackView::ControllerRackView() :
ControllerRackView::~ControllerRackView()
{
}
void ControllerRackView::saveSettings( QDomDocument & _doc,
QDomElement & _this )
{

View File

@@ -38,11 +38,6 @@ namespace lmms::gui
{
Control::~Control() {}
void KnobControl::setText(const QString &text) { m_knob->setLabel(text); }
QWidget *KnobControl::topWidget() { return m_knob; }
@@ -59,10 +54,6 @@ AutomatableModelView* KnobControl::modelView() { return m_knob; }
KnobControl::KnobControl(QWidget *parent) :
m_knob(new Knob(parent)) {}
KnobControl::~KnobControl() {}
void ComboControl::setText(const QString &text) { m_label->setText(text); }
@@ -87,9 +78,6 @@ ComboControl::ComboControl(QWidget *parent) :
m_combo->repaint();
}
ComboControl::~ComboControl() {}
void CheckControl::setText(const QString &text) { m_label->setText(text); }
@@ -115,8 +103,6 @@ CheckControl::CheckControl(QWidget *parent) :
vbox->addWidget(m_label);
}
CheckControl::~CheckControl() {}
@@ -138,7 +124,5 @@ LcdControl::LcdControl(int numDigits, QWidget *parent) :
{
}
LcdControl::~LcdControl() {}
} // namespace lmms::gui

View File

@@ -44,13 +44,6 @@ EffectControlDialog::EffectControlDialog( EffectControls * _controls ) :
EffectControlDialog::~EffectControlDialog()
{
}
void EffectControlDialog::closeEvent( QCloseEvent * _ce )
{
_ce->ignore();

View File

@@ -121,10 +121,4 @@ LadspaControlView::LadspaControlView( QWidget * _parent,
LadspaControlView::~LadspaControlView()
{
}
} // namespace lmms::gui

View File

@@ -55,11 +55,6 @@ LinkedModelGroupView::LinkedModelGroupView(QWidget* parent,
LinkedModelGroupView::~LinkedModelGroupView() {}
void LinkedModelGroupView::modelChanged(LinkedModelGroup *group)
{
// reconnect models

View File

@@ -52,10 +52,6 @@ LmmsPalette::LmmsPalette( QWidget * parent, QStyle * stylearg ) :
ensurePolished();
}
LmmsPalette::~LmmsPalette()
{
}
#define ACCESSMET( read, write ) \
QColor LmmsPalette:: read () const \
{ return m_##read ; } \

View File

@@ -126,11 +126,6 @@ Lv2ViewProc::Lv2ViewProc(QWidget* parent, Lv2Proc* ctrlBase, int colNum) :
Lv2ViewProc::~Lv2ViewProc() {}
AutoLilvNode Lv2ViewProc::uri(const char *uriStr)
{
return Engine::getLv2Manager()->uri(uriStr);

View File

@@ -113,7 +113,7 @@ MixerView::MixerView() :
public:
ChannelArea( QWidget * parent, MixerView * mv ) :
QScrollArea( parent ), m_mv( mv ) {}
~ChannelArea() override {}
~ChannelArea() override = default;
void keyPressEvent( QKeyEvent * e ) override
{
m_mv->keyPressEvent( e );

View File

@@ -55,12 +55,6 @@ PeakControllerDialog::PeakControllerDialog( Controller * _model, QWidget * _pare
PeakControllerDialog::~PeakControllerDialog()
{
}
/*
void effectView::closeEffects()
{

View File

@@ -84,13 +84,6 @@ ProjectNotes::ProjectNotes() :
ProjectNotes::~ProjectNotes()
{
}
void ProjectNotes::clear()
{
m_edit->setHtml( tr( "Enter project notes here" ) );

View File

@@ -163,11 +163,6 @@ SampleTrackWindow::SampleTrackWindow(SampleTrackView * tv) :
subWin->hide();
}
SampleTrackWindow::~SampleTrackWindow()
{
}
void SampleTrackWindow::setSampleTrackView(SampleTrackView* tv)
{

View File

@@ -101,13 +101,6 @@ SideBar::SideBar( Qt::Orientation _orientation, QWidget * _parent ) :
SideBar::~SideBar()
{
}
void SideBar::appendTab( SideBarWidget *widget )
{
SideBarButton *button = new SideBarButton( orientation(), this );

View File

@@ -55,13 +55,6 @@ SideBarWidget::SideBarWidget( const QString & _title, const QPixmap & _icon,
SideBarWidget::~SideBarWidget()
{
}
void SideBarWidget::paintEvent( QPaintEvent * )
{
QPainter p( this );

View File

@@ -71,13 +71,6 @@ AutomationClipView::AutomationClipView( AutomationClip * _clip,
AutomationClipView::~AutomationClipView()
{
}
void AutomationClipView::openInAutomationEditor()
{
if(getGUI() != nullptr)

View File

@@ -1967,11 +1967,6 @@ AutomationEditorWindow::AutomationEditorWindow() :
}
AutomationEditorWindow::~AutomationEditorWindow()
{
}
void AutomationEditorWindow::setCurrentClip(AutomationClip* clip)
{
// Disconnect our old clip

View File

@@ -133,11 +133,6 @@ Editor::Editor(bool record, bool stepRecord) :
addButton(m_stopAction, "stopButton");
}
Editor::~Editor()
{
}
QAction *Editor::playAction() const
{
return m_playAction;

View File

@@ -301,11 +301,6 @@ PatternEditorWindow::PatternEditorWindow(PatternStore* ps) :
}
PatternEditorWindow::~PatternEditorWindow()
{
}
QSize PatternEditorWindow::sizeHint() const
{
return {minimumWidth() + 10, 300};

View File

@@ -625,11 +625,6 @@ void PianoRoll::markSemiTone(int i, bool fromMenu)
}
PianoRoll::~PianoRoll()
{
}
void PianoRoll::setGhostMidiClip( MidiClip* newMidiClip )
{
// Expects a pointer to a MIDI clip or nullptr.

View File

@@ -38,13 +38,6 @@ RubberBand::RubberBand( QWidget * _parent ) :
RubberBand::~RubberBand()
{
}
QVector<selectableObject *> RubberBand::selectedObjects() const
{
QVector<selectableObject *> so = selectableObjects();

View File

@@ -277,10 +277,6 @@ SongEditor::SongEditor( Song * song ) :
SongEditor::~SongEditor()
{
}
void SongEditor::saveSettings( QDomDocument& doc, QDomElement& element )
{
MainWindow::saveWidgetState( parentWidget(), element );

View File

@@ -487,13 +487,6 @@ TrackContainerView::scrollArea::scrollArea( TrackContainerView * _parent ) :
TrackContainerView::scrollArea::~scrollArea()
{
}
void TrackContainerView::scrollArea::wheelEvent( QWheelEvent * _we )
{
// always pass wheel-event to parent-widget (song-editor

View File

@@ -171,12 +171,6 @@ InstrumentMidiIOView::InstrumentMidiIOView( QWidget* parent ) :
InstrumentMidiIOView::~InstrumentMidiIOView()
{
}
void InstrumentMidiIOView::modelChanged()
{

View File

@@ -75,9 +75,5 @@ InstrumentTrackWindow * InstrumentView::instrumentTrackWindow()
InstrumentViewFixedSize::~InstrumentViewFixedSize()
{
}
} // namespace lmms::gui

View File

@@ -42,12 +42,6 @@ MidiPortMenu::MidiPortMenu( MidiPort::Modes _mode ) :
MidiPortMenu::~MidiPortMenu()
{
}
void MidiPortMenu::modelChanged()
{

View File

@@ -60,9 +60,7 @@ public:
}
~AutoDetectMidiController() override
{
}
~AutoDetectMidiController() override = default;
void processInEvent( const MidiEvent& event, const TimePos& time, f_cnt_t offset = 0 ) override

View File

@@ -52,12 +52,6 @@ RenameDialog::RenameDialog( QString & _string ) :
RenameDialog::~RenameDialog()
{
}
void RenameDialog::resizeEvent (QResizeEvent * event) {
m_stringLE->setGeometry ( 10, 5, width() - 20, 20 );

View File

@@ -55,11 +55,6 @@ FadeButton::FadeButton(const QColor & _normal_color,
FadeButton::~FadeButton()
{
}
void FadeButton::setActiveColor(const QColor & activated_color)
{
m_activatedColor = activated_color;

View File

@@ -82,14 +82,6 @@ TrackContentWidget::TrackContentWidget( TrackView * parent ) :
/*! \brief Destroy this trackContentWidget
*
* Destroys the trackContentWidget.
*/
TrackContentWidget::~TrackContentWidget()
{
}

View File

@@ -73,11 +73,6 @@ TrackLabelButton::TrackLabelButton( TrackView * _tv, QWidget * _parent ) :
TrackLabelButton::~TrackLabelButton()
{
}
void TrackLabelButton::rename()

View File

@@ -120,13 +120,6 @@ TrackOperationsWidget::TrackOperationsWidget( TrackView * parent ) :
/*! \brief Destroy an existing trackOperationsWidget
*
*/
TrackOperationsWidget::~TrackOperationsWidget()
{
}

View File

@@ -115,12 +115,6 @@ TrackView::TrackView( Track * track, TrackContainerView * tcv ) :
/*! \brief Destroy this track View.
*
*/
TrackView::~TrackView()
{
}

View File

@@ -51,10 +51,6 @@ AutomatableSlider::AutomatableSlider( QWidget * _parent,
AutomatableSlider::~AutomatableSlider()
{
}

View File

@@ -59,10 +59,6 @@ CPULoadWidget::CPULoadWidget( QWidget * _parent ) :
CPULoadWidget::~CPULoadWidget()
{
}

View File

@@ -40,9 +40,5 @@ CaptionMenu::CaptionMenu( const QString & _title, QWidget * _parent ) :
CaptionMenu::~CaptionMenu()
{
}
} // namespace lmms::gui

View File

@@ -82,10 +82,6 @@ ComboBox::ComboBox( QWidget * _parent, const QString & _name ) :
ComboBox::~ComboBox()
{
}
void ComboBox::selectNext()

View File

@@ -103,10 +103,6 @@ MeterDialog::MeterDialog( QWidget * _parent, bool _simple ) :
MeterDialog::~MeterDialog()
{
}

View File

@@ -47,10 +47,6 @@ PixmapButton::PixmapButton( QWidget * _parent, const QString & _name ) :
PixmapButton::~PixmapButton()
{
}