hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Jack: Remove channel number configuration

Browse Source 
Remove the reading and saving of the channel number configuration in several places as it will default to `DEFAULT_CHANNELS` all the time anyway.

Remove the LCD spin box which does not allow to make any changes to the channel numbers anyway.
This commit is contained in:
Michael Gregorius
2025-05-01 18:48:24 +02:00
parent ecd6a63a0f
commit 3ab8cc5a4c
2 changed files with 1 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
include/AudioJack.h
View File

@@ -53,11 +53,6 @@ namespace lmms
class MidiJack;
namespace gui
{
class LcdSpinBox;
}
class AudioJack : public QObject, public AudioDevice
{
@@ -88,7 +83,6 @@ public:
private:
QLineEdit* m_clientName;
gui::LcdSpinBox* m_channels;
};
private slots:

20
src/core/audio/AudioJack.cpp
View File

@@ -44,13 +44,7 @@ namespace lmms
AudioJack::AudioJack(bool& successful, AudioEngine* audioEngineParam)
: AudioDevice(
// clang-format off
std::clamp<int>(
ConfigManager::inst()->value("audiojack", "channels").toInt(),
DEFAULT_CHANNELS,
DEFAULT_CHANNELS
),
// clang-format on
DEFAULT_CHANNELS,
audioEngineParam)
, m_client(nullptr)
, m_active(false)
@@ -425,16 +419,6 @@ AudioJack::setupWidget::setupWidget(QWidget* parent)
m_clientName = new QLineEdit(cn, this);
form->addRow(tr("Client name"), m_clientName);
auto m = new gui::LcdSpinBoxModel(/* this */);
m->setRange(DEFAULT_CHANNELS, DEFAULT_CHANNELS);
m->setStep(2);
m->setValue(ConfigManager::inst()->value("audiojack", "channels").toInt());
m_channels = new gui::LcdSpinBox(1, this);
m_channels->setModel(m);
form->addRow(tr("Channels"), m_channels);
}
@@ -442,7 +426,6 @@ AudioJack::setupWidget::setupWidget(QWidget* parent)
AudioJack::setupWidget::~setupWidget()
{
delete m_channels->model();
}
@@ -451,7 +434,6 @@ AudioJack::setupWidget::~setupWidget()
void AudioJack::setupWidget::saveSettings()
{
ConfigManager::inst()->setValue("audiojack", "clientname", m_clientName->text());
ConfigManager::inst()->setValue("audiojack", "channels", QString::number(m_channels->value<int>()));
}