hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

MixerWorkerThread: exit outer loop in processJobQueue() if finished

Browse Source 
Exit the outer loop of processJobQueue() Only as soon as we went through
the job queue without having processed at least one job.

In MixerWorkerThread::waitForJobs() re-introduced "pause" instruction on
x86 and x86_64 giving better performance on HyperThreading systems.

These improvements however still do not solve all performance and
multithreading issues.
This commit is contained in:
Tobias Doerffel
2009-10-19 01:04:18 +02:00
parent 05b1325c09
commit 4f5d31f862
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/core/MixerWorkerThread.cpp
View File

@@ -63,8 +63,10 @@ void MixerWorkerThread::quit()
void MixerWorkerThread::processJobQueue()
{
while( s_jobQueue.itemsDone != s_jobQueue.queueSize )
bool processedJob = true;
while( processedJob && (int) s_jobQueue.itemsDone < (int) s_jobQueue.queueSize )
{
processedJob = false;
for( int i = 0; i < s_jobQueue.queueSize; ++i )
{
ThreadableJob * job =
@@ -72,6 +74,7 @@ void MixerWorkerThread::processJobQueue()
if( job )
{
job->process( m_workingBuf );
processedJob = true;
s_jobQueue.itemsDone.fetchAndAddOrdered( 1 );
}
}
@@ -118,6 +121,13 @@ void MixerWorkerThread::waitForJobs()
// TODO: this is dirty!
mixer * m = engine::getMixer();
m->m_workers[m->m_numWorkers]->processJobQueue();
while( (int) s_jobQueue.itemsDone < (int) s_jobQueue.queueSize )
{
#if defined(LMMS_HOST_X86) || defined(LMMS_HOST_X86_64)
asm( "pause" );
#endif
}
}