hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

More prominent search (#6968)

Browse Source 
Make the search features more prominent by adding an icon with a magnifying glass to the line edits. Because there is no specific icon for "search" the same icon as for "zoom" is used.

Make the "Search" text translatable in `PluginBrowser.cpp` and add a search icon.

Make the search in the effects selection dialog more similar to the other ones by adding a search icon and a placeholder text and by enabling the clear button.

Make some whitespace adjustments in the vicinity of the other adjustments.

Use function pointers instead of signals and slots for some connections. Use a lambda for the slot in the file browser code because GCC does not compile if the parameters differ between the connected functions. It seems that it cannot deal with default parameters.

It could be considered to create the search line edits in a factory although this would not work for the effects select dialog because its line edit is created in the UI file. In that case we'd have to add an additional method like `embellishLineEditForSearch(QLineEdit*)` or something similar to the factory.

Fixes #6966.
This commit is contained in:
Michael Gregorius
2023-11-06 20:24:37 +01:00
committed by GitHub
parent 3342e171c0
commit 6d4343ca94
3 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/gui/FileBrowser.cpp
View File

@@ -121,11 +121,12 @@ FileBrowser::FileBrowser(const QString & directories, const QString & filter,
searchWidgetLayout->setContentsMargins(0, 0, 0, 0);
searchWidgetLayout->setSpacing( 0 );
m_filterEdit = new QLineEdit( searchWidget );
m_filterEdit->setPlaceholderText( tr("Search") );
m_filterEdit->setClearButtonEnabled( true );
connect( m_filterEdit, SIGNAL( textEdited( const QString& ) ),
this, SLOT( filterAndExpandItems( const QString& ) ) );
m_filterEdit = new QLineEdit(searchWidget);
m_filterEdit->setPlaceholderText(tr("Search"));
m_filterEdit->setClearButtonEnabled(true);
m_filterEdit->addAction(embed::getIconPixmap("zoom"), QLineEdit::LeadingPosition);
connect(m_filterEdit, &QLineEdit::textEdited, [this](const QString & filter) { filterAndExpandItems(filter); });
auto reload_btn = new QPushButton(embed::getIconPixmap("reload"), QString(), searchWidget);
reload_btn->setToolTip( tr( "Refresh list" ) );

7
src/gui/PluginBrowser.cpp
View File

@@ -68,9 +68,10 @@ PluginBrowser::PluginBrowser( QWidget * _parent ) :
hint->setWordWrap( true );
auto searchBar = new QLineEdit(m_view);
searchBar->setPlaceholderText( "Search" );
searchBar->setMaxLength( 64 );
searchBar->setClearButtonEnabled( true );
searchBar->setPlaceholderText(tr("Search"));
searchBar->setMaxLength(64);
searchBar->setClearButtonEnabled(true);
searchBar->addAction(embed::getIconPixmap("zoom"), QLineEdit::LeadingPosition);
m_descTree = new QTreeWidget( m_view );
m_descTree->setColumnCount( 1 );

13
src/gui/modals/EffectSelectDialog.cpp
View File

@@ -98,12 +98,13 @@ EffectSelectDialog::EffectSelectDialog( QWidget * _parent ) :
m_model.setSourceModel( &m_sourceModel );
m_model.setFilterCaseSensitivity( Qt::CaseInsensitive );
connect( ui->filterEdit, SIGNAL( textChanged( const QString& ) ),
&m_model, SLOT( setFilterFixedString( const QString& ) ) );
connect( ui->filterEdit, SIGNAL( textChanged( const QString& ) ),
this, SLOT(updateSelection()));
connect( ui->filterEdit, SIGNAL( textChanged( const QString& ) ),
SLOT(sortAgain()));
ui->filterEdit->setPlaceholderText(tr("Search"));
ui->filterEdit->setClearButtonEnabled(true);
ui->filterEdit->addAction(embed::getIconPixmap("zoom"), QLineEdit::LeadingPosition);
connect(ui->filterEdit, &QLineEdit::textChanged, &m_model, &QSortFilterProxyModel::setFilterFixedString);
connect(ui->filterEdit, &QLineEdit::textChanged, this, &EffectSelectDialog::updateSelection);
connect(ui->filterEdit, &QLineEdit::textChanged, this, &EffectSelectDialog::sortAgain);
ui->pluginList->setModel( &m_model );