hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

AutomatableModelTest: Improve tests

Browse Source 
Check whether returned pointers from the cast are equal to the original
pointers, rather than just checking wether they are not `nullptr`.
This commit is contained in:
Johannes Lorenz
2019-04-27 10:48:37 +02:00
parent 0fd5693e12
commit 8d005e7565
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/src/core/AutomatableModelTest.cpp
View File

@@ -32,21 +32,23 @@ class AutomatableModelTest : QTestSuite
Q_OBJECT
private slots:
//! Test that upcast and exact casts work,
//! but no downcast or any other casts
void CastTests()
{
ComboBoxModel comboModel;
AutomatableModel* amPtr = &comboModel;
QCOMPARE(nullptr, amPtr->dynamicCast<FloatModel>());
QVERIFY(nullptr != amPtr->dynamicCast<AutomatableModel>());
QVERIFY(nullptr != amPtr->dynamicCast<IntModel>());
QVERIFY(nullptr != amPtr->dynamicCast<ComboBoxModel>());
QCOMPARE(nullptr, amPtr->dynamicCast<FloatModel>()); // not a parent class
QCOMPARE(&comboModel, amPtr->dynamicCast<AutomatableModel>()); // parent class
QCOMPARE(&comboModel, amPtr->dynamicCast<IntModel>()); // parent class
QCOMPARE(&comboModel, amPtr->dynamicCast<ComboBoxModel>()); // same class
IntModel intModel;
IntModel* imPtr = &intModel;
QCOMPARE(nullptr, imPtr->dynamicCast<FloatModel>());
QVERIFY(nullptr != imPtr->dynamicCast<AutomatableModel>());
QVERIFY(nullptr != imPtr->dynamicCast<IntModel>());
QCOMPARE(nullptr, imPtr->dynamicCast<ComboBoxModel>());
QCOMPARE(nullptr, imPtr->dynamicCast<FloatModel>()); // not a parent class
QCOMPARE(&intModel, imPtr->dynamicCast<AutomatableModel>()); // parent class
QCOMPARE(&intModel, imPtr->dynamicCast<IntModel>()); // same class
QCOMPARE(nullptr, imPtr->dynamicCast<ComboBoxModel>()); // child class
}
} AutomatableModelTests;