hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

InlineAutomation: delete attached AutomationPattern immediately

Browse Source 
It was not safe to immediately delete the AutomationPattern attached to
an InlineAutomation object before commit "InlineAutomation: delete
attached AutomationPattern immediately" as the AutomationPattern
destructor sometimes fiddles around with AutomationEditor (GUI!).
However this has changed now and this enables us to delete the
AutomationPattern immediately. This fixes some random crashes with
scheduling AutomationPatterns for later deletion.

Closes #2982696.
(cherry picked from commit a9abdc3e75)
This commit is contained in:
Tobias Doerffel
2010-05-21 12:57:01 +02:00
parent aa992e8e1b
commit 95b0c827d1
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/inline_automation.h
View File

@@ -1,8 +1,8 @@
/*
* inline_automation.h - class for automating something "inline"
*
* Copyright (c) 2008 Tobias Doerffel <tobydox/at/users.sourceforge.net>
*
* Copyright (c) 2008-2010 Tobias Doerffel <tobydox/at/users.sourceforge.net>
*
* This file is part of Linux MultiMedia Studio - http://lmms.sourceforge.net
*
* This program is free software; you can redistribute it and/or
@@ -22,7 +22,6 @@
*
*/
#ifndef _INLINE_AUTOMATION_H
#define _INLINE_AUTOMATION_H
@@ -44,7 +43,7 @@ public:
{
if( m_autoPattern )
{
m_autoPattern->deleteLater();
delete m_autoPattern;
}
}
@@ -65,7 +64,7 @@ public:
m_autoPattern = new automationPattern( NULL );
m_autoPattern->addObject( this );
}
return( m_autoPattern );
return m_autoPattern;
}
virtual void saveSettings( QDomDocument & _doc, QDomElement & _parent );