hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Remove "GENERAL SETTINGS" tab (#7188)

Browse Source 
Remove the "GENERAL SETTINGS" tab from the instrument track and sample track window.

This removes clutter as well as dependencies to the non-scalable `TabWidget`.

Remove superfluous calls to `setSpacing` which have set the default value of 6.

Use the default content margins of (9, 9, 9, 9) instead of (8, 8, 8, 8).
This commit is contained in:
Michael Gregorius
2024-04-01 20:06:18 +02:00
committed by GitHub
parent 5d5d8f8f14
commit 9dd7f4dde4
2 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/gui/SampleTrackWindow.cpp
View File

@@ -40,7 +40,6 @@
#include "SampleTrackView.h"
#include "Song.h"
#include "SubWindow.h"
#include "TabWidget.h"
#include "TrackLabelButton.h"
namespace lmms::gui
@@ -69,13 +68,9 @@ SampleTrackWindow::SampleTrackWindow(SampleTrackView * tv) :
vlayout->setContentsMargins(0, 0, 0, 0);
vlayout->setSpacing(0);
auto generalSettingsWidget = new TabWidget(tr("GENERAL SETTINGS"), this);
auto generalSettingsWidget = new QWidget(this);
auto generalSettingsLayout = new QVBoxLayout(generalSettingsWidget);
generalSettingsLayout->setContentsMargins(8, 18, 8, 8);
generalSettingsLayout->setSpacing(6);
auto nameWidget = new QWidget(generalSettingsWidget);
auto nameLayout = new QHBoxLayout(nameWidget);
nameLayout->setContentsMargins(0, 0, 0, 0);

6
src/gui/instrument/InstrumentTrackWindow.cpp
View File

@@ -93,13 +93,9 @@ InstrumentTrackWindow::InstrumentTrackWindow( InstrumentTrackView * _itv ) :
vlayout->setContentsMargins(0, 0, 0, 0);
vlayout->setSpacing( 0 );
auto generalSettingsWidget = new TabWidget(tr("GENERAL SETTINGS"), this);
auto generalSettingsWidget = new QWidget(this);
auto generalSettingsLayout = new QVBoxLayout(generalSettingsWidget);
generalSettingsLayout->setContentsMargins( 8, 18, 8, 8 );
generalSettingsLayout->setSpacing( 6 );
auto nameAndChangeTrackWidget = new QWidget(generalSettingsWidget);
auto nameAndChangeTrackLayout = new QHBoxLayout(nameAndChangeTrackWidget);
nameAndChangeTrackLayout->setContentsMargins( 0, 0, 0, 0 );