Give our threads names (#4356)

* Give our threads names

It helps with debugging.

* Use Q_OBJECT macro to automatically name threads.

By default, QThread sets its name based on the Qt meta class. To get an
accurate metaclass, the class which inherits QThread must declare
Q_OBJECT in its header. Futhermore, Qt's MOC requires that a Qt type be
the primary base class when declaring Q_OBJECT, hence the order of
base classes has been rearranged for some classes.

include/AudioAlsa.h

@@ -38,9 +38,9 @@
 #include "AudioDevice.h"
 
 
-class AudioAlsa : public AudioDevice, public QThread
+class AudioAlsa : public QThread, public AudioDevice
 {
-	// Public classes and enums
+	Q_OBJECT
 public:
 	/**
 	 * @brief Contains the relevant information about available ALSA devices

include/AudioDummy.h

@@ -31,8 +31,9 @@
 #include "Mixer.h"
 
 
-class AudioDummy : public AudioDevice, public QThread
+class AudioDummy : public QThread, public AudioDevice
 {
+	Q_OBJECT
 public:
 	AudioDummy( bool & _success_ful, Mixer* mixer ) :
 		AudioDevice( DEFAULT_CHANNELS, mixer )

include/AudioOss.h

@@ -39,8 +39,9 @@ class LcdSpinBox;
 class QLineEdit;
 
 
-class AudioOss : public AudioDevice, public QThread
+class AudioOss : public QThread, public AudioDevice
 {
+	Q_OBJECT
 public:
 	AudioOss( bool & _success_ful, Mixer* mixer );
 	virtual ~AudioOss();

include/AudioPulseAudio.h

@@ -41,8 +41,9 @@ class LcdSpinBox;
 class QLineEdit;
 
 
-class AudioPulseAudio : public AudioDevice, public QThread
+class AudioPulseAudio : public QThread, public AudioDevice
 {
+	Q_OBJECT
 public:
 	AudioPulseAudio( bool & _success_ful, Mixer* mixer );
 	virtual ~AudioPulseAudio();

include/AudioSndio.h

@@ -40,8 +40,9 @@ class LcdSpinBox;
 class QLineEdit;
 
 
-class AudioSndio : public AudioDevice, public QThread
+class AudioSndio : public QThread, public AudioDevice
 {
+	Q_OBJECT
 public:
 	AudioSndio( bool & _success_ful, Mixer * _mixer );
 	virtual ~AudioSndio();

include/MainWindow.h

@@ -29,7 +29,6 @@
 #include <QtCore/QTimer>
 #include <QtCore/QList>
 #include <QMainWindow>
-#include <QThread>
 
 #include "ConfigManager.h"
 #include "SubWindow.h"

include/MidiAlsaRaw.h

@@ -37,11 +37,11 @@
 
 
 struct pollfd;
-class QLineEdit;
 
 
-class MidiAlsaRaw : public MidiClientRaw , public QThread
+class MidiAlsaRaw : public QThread, public MidiClientRaw
 {
+	Q_OBJECT
 public:
 	MidiAlsaRaw();
 	virtual ~MidiAlsaRaw();

include/MidiAlsaSeq.h

@@ -39,7 +39,6 @@
 
 
 struct pollfd;
-class QLineEdit;
 
 
 class MidiAlsaSeq : public QThread, public MidiClient

include/MidiOss.h

@@ -35,11 +35,10 @@
 #include "MidiClient.h"
 
 
-class QLineEdit;
 
-
-class MidiOss : public MidiClientRaw, public QThread
+class MidiOss : public QThread, public MidiClientRaw
 {
+	Q_OBJECT
 public:
 	MidiOss();
 	virtual ~MidiOss();

include/MidiSndio.h

@@ -37,11 +37,10 @@
 
 #include "MidiClient.h"
 
-class QLineEdit;
 
-
-class MidiSndio : public MidiClientRaw, public QThread
+class MidiSndio : public QThread, public MidiClientRaw
 {
+	Q_OBJECT
 public:
 	MidiSndio( void );
 	virtual ~MidiSndio();

include/MixerWorkerThread.h

@@ -35,6 +35,7 @@ class ThreadableJob;
 
 class MixerWorkerThread : public QThread
 {
+	Q_OBJECT
 public:
 	// internal representation of the job queue - all functions are thread-safe
 	class JobQueue

include/Pattern.h

@@ -29,7 +29,6 @@
 #include <QtCore/QVector>
 #include <QWidget>
 #include <QDialog>
-#include <QtCore/QThread>
 #include <QPixmap>
 #include <QStaticText>
 

include/RemotePlugin.h

@@ -749,6 +749,7 @@ class RemotePlugin;
 
 class ProcessWatcher : public QThread
 {
+	Q_OBJECT
 public:
 	ProcessWatcher( RemotePlugin * );
 	virtual ~ProcessWatcher()

src/core/Mixer.cpp

@@ -1090,6 +1090,7 @@ Mixer::fifoWriter::fifoWriter( Mixer* mixer, fifo * _fifo ) :
 	m_fifo( _fifo ),
 	m_writing( true )
 {
+	setObjectName("Mixer::fifoWriter");
 }