hashtags/lmms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Fix several problems (#8032)

Browse Source 
## Fix problems with lifetime of `QByteArray`

Fix a problem with the lifetime of a `QByteArray` in
`attemptToReconnectOutput` and `attemptToReconnectInput`.

The method `constData` was called on a temporary which gets destroyed
before `targetName` and `sourceName` are used, thus leading to undefined
behavior.

## Fix index checks

Fix index checks in `attemptToReconnectOutput` and
`attemptToReconnectInput`.

The previous code would have allowed an index to be `size` of the
underlying vector which would access out-of-bounds memory.

## Braces for one-liner if statements

Add braces for one-liner if statements.
This commit is contained in:
Michael Gregorius
2025-08-07 12:12:18 +02:00
committed by GitHub
parent 88ed51edb9
commit ab050b88e5
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/core/audio/AudioJack.cpp
View File

@@ -261,7 +261,7 @@ void AudioJack::attemptToConnect(size_t index, const char *lmms_port_type, const
void AudioJack::attemptToReconnectOutput(size_t outputIndex, const QString& targetPort)
{
if (outputIndex > m_outputPorts.size()) return;
if (outputIndex >= m_outputPorts.size()) { return; }
if (targetPort == disconnectedRepresentation)
{
@@ -270,14 +270,14 @@ void AudioJack::attemptToReconnectOutput(size_t outputIndex, const QString& targ
}
auto outputName = jack_port_name(m_outputPorts[outputIndex]);
auto targetName = targetPort.toLatin1().constData();
auto targetName = targetPort.toLatin1();
attemptToConnect(outputIndex, "output", outputName, targetName);
attemptToConnect(outputIndex, "output", outputName, targetName.constData());
}
void AudioJack::attemptToReconnectInput(size_t inputIndex, const QString& sourcePort)
{
if (inputIndex > m_inputPorts.size()) return;
if (inputIndex >= m_inputPorts.size()) { return; }
if (sourcePort == disconnectedRepresentation)
{
@@ -286,9 +286,9 @@ void AudioJack::attemptToReconnectInput(size_t inputIndex, const QString& source
}
auto inputName = jack_port_name(m_inputPorts[inputIndex]);
auto sourceName = sourcePort.toLatin1().constData();
auto sourceName = sourcePort.toLatin1();
attemptToConnect(inputIndex, "input", sourceName, inputName);
attemptToConnect(inputIndex, "input", sourceName.constData(), inputName);
}